[MDL-38418] Course grade settings: open all fieldsets - Moodle Tracker

Details

Type: Sub-task
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.5
Fix Version/s: 2.5
Component/s: Forms Library
Labels:
- triaged
- ui_change

Testing Instructions:
1. Go to Home ► Adrian's course ► Grade administration ► Course grade settings ► Grades ► Edit ► Course settings
2. Make sure each section is expanded
Affected Branches:
MOODLE_25_STABLE
Fixed Branches:
MOODLE_25_STABLE
Pull from Repository:
git://github.com/FMCorz/moodle.git
Pull Master Branch:
~~MDL-38418~~-master
Pull Master Diff URL:
https://github.com/FMCorz/moodle/compare/8673a98d1db81b86606ccf67ba9476a12284b780...MDL-38418-master

Description

Open all the fieldsets by default

Gliffy Diagrams

Attachments

Issue Links

is blocked by

MDL-38435 setExpanded not longer works

Closed

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Adrian Greeve added a comment - 15/Mar/13 1:27 AM

[Y] Syntax
[Y] Output
[Y] Whitespace
[-] Language
[-] Databases
[*] Testing
[-] Security
[-] Documentation
[Y] Git
[Y] Sanity check

Hello Fred,

The code looks good and works as described.

I personally am not a huge fan of the test instructions. Maybe you could remove your course name as this had me confused when I saw it. When I was moving through the navigation tree I didn't realise I was on the correct page until I noticed that the breadcrumbs at the top matched point one of your testing instructions.

Anyway, nothing serious at all.

Thanks.

Show

Adrian Greeve added a comment - 15/Mar/13 1:27 AM [Y] Syntax [Y] Output [Y] Whitespace [-] Language [-] Databases [*] Testing [-] Security [-] Documentation [Y] Git [Y] Sanity check Hello Fred, The code looks good and works as described. I personally am not a huge fan of the test instructions. Maybe you could remove your course name as this had me confused when I saw it. When I was moving through the navigation tree I didn't realise I was on the correct page until I noticed that the breadcrumbs at the top matched point one of your testing instructions. Anyway, nothing serious at all. Thanks.

Hide

Permalink

Frédéric Massart added a comment - 15/Mar/13 2:24 AM

Cheers Adrian!

Show

Frédéric Massart added a comment - 15/Mar/13 2:24 AM Cheers Adrian!

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 19/Mar/13 10:16 PM

Integrated (master only), thanks!

Show

Eloy Lafuente (stronk7) added a comment - 19/Mar/13 10:16 PM Integrated (master only), thanks!

Hide

Permalink

Andrew Davis added a comment - 20/Mar/13 2:21 AM

Passing.

Show

Andrew Davis added a comment - 20/Mar/13 2:21 AM Passing.

Hide

Permalink

Damyon Wiese added a comment - 22/Mar/13 7:24 AM

This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

Thanks for your contributions!

Show

Damyon Wiese added a comment - 22/Mar/13 7:24 AM This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads). Thanks for your contributions!

People

Assignee:

Frédéric Massart

Reporter:

Martin Dougiamas

Peer reviewer:

Adrian Greeve

Integrator:

Eloy Lafuente (stronk7)

Tester:

Andrew Davis

Participants:

Adrian Greeve, Andrew Davis, Damyon Wiese, Eloy Lafuente (stronk7), Frédéric Massart, Martin Dougiamas

Votes:

0 Vote for this issue

Watchers:

5 Start watching this issue

Dates

Created:

11/Mar/13 9:23 AM

Updated:

30/Sep/13 1:28 PM

Resolved:

22/Mar/13 7:24 AM

Fix Release Date:

14/May/13