Moodle

Course grade settings: open all fieldsets

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.5
  • Fix Version/s: 2.5
  • Component/s: Forms Library
  • Labels:

Description

Open all the fieldsets by default

Issue Links

is blocked by

Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-38435 setExpanded not longer works

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Adrian Greeve added a comment -

[Y] Syntax
[Y] Output
[Y] Whitespace
[-] Language
[-] Databases
[*] Testing
[-] Security
[-] Documentation
[Y] Git
[Y] Sanity check

Hello Fred,

The code looks good and works as described.

I personally am not a huge fan of the test instructions. Maybe you could remove your course name as this had me confused when I saw it. When I was moving through the navigation tree I didn't realise I was on the correct page until I noticed that the breadcrumbs at the top matched point one of your testing instructions.

Anyway, nothing serious at all.

Thanks.

Show
Adrian Greeve added a comment - [Y] Syntax [Y] Output [Y] Whitespace [-] Language [-] Databases [*] Testing [-] Security [-] Documentation [Y] Git [Y] Sanity check Hello Fred, The code looks good and works as described. I personally am not a huge fan of the test instructions. Maybe you could remove your course name as this had me confused when I saw it. When I was moving through the navigation tree I didn't realise I was on the correct page until I noticed that the breadcrumbs at the top matched point one of your testing instructions. Anyway, nothing serious at all. Thanks.
Hide
Permalink
Frédéric Massart added a comment -

Cheers Adrian!

Show
Frédéric Massart added a comment - Cheers Adrian!
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Integrated (master only), thanks!

Show
Eloy Lafuente (stronk7) added a comment - Integrated (master only), thanks!
Hide
Permalink
Andrew Davis added a comment -

Passing.

Show
Andrew Davis added a comment - Passing.
Hide
Permalink
Damyon Wiese added a comment -

This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

Thanks for your contributions!

Show
Damyon Wiese added a comment - This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads). Thanks for your contributions!

People

Vote (0)
Watch (5)

Dates

  • Created:
    Updated:
    Resolved: