Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38419

LTI - external tool - when force SSL checked, URLs get corrupted

    Details

      Description

      when setting up an external tool and checking the "force ssl" option, URLs during launch process get corrupted.

      noticed that:

        Gliffy Diagrams

          Activity

          Hide
          salvetore Michael de Raadt added a comment -

          Thanks for reporting this.

          I've put that on the backlog.

          In the meantime, feel free to help us work on this issue. If you are able to provide a patch or links to your Git repository branch, please add a patch label so we will spot it.

          Show
          salvetore Michael de Raadt added a comment - Thanks for reporting this. I've put that on the backlog. In the meantime, feel free to help us work on this issue. If you are able to provide a patch or links to your Git repository branch, please add a patch label so we will spot it.
          Hide
          bushido Mark Nielsen added a comment -

          This fix should be safe to backport, it includes unit test.

          Show
          bushido Mark Nielsen added a comment - This fix should be safe to backport, it includes unit test.
          Hide
          rwijaya Rossiani Wijaya added a comment -

          Hi Mark,

          The patch looks good.

          Could you please add testing instructions before I submit this for integration review?

          [y] Syntax
          [y] Whitespace
          [-] Output
          [-] Language
          [-] Databases
          [-] Testing
          [-] Security
          [-] Documentation
          [y] Git
          [y] Sanity check

          Show
          rwijaya Rossiani Wijaya added a comment - Hi Mark, The patch looks good. Could you please add testing instructions before I submit this for integration review? [y] Syntax [y] Whitespace [-] Output [-] Language [-] Databases [-] Testing [-] Security [-] Documentation [y] Git [y] Sanity check
          Hide
          bushido Mark Nielsen added a comment -

          Does run unit tests count? Otherwise, we could try making a tool that launches to http://www.imsglobal.org/developers/LTI/test/v1p1/tool.php but I'm not sure at the moment if it will accept https connections.

          Show
          bushido Mark Nielsen added a comment - Does run unit tests count? Otherwise, we could try making a tool that launches to http://www.imsglobal.org/developers/LTI/test/v1p1/tool.php but I'm not sure at the moment if it will accept https connections.
          Hide
          rwijaya Rossiani Wijaya added a comment -

          It would probably better to have it tested on the browser as well. Unit test is usually done to test the API or specific function.

          Testing instructions could be similar to the description statement.

          Show
          rwijaya Rossiani Wijaya added a comment - It would probably better to have it tested on the browser as well. Unit test is usually done to test the API or specific function. Testing instructions could be similar to the description statement.
          Hide
          bushido Mark Nielsen added a comment -

          Updated, thanks

          Show
          bushido Mark Nielsen added a comment - Updated, thanks
          Hide
          bushido Mark Nielsen added a comment -

          Please submit for integration

          Show
          bushido Mark Nielsen added a comment - Please submit for integration
          Hide
          rwijaya Rossiani Wijaya added a comment -

          Submitting for integration review.

          Show
          rwijaya Rossiani Wijaya added a comment - Submitting for integration review.
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          poltawski Dan Poltawski added a comment -

          Thanks Mark, integrated to master, 25 and 24

          Show
          poltawski Dan Poltawski added a comment - Thanks Mark, integrated to master, 25 and 24
          Hide
          poltawski Dan Poltawski added a comment -

          The testing instructions were a bit weird (especially since browsers these days make it really damn difficult to work out which protocol is in use). However it seemed ok and i'm confinet in the unit tests.

          Show
          poltawski Dan Poltawski added a comment - The testing instructions were a bit weird (especially since browsers these days make it really damn difficult to work out which protocol is in use). However it seemed ok and i'm confinet in the unit tests.
          Hide
          poltawski Dan Poltawski added a comment -

          Congratulations - this issue has been included in Moodle and is now available on our git mirrors and shortly will become available on the download servers shortly.

          Show
          poltawski Dan Poltawski added a comment - Congratulations - this issue has been included in Moodle and is now available on our git mirrors and shortly will become available on the download servers shortly.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Nov/13