Moodle
  1. Moodle
  2. MDL-33934 META: Issues with MyMobile theme
  3. MDL-38422

WYSWYG (TinyMCE) html editor difficulties when using MyMobile theme (Part 2)

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.6, 2.4.3
    • Fix Version/s: 2.3.7, 2.4.4
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Select MyMobile theme from Theme selector.
      2. Set MyMobile theme as Mobile and Tablet device types.
      3. Log into moodle using mobile / tablet device.
      4. Create or edit anywhere where a WYSWYG (TinyMCE) html editor would appear such that the text extends beyond the end of the current line.
      5. Type anything, then tap outside the WYSWYG (TinyMCE) box.
      6. TEST that when attempting to type anything you get some response.
      Show
      Select MyMobile theme from Theme selector. Set MyMobile theme as Mobile and Tablet device types. Log into moodle using mobile / tablet device. Create or edit anywhere where a WYSWYG (TinyMCE) html editor would appear such that the text extends beyond the end of the current line. Type anything, then tap outside the WYSWYG (TinyMCE) box. TEST that when attempting to type anything you get some response.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull 2.4 Branch:
      wip-MDL-38422_M24
    • Rank:
      48354

      Description

      This is Part 2 of MDL-31342 WYSWYG (TinyMCE) html editor difficulties when using MyMobile theme

        Issue Links

          Activity

          Hide
          Gareth J Barnard added a comment -

          Thanks Mary,

          As this is a new issue, the branches should only take five mins per branch as moving 'div's is easy compared to code-checking and making Moodle couture.

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Thanks Mary, As this is a new issue, the branches should only take five mins per branch as moving 'div's is easy compared to code-checking and making Moodle couture. Cheers, Gareth
          Hide
          Mary Evans added a comment -

          Just testing!

          Show
          Mary Evans added a comment - Just testing!
          Hide
          Mary Evans added a comment -

          WOW! What a difference. Is it me or does it look smarter? See frontpage image (MDL-38422-FP) The footer is nicely centred which is wasn't before. The Purge caches link is in the centre and so too are the performance info and validation links. Moving the page closing div seems to have done the trick.

          I purged caches which I did not add as a prerequisite for testing so may be it needs adding.

          Also, because I am testing this on my PC it may not perform the same as if it were on a Mobile or Tablet.

          I added a message in the Site News section. I was able to add an image, plus add and delete a file, and write text with comparative ease.

          The file picker was a bit slow but that could be my WAMP server. But all in all, it seems to be working as required.

          +1 from me.
          Thanks.

          Show
          Mary Evans added a comment - WOW! What a difference. Is it me or does it look smarter? See frontpage image ( MDL-38422 -FP) The footer is nicely centred which is wasn't before. The Purge caches link is in the centre and so too are the performance info and validation links. Moving the page closing div seems to have done the trick. I purged caches which I did not add as a prerequisite for testing so may be it needs adding. Also, because I am testing this on my PC it may not perform the same as if it were on a Mobile or Tablet. I added a message in the Site News section. I was able to add an image, plus add and delete a file, and write text with comparative ease. The file picker was a bit slow but that could be my WAMP server. But all in all, it seems to be working as required. +1 from me. Thanks.
          Hide
          Mary Evans added a comment -

          @Gareth:

          Just as an aside, comparing the two branches, I thought Moodle 2.3 worked better than Moodle 2.4. What do you think? It seemed smoother, more fluid. Could this be my imagination, or my server, or is M24 a lot different to work with?

          I can't say I have noticed this before as I tend to use Moodle master when working on theme of my own, but Moodle 2.3 does seem to have an edge on Moodle 2.4.

          That said this test it pretty minimalist I guess.

          Show
          Mary Evans added a comment - @Gareth: Just as an aside, comparing the two branches, I thought Moodle 2.3 worked better than Moodle 2.4. What do you think? It seemed smoother, more fluid. Could this be my imagination, or my server, or is M24 a lot different to work with? I can't say I have noticed this before as I tend to use Moodle master when working on theme of my own, but Moodle 2.3 does seem to have an edge on Moodle 2.4. That said this test it pretty minimalist I guess.
          Hide
          Gareth J Barnard added a comment -

          Dear Mary Evans,

          After a 'purge all caches' could be a whole range of performance things especially being a WAMP server . Do you have the same debug settings etc?

          I think the real performance will come with adding Andrew Nicols's YUI loader .

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Dear Mary Evans , After a 'purge all caches' could be a whole range of performance things especially being a WAMP server . Do you have the same debug settings etc? I think the real performance will come with adding Andrew Nicols's YUI loader . Cheers, Gareth
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (23 & 24), thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (23 & 24), thanks!
          Hide
          Adrian Greeve added a comment -

          Tested on the 2.3 and 2.4 integration branches.
          Tapping outside of the WYSIWYG doesn't give any difficulties.
          Test passed.

          Show
          Adrian Greeve added a comment - Tested on the 2.3 and 2.4 integration branches. Tapping outside of the WYSIWYG doesn't give any difficulties. Test passed.
          Hide
          Damyon Wiese added a comment -

          This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

          Thanks for your contributions!

          Show
          Damyon Wiese added a comment - This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads). Thanks for your contributions!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: