Moodle
  1. Moodle
  2. MDL-38424

Formal White Theme would be more user friendly if it had color link selectors for hyperlink behavior

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.6, 2.4, 2.5
    • Fix Version/s: 2.3.7, 2.4.4
    • Component/s: Themes
    • Labels:
    • Rank:
      48356

      Description

      Wouldn't it be more user friendly (and consistent) to have the themes all have a color selector tool for hyperlinks (Formal White Theme and some others do not)

        Activity

        Hide
        Mary Evans added a comment -

        I don't agree, I would rather every theme had a Custom CSS box then the Administrator could add link colours by adding the a:link, a:visited, a:hover, a:active, a:focus CSS themselves.

        Show
        Mary Evans added a comment - I don't agree, I would rather every theme had a Custom CSS box then the Administrator could add link colours by adding the a:link, a:visited, a:hover, a:active, a:focus CSS themselves.
        Hide
        Nathan Hammond added a comment -

        Well, okay. But how about this? Maybe one could add in some help text (sample code) for the more novice backend users. This could be similar to what is provided for the custom menu items area where documentation is provided for how to create pull down menues. /admin/settings.php?section=themesettings

        Show
        Nathan Hammond added a comment - Well, okay. But how about this? Maybe one could add in some help text (sample code) for the more novice backend users. This could be similar to what is provided for the custom menu items area where documentation is provided for how to create pull down menues. /admin/settings.php?section=themesettings
        Hide
        Mary Evans added a comment -

        Have you any particular theme in mind other than Formal White? I wouldn't mind adding some more features to those themes that don't have custom settings.

        When you have had a think, why not create a new issue and suggest something like...
        Add colour picker for link and hover in xyz theme. Where xyz is the theme or themes of your choice.

        You may not have noticed, but I have triaged this tracker issue, and re assigned it to Daniele Cordella who is Italian, and so takes pride in his work with this theme. I am sure it is an over site that the hover colour picker does not exist in this theme. However I am sure Daniele will remedy that when he finds time.

        Show
        Mary Evans added a comment - Have you any particular theme in mind other than Formal White? I wouldn't mind adding some more features to those themes that don't have custom settings. When you have had a think, why not create a new issue and suggest something like... Add colour picker for link and hover in xyz theme. Where xyz is the theme or themes of your choice. You may not have noticed, but I have triaged this tracker issue, and re assigned it to Daniele Cordella who is Italian, and so takes pride in his work with this theme. I am sure it is an over site that the hover colour picker does not exist in this theme. However I am sure Daniele will remedy that when he finds time.
        Hide
        Daniele Cordella added a comment -

        In my honest opinion, the color of the links is not a serious problem because, as Mary already wrote, just by adding

        a:link, a:visited, a:hover, a:active, a:focus {color:red;}

        to the (theme_formal_white | customcss) field, fixes the issue.

        Further more:
        -> more color pickers will clutter the page more than it is already cluttered now
        -> how many color pickers? Five (link, visited, hover, active, focus)?
        -> and why do not differentiate links within blocks by links in the frame of the course?

        And all of this to save one row in the customcss field?
        My -1 to fix this issue.

        Show
        Daniele Cordella added a comment - In my honest opinion, the color of the links is not a serious problem because, as Mary already wrote, just by adding a:link, a:visited, a:hover, a:active, a:focus {color:red;} to the (theme_formal_white | customcss) field, fixes the issue. Further more: -> more color pickers will clutter the page more than it is already cluttered now -> how many color pickers? Five (link, visited, hover, active, focus)? -> and why do not differentiate links within blocks by links in the frame of the course? And all of this to save one row in the customcss field? My -1 to fix this issue.
        Hide
        Andrea Bicciolo added a comment - - edited

        As formal withe is a neutral theme that aims to be easy to customize, also in my opinion the idea of adding specific link color in it's CSS may not be the best choice.

        However, a hint in the theme settings page that suggests examples on how to add custom color to links could be surely helpful.

        So my -1 to fix the issue but my +1 to update language strings to include the examples.

        Show
        Andrea Bicciolo added a comment - - edited As formal withe is a neutral theme that aims to be easy to customize, also in my opinion the idea of adding specific link color in it's CSS may not be the best choice. However, a hint in the theme settings page that suggests examples on how to add custom color to links could be surely helpful. So my -1 to fix the issue but my +1 to update language strings to include the examples.
        Hide
        Mary Evans added a comment -

        Setting this for Integration as it looks fine to me.

        Show
        Mary Evans added a comment - Setting this for Integration as it looks fine to me.
        Hide
        Mary Evans added a comment -

        I have changed this to a bug, so that changes can be added to stable backlog otherwise as an improvement this would only be allowed in Moodle (master).

        Show
        Mary Evans added a comment - I have changed this to a bug, so that changes can be added to stable backlog otherwise as an improvement this would only be allowed in Moodle (master).
        Hide
        Daniele Cordella added a comment -

        Thanks Mary. As usual your contribution is wise!

        Show
        Daniele Cordella added a comment - Thanks Mary. As usual your contribution is wise!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (23, 24 & master), thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (23, 24 & master), thanks!
        Hide
        Adrian Greeve added a comment -

        There are no testing instructions for this issue.
        What I did was I visited [Site administration ► Appearance ► Themes ► Formal white] and checked that I could see the string change that appears in the diff.

        Test passed.

        Show
        Adrian Greeve added a comment - There are no testing instructions for this issue. What I did was I visited [Site administration ► Appearance ► Themes ► Formal white] and checked that I could see the string change that appears in the diff. Test passed.
        Hide
        Daniele Cordella added a comment -

        I am sorry, Adrian. It is my fault. I forgot to add instruction because of the triviality of the patch. I am sorry again.

        Show
        Daniele Cordella added a comment - I am sorry, Adrian. It is my fault. I forgot to add instruction because of the triviality of the patch. I am sorry again.
        Hide
        Damyon Wiese added a comment -

        This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

        Thanks for your contributions!

        Show
        Damyon Wiese added a comment - This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads). Thanks for your contributions!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: