Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38429

Improve lesson statistics code

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.5, 2.4.2
    • Fix Version/s: 2.5
    • Component/s: Lesson
    • Labels:
    • Testing Instructions:
      Hide
      1. Create a lesson with several questions
      2. Attempt the lesson as student
      3. View the report for the lesson as teacher
      4. Do some more exploratory testing of the lesson module and look out for any warnings / errors produced.
      Show
      Create a lesson with several questions Attempt the lesson as student View the report for the lesson as teacher Do some more exploratory testing of the lesson module and look out for any warnings / errors produced.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      change all those NULL (upper) to null (lower)

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              gentlecat Roman Tsukanov added a comment -

              Changed uppercase NULLs to lowercase.

              Show
              gentlecat Roman Tsukanov added a comment - Changed uppercase NULLs to lowercase.
              Hide
              rwijaya Rossiani Wijaya added a comment -

              Hi Roman,

              Thank you for working on the patch. However I couldn't apply your patch to my branches. Therefore I created the git patches for 3 branches and give you the credits within the commit message.

              Show
              rwijaya Rossiani Wijaya added a comment - Hi Roman, Thank you for working on the patch. However I couldn't apply your patch to my branches. Therefore I created the git patches for 3 branches and give you the credits within the commit message.
              Hide
              gentlecat Roman Tsukanov added a comment -

              Thanks. It's my first contribution. I'm still trying to figure out how this works.

              Show
              gentlecat Roman Tsukanov added a comment - Thanks. It's my first contribution. I'm still trying to figure out how this works.
              Hide
              ankit_frenz Ankit Agarwal added a comment - - edited

              Hi Roman and Rosie,
              Patch looks great. Feel free to submit for integration. Although I suggest this to be master only as this is an improvment.
              Thanks

              Show
              ankit_frenz Ankit Agarwal added a comment - - edited Hi Roman and Rosie, Patch looks great. Feel free to submit for integration. Although I suggest this to be master only as this is an improvment. Thanks
              Hide
              rwijaya Rossiani Wijaya added a comment -

              Thanks Ankit for reviewing.

              Hi Roman,

              I decided to fix the rest of lesson code to use lowercase null and give you the credits for the lesson report page.

              Thank you for contributing to Moodle.

              Integrators,
              I created 3 patches for 2.3, 2.4 and master branches. Feel free to integrated to master only or all supported branches.

              Submitting for integration review.

              Show
              rwijaya Rossiani Wijaya added a comment - Thanks Ankit for reviewing. Hi Roman, I decided to fix the rest of lesson code to use lowercase null and give you the credits for the lesson report page. Thank you for contributing to Moodle. Integrators, I created 3 patches for 2.3, 2.4 and master branches. Feel free to integrated to master only or all supported branches. Submitting for integration review.
              Hide
              damyon Damyon Wiese added a comment -

              Thanks Rosie, this has been integrated to master only (improvement).

              I updated the test instructions a little to make it clearer.

              Show
              damyon Damyon Wiese added a comment - Thanks Rosie, this has been integrated to master only (improvement). I updated the test instructions a little to make it clearer.
              Hide
              fred Frédéric Massart added a comment -

              Passing, thanks!

              Show
              fred Frédéric Massart added a comment - Passing, thanks!
              Hide
              damyon Damyon Wiese added a comment -

              Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

              Show
              damyon Damyon Wiese added a comment - Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/May/13