Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.5, 2.4.2
    • Fix Version/s: 2.5
    • Component/s: Lesson
    • Labels:
    • Rank:
      48361

      Description

      change all those NULL (upper) to null (lower)

      1. patch.txt
        8 kB
        Roman Tsukanov

        Issue Links

          Activity

          Hide
          Roman Tsukanov added a comment -

          Changed uppercase NULLs to lowercase.

          Show
          Roman Tsukanov added a comment - Changed uppercase NULLs to lowercase.
          Hide
          Rossiani Wijaya added a comment -

          Hi Roman,

          Thank you for working on the patch. However I couldn't apply your patch to my branches. Therefore I created the git patches for 3 branches and give you the credits within the commit message.

          Show
          Rossiani Wijaya added a comment - Hi Roman, Thank you for working on the patch. However I couldn't apply your patch to my branches. Therefore I created the git patches for 3 branches and give you the credits within the commit message.
          Hide
          Roman Tsukanov added a comment -

          Thanks. It's my first contribution. I'm still trying to figure out how this works.

          Show
          Roman Tsukanov added a comment - Thanks. It's my first contribution. I'm still trying to figure out how this works.
          Hide
          Ankit Agarwal added a comment - - edited

          Hi Roman and Rosie,
          Patch looks great. Feel free to submit for integration. Although I suggest this to be master only as this is an improvment.
          Thanks

          Show
          Ankit Agarwal added a comment - - edited Hi Roman and Rosie, Patch looks great. Feel free to submit for integration. Although I suggest this to be master only as this is an improvment. Thanks
          Hide
          Rossiani Wijaya added a comment -

          Thanks Ankit for reviewing.

          Hi Roman,

          I decided to fix the rest of lesson code to use lowercase null and give you the credits for the lesson report page.

          Thank you for contributing to Moodle.

          Integrators,
          I created 3 patches for 2.3, 2.4 and master branches. Feel free to integrated to master only or all supported branches.

          Submitting for integration review.

          Show
          Rossiani Wijaya added a comment - Thanks Ankit for reviewing. Hi Roman, I decided to fix the rest of lesson code to use lowercase null and give you the credits for the lesson report page. Thank you for contributing to Moodle. Integrators, I created 3 patches for 2.3, 2.4 and master branches. Feel free to integrated to master only or all supported branches. Submitting for integration review.
          Hide
          Damyon Wiese added a comment -

          Thanks Rosie, this has been integrated to master only (improvement).

          I updated the test instructions a little to make it clearer.

          Show
          Damyon Wiese added a comment - Thanks Rosie, this has been integrated to master only (improvement). I updated the test instructions a little to make it clearer.
          Hide
          Frédéric Massart added a comment -

          Passing, thanks!

          Show
          Frédéric Massart added a comment - Passing, thanks!
          Hide
          Damyon Wiese added a comment -

          Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

          Show
          Damyon Wiese added a comment - Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: