Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: DEV backlog
    • Fix Version/s: 2.5
    • Component/s: Forms Library
    • Labels:
    • Testing Instructions:
      Hide

      Test level: advanced (code hack)

      1. Open the course settings page and make sure all sections are collapsed
      2. Add a folder and make sure the content section is expanded by default
      3. Add a multiplechoice question
        • Make sure all possible choices are collapsed
        • Hack question/type/multichoice/edit_multichoice_form.php:81 and add: $repeatedoptions['answserhdr']['expanded'] = true;
        • Make sure each Choice is expanded
        • Change the previous code hack to false
        • Make sure each Choice is collapsed
      Show
      Test level: advanced (code hack) Open the course settings page and make sure all sections are collapsed Add a folder and make sure the content section is expanded by default Add a multiplechoice question Make sure all possible choices are collapsed Hack question/type/multichoice/edit_multichoice_form.php:81 and add: $repeatedoptions ['answserhdr'] ['expanded'] = true; Make sure each Choice is expanded Change the previous code hack to false Make sure each Choice is collapsed
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-38435-master
    • Rank:
      48371

      Description

      It is no longer possible to auto expand a Collapsed region using setExpanded.

        Issue Links

          Activity

          Hide
          Frédéric Massart added a comment -

          In this patch, I mostly reverted the changes from MDL-37932. I think it is better to keep the consistency between setXXXX methods, so that they expect an element name, not an ID. So the logic to generate an ID, and use it belongs to setExpanded and not repeated elements any more.

          Show
          Frédéric Massart added a comment - In this patch, I mostly reverted the changes from MDL-37932 . I think it is better to keep the consistency between setXXXX methods, so that they expect an element name, not an ID. So the logic to generate an ID, and use it belongs to setExpanded and not repeated elements any more.
          Hide
          Damyon Wiese added a comment -

          Thanks Fred,

          It will be good to get this re-fixed for assignment.

          [Y] Syntax
          [-] Output
          [Y] Whitespace
          [-] Language
          [-] Databases
          [Y] Testing
          [-] Security
          [-] Documentation
          [Y] Git
          [Y] Sanity check

          One minor nit pick is that the english in this comment is wrong: "See if we the form has been submitted already."

          Another minor nitpick is we should not use "elseif"

          These are very minor nitpicks but the rest of the patch looks good and works well.

          +1 for this to go to integration.

          Show
          Damyon Wiese added a comment - Thanks Fred, It will be good to get this re-fixed for assignment. [Y] Syntax [-] Output [Y] Whitespace [-] Language [-] Databases [Y] Testing [-] Security [-] Documentation [Y] Git [Y] Sanity check One minor nit pick is that the english in this comment is wrong: "See if we the form has been submitted already." Another minor nitpick is we should not use "elseif" These are very minor nitpicks but the rest of the patch looks good and works well. +1 for this to go to integration.
          Hide
          Frédéric Massart added a comment -

          Thanks Damyon. I don't want to rebase all the issues this one blocks, so I'll take care of those 2 minor problems in an upcoming issue. Cheers!

          Show
          Frédéric Massart added a comment - Thanks Damyon. I don't want to rebase all the issues this one blocks, so I'll take care of those 2 minor problems in an upcoming issue. Cheers!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Damyon Wiese added a comment -

          Only taking this one because is it part of a set of issues to be reviewed together.

          Show
          Damyon Wiese added a comment - Only taking this one because is it part of a set of issues to be reviewed together.
          Hide
          Damyon Wiese added a comment -

          Thanks Fred, this has been integrated to master now - I can see you fixed those things I mentioned in the linked issues - so no changes from me.

          I'm running full behat tests on the MDL-38455 branch which includes this change.

          Show
          Damyon Wiese added a comment - Thanks Fred, this has been integrated to master now - I can see you fixed those things I mentioned in the linked issues - so no changes from me. I'm running full behat tests on the MDL-38455 branch which includes this change.
          Hide
          Michael de Raadt added a comment - - edited

          Test result: Success!

          I was actually wondering if this was a bug. I found this issue and it was ready for testing. How quick was that.

          Show
          Michael de Raadt added a comment - - edited Test result: Success! I was actually wondering if this was a bug. I found this issue and it was ready for testing. How quick was that.
          Hide
          Damyon Wiese added a comment -

          This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

          Thanks for your contributions!

          Show
          Damyon Wiese added a comment - This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads). Thanks for your contributions!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: