Details

    • Rank:
      48409

      Description

      Switch to an RTL language and notice the styles.

        Issue Links

          Activity

          Hide
          Frédéric Massart added a comment -

          Requesting peer review. The new style has been put in place according to Barbara's feedback.

          Show
          Frédéric Massart added a comment - Requesting peer review. The new style has been put in place according to Barbara's feedback.
          Hide
          Michael de Raadt added a comment -

          Hi, Nadav.

          I thought you might be interested in this issue, so I've added you as a watcher. You are welcome to peer review this if you wish.

          Show
          Michael de Raadt added a comment - Hi, Nadav. I thought you might be interested in this issue, so I've added you as a watcher. You are welcome to peer review this if you wish.
          Hide
          Nadav Kavalerchik added a comment -

          Thanks Michael

          Show
          Nadav Kavalerchik added a comment - Thanks Michael
          Hide
          Nadav Kavalerchik added a comment -

          First thing I notice is that the open/close "arrows" should be inverted. (see attached image. green arrows are correctly aligned)

          User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.22 (KHTML, like Gecko) Chrome/25.0.1364.172 Safari/537.22

          Show
          Nadav Kavalerchik added a comment - First thing I notice is that the open/close "arrows" should be inverted. (see attached image. green arrows are correctly aligned) User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.22 (KHTML, like Gecko) Chrome/25.0.1364.172 Safari/537.22
          Hide
          Frédéric Massart added a comment -

          Hi Nadav, can you try with the attached patch? Thanks!

          Show
          Frédéric Massart added a comment - Hi Nadav, can you try with the attached patch? Thanks!
          Hide
          Jason Fowler added a comment -

          [Y] Syntax
          [-] Output
          [Y] Whitespace
          [-] Language
          [-] Databases
          [Y] Testing
          [-] Security
          [-] Documentation
          [Y] Git
          [Y] Sanity check

          Nice work Fred.

          Show
          Jason Fowler added a comment - [Y] Syntax [-] Output [Y] Whitespace [-] Language [-] Databases [Y] Testing [-] Security [-] Documentation [Y] Git [Y] Sanity check Nice work Fred.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Nadav Kavalerchik added a comment -

          Oups ,sorry. I was using moodle.org/master and not the test.
          (So we might need to move the screen capture into an new MDL)

          Ok. just now, applied the patch and it seems broken. (or... I do not understand what I suppose to see)
          Can you please be more clear on the test instruction or post a screen capture of what I suppose to see?

          Show
          Nadav Kavalerchik added a comment - Oups ,sorry. I was using moodle.org/master and not the test. (So we might need to move the screen capture into an new MDL) Ok. just now, applied the patch and it seems broken. (or... I do not understand what I suppose to see) Can you please be more clear on the test instruction or post a screen capture of what I suppose to see?
          Hide
          Damyon Wiese added a comment -

          Hi Nadav - it is working for me so I'll integrate the patch - it's possible you need to purge your caches before you test this.

          Show
          Damyon Wiese added a comment - Hi Nadav - it is working for me so I'll integrate the patch - it's possible you need to purge your caches before you test this.
          Hide
          Damyon Wiese added a comment -

          Thanks Fred,

          Works for me! Integrated to master.

          Show
          Damyon Wiese added a comment - Thanks Fred, Works for me! Integrated to master.
          Hide
          Nadav Kavalerchik added a comment -

          Me bad
          After "Purge all caches" it looks great in RTL!

          Show
          Nadav Kavalerchik added a comment - Me bad After "Purge all caches" it looks great in RTL!
          Hide
          Damyon Wiese added a comment -

          Thanks for confirming Nadav.

          Show
          Damyon Wiese added a comment - Thanks for confirming Nadav.
          Hide
          David Monllaó added a comment -

          It passes. Not directly related with this issue, but I've noticed the labels are aligned to the left, I've opened a related issue MDL-38566

          Show
          David Monllaó added a comment - It passes. Not directly related with this issue, but I've noticed the labels are aligned to the left, I've opened a related issue MDL-38566
          Hide
          Damyon Wiese added a comment -

          This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

          Thanks for your contributions!

          Show
          Damyon Wiese added a comment - This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads). Thanks for your contributions!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: