Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      Note: As always, recommend having the developer toolset open

      With developer mode disabled and enabled:

        • Confirm that the URL for all moodle JS loaded through yui_combo.php have -min.js on the end of the filename
      • Restrict the Network tab to JavaScript
      • Log out and navigate to the Login page
        • Confirm that moodle-core-tooltip loaded successfully in your browser
        • Confirm that a minified version was loaded if debugging was not enabled
        • Confirm that a non-minified version was loaded if debugging was enabled
        • Confirm that clicking on the [?] icon brings up the help popup correctly
      Show
      Note: As always, recommend having the developer toolset open With developer mode disabled and enabled: Confirm that the URL for all moodle JS loaded through yui_combo.php have -min.js on the end of the filename Restrict the Network tab to JavaScript Log out and navigate to the Login page Confirm that moodle-core-tooltip loaded successfully in your browser Confirm that a minified version was loaded if debugging was not enabled Confirm that a non-minified version was loaded if debugging was enabled Confirm that clicking on the [?] icon brings up the help popup correctly
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:

      Description

      There is currently a bug in shifter which has meant that the recursive option doesn't quite work as it should. I have a patch in to fix it and I'm hoping it gets addressed soon.

      As a result though, moodle-core-tooltip was integrated with a different build (Sam modified my commit to change whitespace and the recursive build he ran modified moodle/../)

      In the mean time:

      npm install shifter@0.2.15 -g
      

      And here's a rebuild of moodle-core-tooltip with correct whitespace etc.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13