Details

    • Testing Instructions:
      Hide

      Note: As always, recommend having the developer toolset open

      With developer mode disabled and enabled:

        • Confirm that the URL for all moodle JS loaded through yui_combo.php have -min.js on the end of the filename
      • Restrict the Network tab to JavaScript
      • Log out and navigate to the Login page
        • Confirm that moodle-core-tooltip loaded successfully in your browser
        • Confirm that a minified version was loaded if debugging was not enabled
        • Confirm that a non-minified version was loaded if debugging was enabled
        • Confirm that clicking on the [?] icon brings up the help popup correctly
      Show
      Note: As always, recommend having the developer toolset open With developer mode disabled and enabled: Confirm that the URL for all moodle JS loaded through yui_combo.php have -min.js on the end of the filename Restrict the Network tab to JavaScript Log out and navigate to the Login page Confirm that moodle-core-tooltip loaded successfully in your browser Confirm that a minified version was loaded if debugging was not enabled Confirm that a non-minified version was loaded if debugging was enabled Confirm that clicking on the [?] icon brings up the help popup correctly
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
    • Rank:
      48437

      Description

      There is currently a bug in shifter which has meant that the recursive option doesn't quite work as it should. I have a patch in to fix it and I'm hoping it gets addressed soon.

      As a result though, moodle-core-tooltip was integrated with a different build (Sam modified my commit to change whitespace and the recursive build he ran modified moodle/../)

      In the mean time:

      npm install shifter@0.2.15 -g
      

      And here's a rebuild of moodle-core-tooltip with correct whitespace etc.

        Activity

        Hide
        Andrew Nicols added a comment -

        Submitting straight to integration as there's no actual code change.

        Show
        Andrew Nicols added a comment - Submitting straight to integration as there's no actual code change.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (and used to verify my local shifter leads to same results, super!)

        Will be working on MDLSITE-2155 tomorrow.

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (and used to verify my local shifter leads to same results, super!) Will be working on MDLSITE-2155 tomorrow.
        Hide
        Adrian Greeve added a comment -

        Tested on the master integration branch.
        Test passed.

        Show
        Adrian Greeve added a comment - Tested on the master integration branch. Test passed.
        Hide
        Damyon Wiese added a comment -

        This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

        Thanks for your contributions!

        Show
        Damyon Wiese added a comment - This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads). Thanks for your contributions!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: