Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38480

Messy usage of language strings in block course overview

    XMLWordPrintable

    Details

    • Database:
      Any
    • Testing Instructions:
      Hide

      1) fresh Moodle 2.4 install, latest weekly build.
      2) create a course and add a a.lesson module and b.SCORM activity. Set them to be visible in the course overview block
      3) make sure you are enrolled in the course where you created the above activities
      4) check in My home the block course overview shows the string [modulename/mod_xxx]
      5) now apply patches
      6) purge all caches
      7) check in My home page block course overview now shows [activityoverview/mod_xxx] for both SCORM and Lesson modules
      8) repeat steps 1-7 for moodle master branch

      Show
      1) fresh Moodle 2.4 install, latest weekly build. 2) create a course and add a a.lesson module and b.SCORM activity. Set them to be visible in the course overview block 3) make sure you are enrolled in the course where you created the above activities 4) check in My home the block course overview shows the string [modulename/mod_xxx] 5) now apply patches 6) purge all caches 7) check in My home page block course overview now shows [activityoverview/mod_xxx] for both SCORM and Lesson modules 8) repeat steps 1-7 for moodle master branch
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:

      Description

      In block course overview, activity modules requiring attention uses different strings. For example:

      mod_assign: [activityoverview/assign]
      mod_quiz: [activityoverview/quiz]
      mod_forum: [activityoverview/forum]
      mod_lesson, mod_scorm: [activityoverview/block_course_overview]

      Moreover, the English language strings for [activityoverview/block_course_overview] is as follows:

      "You have {$a}s that need attention"

      which yields, for example:

      You have Lesson

      {modulename/lesson}

      s that need attention

      {activityoverview/block_course_overview}

      The use of "s" and "modulename" make difficult to appropriately translate the strings in other languages, where a plural form may be needed.

      Possible solutions:
      1) when passing parameter to [activityoverview/block_course_overview] use the string [modulenameplural/*****]" instead of [modulename/*****]
      2) add appropriate language strings in [activityoverview/****] in modules where they are missing, such as mod_lesson and mod_scorm.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              andreabix Andrea Bicciolo
              Reporter:
              andreabix Andrea Bicciolo
              Peer reviewer:
              Helen Foster
              Integrator:
              Damyon Wiese
              Tester:
              Frédéric Massart
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, cameron1729, David Mudrák (@mudrd8mz), Helen Foster, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Damyon Wiese, Dan Marsden, Matteo Scaramuccia, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/May/13