Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38489

SCORM player re-directs user to course page on form submit

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.6
    • 2.4.2
    • SCORM
    • MOODLE_24_STABLE
    • MOODLE_26_STABLE
    • master_MDL-38489
    • Hide

      To reproduce the issue:
      1. Create a course and edit course settings:
      2. Set 'Format' to 'Topics format'
      3. Set 'Course layout' to 'Show one section per page'
      4. Add a SCORM activity to 'Topic 1' and edit settings:
      5. Set 'Display package' to 'New window'
      6. Save and return to course, navigate to the created SCORM activity in 'Topic 1'
      7. Launch the SCORM activity, a new window with the SCORM content should pop up.
      8. The SCORM launch page is redirected back to course overview after SCORM content is launched; Correct behavior would be to redirect to the topic view which contains the SCORM activity.

      With patch applied, it should look like (sectionid has been added):
      http://moodleroot/course/view.php?id=2&sectionid=4&sesskey=xxxxxxxxxx

      Show
      To reproduce the issue: 1. Create a course and edit course settings: 2. Set 'Format' to 'Topics format' 3. Set 'Course layout' to 'Show one section per page' 4. Add a SCORM activity to 'Topic 1' and edit settings: 5. Set 'Display package' to 'New window' 6. Save and return to course, navigate to the created SCORM activity in 'Topic 1' 7. Launch the SCORM activity, a new window with the SCORM content should pop up. 8. The SCORM launch page is redirected back to course overview after SCORM content is launched; Correct behavior would be to redirect to the topic view which contains the SCORM activity. With patch applied, it should look like (sectionid has been added): http://moodleroot/course/view.php?id=2&sectionid=4&sesskey=xxxxxxxxxx

      When a SCORM package is set to open in a pop-up window, it leads the user to a page with an 'Open' button. This button uses Javascript to open the SCORM package in a pop-up window, then returns to the course page.

      In mod/scorm/view.js:

      scormform.onsubmit = function()

      {window.open('', 'Popup', poptions); this.target='Popup'; parent.window.location = course_url;}

      ;

      This is great, unless you're in a course format (e.g. Topics) with 'show one section per page' enabled. When this happens, you're taken to the course's overview page rather than the page for the topic you were just looking at.

      In these circumstances, especially on a course with a lot of stuff in each topic, it would be nice to return to the page for the topic you had open rather than the overview page for the course.

      For example, instead of returning to:

      my-moodle.tld/course/view.php?id=1234

      We should return to:

      my-moodle.tld/course/view.php?id=1234&section=5

        1. MDL-38489.patch
          2 kB
          Vinnie Monaco
        2. MDL-38489v2.patch
          3 kB
          Vinnie Monaco

            danmarsden Dan Marsden
            lexx_koto Alex Walker
            Ankit Agarwal Ankit Agarwal
            Sam Hemelryk Sam Hemelryk
            David Monllaó David Monllaó
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.