Details

    • Testing Instructions:
      Hide

      I'd advise having your browsers inspector up for these tests in case of JS issues.

      • Open a course
      • Turn editing on
      • Turn off the activity chooser
      • Click the help icon next to the 'Add a resource...' dropdown
      • Confirm:
        • that the Network activity tab in your browser inspector showed a page fetch to help_ajax.php
        • that the correct help text is displayed
        • that the correct help title is displayed
      • Navigate to Site administration -> Users -> Permissions -> Define roles
      • Click on the help on the 'Role' column
      • Confirm:
        • that the Network activity tab in your browser inspector showed a page fetch to help_ajax.php
        • that the correct help text is displayed
        • that the correct help title is displayed
        • that the 'More help' link is shown correctly in the bottom right-hand corner of the popup
      • Disable JavaScript in your browser
      • Refresh the page
      • Click on the help icon again
        • Confirm that the help opens correctly (not a JS popup) and that the URL contains help.php
      Show
      I'd advise having your browsers inspector up for these tests in case of JS issues. Open a course Turn editing on Turn off the activity chooser Click the help icon next to the 'Add a resource...' dropdown Confirm: that the Network activity tab in your browser inspector showed a page fetch to help_ajax.php that the correct help text is displayed that the correct help title is displayed Navigate to Site administration -> Users -> Permissions -> Define roles Click on the help on the 'Role' column Confirm: that the Network activity tab in your browser inspector showed a page fetch to help_ajax.php that the correct help text is displayed that the correct help title is displayed that the 'More help' link is shown correctly in the bottom right-hand corner of the popup Disable JavaScript in your browser Refresh the page Click on the help icon again Confirm that the help opens correctly (not a JS popup) and that the URL contains help.php
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
    • Rank:
      48503

      Description

      As discussed in MDL-38287, setting ajax = 1 does not define AJAX_SCRIPT and we need to ensure that this is set so that we use the correct renderers.

      Whilst fixing this, we should also handle missing header strings more gracefully. At present if a help string is missing it's header, then the popup has an unhappy moment.

        Issue Links

          Activity

          Hide
          Andrew Nicols added a comment -

          This is a master only change. The help system was rewritten for 2.5.

          Show
          Andrew Nicols added a comment - This is a master only change. The help system was rewritten for 2.5.
          Hide
          Petr Škoda added a comment - - edited

          Looks ok, +1.

          The only problem might be the ajax file name, we use "_" usually...

          Show
          Petr Škoda added a comment - - edited Looks ok, +1. The only problem might be the ajax file name, we use "_" usually...
          Hide
          Andrew Nicols added a comment -

          Updated as per Petr's request.

          This is a Moodle 2.5 only fix.

          Show
          Andrew Nicols added a comment - Updated as per Petr's request. This is a Moodle 2.5 only fix.
          Hide
          Aparup Banerjee added a comment -

          Thanks, this has been integrated into master.

          ps: who would've thought a call to http://apu.moodle.local/i/help.php?component=moodle&identifier=category&lang=en to display some text would take 108 https requests! :-p

          Show
          Aparup Banerjee added a comment - Thanks, this has been integrated into master. ps: who would've thought a call to http://apu.moodle.local/i/help.php?component=moodle&identifier=category&lang=en to display some text would take 108 https requests! :-p
          Hide
          Andrew Davis added a comment -

          Passing although I noticed some things that may warrant new MDLs.

          1) It appears to request the help from the server every time you click the resource/activity help icon even though they are all the same.

          2) The non-ajax help links steal the current window. Could they have target="_blank" on them?

          Show
          Andrew Davis added a comment - Passing although I noticed some things that may warrant new MDLs. 1) It appears to request the help from the server every time you click the resource/activity help icon even though they are all the same. 2) The non-ajax help links steal the current window. Could they have target="_blank" on them?
          Hide
          Andrew Nicols added a comment -

          Hi Andrew,

          1) You have DEBUG_DEVELOPER set, then the tooltip does not use it's cache. This is deliberate to aid language string developers get the right fit and feel without having to continually reload the page to clear the cache.
          2) I agree, this would be an improvement. This issue hasn't changed that functionality. I've raised MDL-39069 to implement this change.

          Cheers,

          Andrew

          Show
          Andrew Nicols added a comment - Hi Andrew, 1) You have DEBUG_DEVELOPER set, then the tooltip does not use it's cache. This is deliberate to aid language string developers get the right fit and feel without having to continually reload the page to clear the cache. 2) I agree, this would be an improvement. This issue hasn't changed that functionality. I've raised MDL-39069 to implement this change. Cheers, Andrew
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Your awesome contributions are now part of Moodle, your fav LMS out there.

          Closing this as fixed.

          Many thanks for all the hard work, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Your awesome contributions are now part of Moodle, your fav LMS out there. Closing this as fixed. Many thanks for all the hard work, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: