XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      I'd advise having your browsers inspector up for these tests in case of JS issues.

      • Open a course
      • Turn editing on
      • Turn off the activity chooser
      • Click the help icon next to the 'Add a resource...' dropdown
      • Confirm:
        • that the Network activity tab in your browser inspector showed a page fetch to help_ajax.php
        • that the correct help text is displayed
        • that the correct help title is displayed
      • Navigate to Site administration -> Users -> Permissions -> Define roles
      • Click on the help on the 'Role' column
      • Confirm:
        • that the Network activity tab in your browser inspector showed a page fetch to help_ajax.php
        • that the correct help text is displayed
        • that the correct help title is displayed
        • that the 'More help' link is shown correctly in the bottom right-hand corner of the popup
      • Disable JavaScript in your browser
      • Refresh the page
      • Click on the help icon again
        • Confirm that the help opens correctly (not a JS popup) and that the URL contains help.php
      Show
      I'd advise having your browsers inspector up for these tests in case of JS issues. Open a course Turn editing on Turn off the activity chooser Click the help icon next to the 'Add a resource...' dropdown Confirm: that the Network activity tab in your browser inspector showed a page fetch to help_ajax.php that the correct help text is displayed that the correct help title is displayed Navigate to Site administration -> Users -> Permissions -> Define roles Click on the help on the 'Role' column Confirm: that the Network activity tab in your browser inspector showed a page fetch to help_ajax.php that the correct help text is displayed that the correct help title is displayed that the 'More help' link is shown correctly in the bottom right-hand corner of the popup Disable JavaScript in your browser Refresh the page Click on the help icon again Confirm that the help opens correctly (not a JS popup) and that the URL contains help.php
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:

      Description

      As discussed in MDL-38287, setting ajax = 1 does not define AJAX_SCRIPT and we need to ensure that this is set so that we use the correct renderers.

      Whilst fixing this, we should also handle missing header strings more gracefully. At present if a help string is missing it's header, then the popup has an unhappy moment.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Petr Skoda
              Integrator:
              Aparup Banerjee
              Tester:
              Andrew Davis
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/13