Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38515

Undefined offset in yui_combo.php

    Details

    • Testing Instructions:
      Hide

      With this issue it's really worth testing without the patch to understand the issue.

      Dependency fix check

      • Open the JS console
      • Open any page with a TinyMCE editor (which accepts files)
        • Confirm that the editor works
        • Confirm that no JS errors were shown

      Error notices

      • In the JS console type:

        YUI().use('moodle-core_filepicker');
        

        • Confirm that an error was shown in your console (Theoretically, not all browsers actually support this though I'm not aware of any which don't)
        • Confirm that a file was loaded but had an error message as it's content
      Show
      With this issue it's really worth testing without the patch to understand the issue. Dependency fix check Open the JS console Open any page with a TinyMCE editor (which accepts files) Confirm that the editor works Confirm that no JS errors were shown Error notices In the JS console type: YUI().use('moodle-core_filepicker'); Confirm that an error was shown in your console (Theoretically, not all browsers actually support this though I'm not aware of any which don't) Confirm that a file was loaded but had an error message as it's content
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:

      Description

      David Mudrak pointed out last night that he is now seeing errors such as:

      [Sat Mar 16 19:57:53 2013] [error] [client 192.168.1.19] PHP Notice:  Undefined offset: 0 in /Users/nicols/git/software/moodle/theme/yui_combo.php on line 99, referer: http://tangerine.local/moodle/course/edit.php?id=9
      

      in his error log for yui_combo.php.

      Looking into this, it's caused by an incorrect dependency on moodle-core_filepicker from within core_filepicker.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    13/May/13