Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38515

Undefined offset in yui_combo.php

    XMLWordPrintable

Details

    • MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • MOODLE_23_STABLE, MOODLE_24_STABLE
    • Hide

      With this issue it's really worth testing without the patch to understand the issue.

      Dependency fix check

      • Open the JS console
      • Open any page with a TinyMCE editor (which accepts files)
        • Confirm that the editor works
        • Confirm that no JS errors were shown

      Error notices

      • In the JS console type: 

        YUI().use('moodle-core_filepicker');

        • Confirm that an error was shown in your console (Theoretically, not all browsers actually support this though I'm not aware of any which don't)
        • Confirm that a file was loaded but had an error message as it's content
      Show
      With this issue it's really worth testing without the patch to understand the issue. Dependency fix check Open the JS console Open any page with a TinyMCE editor (which accepts files) Confirm that the editor works Confirm that no JS errors were shown Error notices In the JS console type: YUI().use('moodle-core_filepicker'); Confirm that an error was shown in your console (Theoretically, not all browsers actually support this though I'm not aware of any which don't) Confirm that a file was loaded but had an error message as it's content

    Description

      David Mudrak pointed out last night that he is now seeing errors such as:

      [Sat Mar 16 19:57:53 2013] [error] [client 192.168.1.19] PHP Notice:  Undefined offset: 0 in /Users/nicols/git/software/moodle/theme/yui_combo.php on line 99, referer: http://tangerine.local/moodle/course/edit.php?id=9

      in his error log for yui_combo.php.

      Looking into this, it's caused by an incorrect dependency on moodle-core_filepicker from within core_filepicker.

      Attachments

        Issue Links

          Discovered while testing

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-38561 Convert filepickers and filemanagers to YUI modules

          • Major - Major loss of function, incorrect output
          • Closed
          has been marked as being related by

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-38562 Reimplement warnings of incorrect YUI module inclusion

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is blocked by

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-38391 Collect meta-data for YUI_config

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Activity

            People

              dobedobedoh Andrew Lyons
              dobedobedoh Andrew Lyons
              Petr Skoda Petr Skoda
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Marina Glancy Marina Glancy
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                13/May/13