Details

    • Testing Instructions:
      Hide

      Generic Notes

      These testing instructions should be carried out twice (once with jsrev = -1, once without) to confirm that the correct versions of JS are used and work as expected.

      Tip: Open your browser's developer toolkit, open the 'Network' activity tab, and restrict to 'Scripts'.

      Note: You may find that the script you're looking for is included with a number of other scripts - this is because of our combo loading.
      You can turn off comboloading to make it easier to check the relevant script by setting

      $CFG->yuicomboloading = false;

      , but you should check that functionality works with combo loading enabled.

      To test the minified code:

      Required settings:

      // Ensure you aren't overriding $CFG->jsrev
      $CFG->debug = 0;
      

      Notes

      Check that the minified version of this module is loaded.
      It will have -min.js in the filename but please ensure content is also be minified

      and to test the non-minified code:

      Required settings:

      $CFG->jsrev = -1;
      $CFG->debug = (E_ALL | E_STRICT);
      

      Notes

      Check that the non-minified version of this module is loaded.
      It will have -debug.js in the filename and the file content should not be minified.

      Module-specific test instructions

      • Open any page in Moodle which uses the navigation block
        • Confirm that you can still expand/collapse nodes
        • Confirm that when you expand a Course node, there is a call to /lib/ajax/getnavbranch.php and the branch loads any relevant content

      Testing keyboard use

      • Use the tab key to get to the navigation
        • Confirm that left/right open and close branches
        • Confirm that enter/space toggle opening/closing of branches
      • Open down to a course and tab to the Participants list
        • Confirm that space always toggles a node
        • Confirm that the 'enter' key toggles the 'Current course' node
        • Confirm that the 'enter' key selects the 'Participants' node
      Show
      Generic Notes These testing instructions should be carried out twice (once with jsrev = -1, once without) to confirm that the correct versions of JS are used and work as expected. Tip : Open your browser's developer toolkit, open the 'Network' activity tab, and restrict to 'Scripts'. Note : You may find that the script you're looking for is included with a number of other scripts - this is because of our combo loading. You can turn off comboloading to make it easier to check the relevant script by setting $CFG->yuicomboloading = false ; , but you should check that functionality works with combo loading enabled. To test the minified code: Required settings: // Ensure you aren't overriding $CFG->jsrev $CFG->debug = 0; Notes Check that the minified version of this module is loaded. It will have -min.js in the filename but please ensure content is also be minified and to test the non-minified code: Required settings: $CFG->jsrev = -1; $CFG->debug = (E_ALL | E_STRICT); Notes Check that the non-minified version of this module is loaded. It will have -debug.js in the filename and the file content should not be minified. Module-specific test instructions Open any page in Moodle which uses the navigation block Confirm that you can still expand/collapse nodes Confirm that when you expand a Course node, there is a call to /lib/ajax/getnavbranch.php and the branch loads any relevant content Testing keyboard use Use the tab key to get to the navigation Confirm that left/right open and close branches Confirm that enter/space toggle opening/closing of branches Open down to a course and tab to the Participants list Confirm that space always toggles a node Confirm that the 'enter' key toggles the 'Current course' node Confirm that the 'enter' key selects the 'Participants' node
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
    • Rank:
      48513

      Description

      Migrate moodle-block_navigation-navigation to use Shifter

      This is one of the larger modules that we have and it's loaded on most pages in Moodle.

        Issue Links

          Activity

          Hide
          Damyon Wiese added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          Thanks!

          Show
          Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
          Hide
          Andrew Nicols added a comment -

          Pushed an update to fix most of the lint issues.

          The only issues that I haven't fixed are with equality comparison for branch/node type as I'm not 100% certain that the branch/type of node is an integer because the attribute isn't documented well.

          Show
          Andrew Nicols added a comment - Pushed an update to fix most of the lint issues. The only issues that I haven't fixed are with equality comparison for branch/node type as I'm not 100% certain that the branch/type of node is an integer because the attribute isn't documented well.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          And passing. I've tried every combination of:

          • $CFG->jsrev (-1/unset)
          • $CFG->debug (0/E_ALL | E_STRICT)

          Both with $CFG->yuicomboloading enabled and disabled and everything looks ok.

          Tested:

          • Navigation block, collapse & expand working.
          • Expanding courses / sections perform ajax calls and returns proper data.

          Finally, this module's verification with jshint is showing 9 warnings. That does not stop this to land.

          blocks/navigation/yui/src/navigation/js/navigation.js: line 346, col 52, Expected '===' and instead saw '=='.
          blocks/navigation/yui/src/navigation/js/navigation.js: line 471, col 53, Expected '===' and instead saw '=='.
          blocks/navigation/yui/src/navigation/js/navigation.js: line 477, col 39, Expected '===' and instead saw '=='.
          blocks/navigation/yui/src/navigation/js/navigation.js: line 477, col 80, Expected '===' and instead saw '=='.
          blocks/navigation/yui/src/navigation/js/navigation.js: line 477, col 121, Expected '===' and instead saw '=='.
          blocks/navigation/yui/src/navigation/js/navigation.js: line 503, col 38, Expected '===' and instead saw '=='.
          blocks/navigation/yui/src/navigation/js/navigation.js: line 510, col 37, Expected '===' and instead saw '=='.
          blocks/navigation/yui/src/navigation/js/navigation.js: line 510, col 80, Expected '===' and instead saw '=='.
          blocks/navigation/yui/src/navigation/js/navigation.js: line 523, col 32, Expected '===' and instead saw '=='.
          

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - And passing. I've tried every combination of: $CFG->jsrev (-1/unset) $CFG->debug (0/E_ALL | E_STRICT) Both with $CFG->yuicomboloading enabled and disabled and everything looks ok. Tested: Navigation block, collapse & expand working. Expanding courses / sections perform ajax calls and returns proper data. Finally, this module's verification with jshint is showing 9 warnings. That does not stop this to land. blocks/navigation/yui/src/navigation/js/navigation.js: line 346, col 52, Expected '===' and instead saw '=='. blocks/navigation/yui/src/navigation/js/navigation.js: line 471, col 53, Expected '===' and instead saw '=='. blocks/navigation/yui/src/navigation/js/navigation.js: line 477, col 39, Expected '===' and instead saw '=='. blocks/navigation/yui/src/navigation/js/navigation.js: line 477, col 80, Expected '===' and instead saw '=='. blocks/navigation/yui/src/navigation/js/navigation.js: line 477, col 121, Expected '===' and instead saw '=='. blocks/navigation/yui/src/navigation/js/navigation.js: line 503, col 38, Expected '===' and instead saw '=='. blocks/navigation/yui/src/navigation/js/navigation.js: line 510, col 37, Expected '===' and instead saw '=='. blocks/navigation/yui/src/navigation/js/navigation.js: line 510, col 80, Expected '===' and instead saw '=='. blocks/navigation/yui/src/navigation/js/navigation.js: line 523, col 32, Expected '===' and instead saw '=='. Ciao
          Hide
          Damyon Wiese added a comment -

          Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

          Show
          Damyon Wiese added a comment - Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: