Details

    • Testing Instructions:
      Hide

      Generic Notes

      These testing instructions should be carried out twice (once with jsrev = -1, once without) to confirm that the correct versions of JS are used and work as expected.

      Tip: Open your browser's developer toolkit, open the 'Network' activity tab, and restrict to 'Scripts'.

      Note: You may find that the script you're looking for is included with a number of other scripts - this is because of our combo loading.
      You can turn off comboloading to make it easier to check the relevant script by setting

      $CFG->yuicomboloading = false;

      , but you should check that functionality works with combo loading enabled.

      To test the minified code:

      Required settings:

      $CFG->jsrev = -1;
      $CFG->debug = (E_ALL | E_STRICT);
      

      Notes

      Check that the minified version of this module is loaded.
      It will have -min.js in the filename but please ensure content is also be minified

      and to test the non-minified code:

      Required settings:

      $CFG->jsrev = -1;
      $CFG->debug = 0;
      

      Notes

      Check that the non-minified version of this module is loaded.
      It will have -debug.js in the filename and the file content should not be minified.

      Module-specific test instructions

      • Open a page with blocks (I used the course page and front page)
      • Enable editing
      • Try and move a block
        • Confirm that the block drag/drop works
      Show
      Generic Notes These testing instructions should be carried out twice (once with jsrev = -1, once without) to confirm that the correct versions of JS are used and work as expected. Tip : Open your browser's developer toolkit, open the 'Network' activity tab, and restrict to 'Scripts'. Note : You may find that the script you're looking for is included with a number of other scripts - this is because of our combo loading. You can turn off comboloading to make it easier to check the relevant script by setting $CFG->yuicomboloading = false ; , but you should check that functionality works with combo loading enabled. To test the minified code: Required settings: $CFG->jsrev = -1; $CFG->debug = (E_ALL | E_STRICT); Notes Check that the minified version of this module is loaded. It will have -min.js in the filename but please ensure content is also be minified and to test the non-minified code: Required settings: $CFG->jsrev = -1; $CFG->debug = 0; Notes Check that the non-minified version of this module is loaded. It will have -debug.js in the filename and the file content should not be minified. Module-specific test instructions Open a page with blocks (I used the course page and front page) Enable editing Try and move a block Confirm that the block drag/drop works
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
    • Rank:
      48514

      Description

      Migrate moodle-core-blocks to use Shifter

        Activity

        Hide
        Damyon Wiese added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        Thanks!

        Show
        Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        And passing. I've tried every combination of:

        • $CFG->jsrev (-1/unset)
        • $CFG->debug (0/E_ALL | E_STRICT)

        Both with $CFG->yuicomboloading enabled and disabled and everything looks ok:

        • Drag and drop blocks.

        Finally, this module's verification with jshint is showing 3 warnings. Again, don't stop this to land.

        lib/yui/src/blocks/js/blocks.js: line 48, col 36, Expected '!==' and instead saw '!='.
        lib/yui/src/blocks/js/blocks.js: line 184, col 61, Expected '===' and instead saw '=='.
        lib/yui/src/blocks/js/blocks.js: line 75, col 20, 'tar' is defined but never used.
        

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - And passing. I've tried every combination of: $CFG->jsrev (-1/unset) $CFG->debug (0/E_ALL | E_STRICT) Both with $CFG->yuicomboloading enabled and disabled and everything looks ok: Drag and drop blocks. Finally, this module's verification with jshint is showing 3 warnings. Again, don't stop this to land. lib/yui/src/blocks/js/blocks.js: line 48, col 36, Expected '!==' and instead saw '!='. lib/yui/src/blocks/js/blocks.js: line 184, col 61, Expected '===' and instead saw '=='. lib/yui/src/blocks/js/blocks.js: line 75, col 20, 'tar' is defined but never used. Ciao
        Hide
        Damyon Wiese added a comment -

        Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

        Show
        Damyon Wiese added a comment - Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: