Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38285 Migrate moodle- YUI modules to use shifter
  3. MDL-38518

Migrate moodle-core-chooserdialogue to use Shifter

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Duplicate
    • Affects Version/s: 2.5
    • Fix Version/s: None
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      Generic Notes

      These testing instructions should be carried out twice (once with jsrev = -1, once without) to confirm that the correct versions of JS are used and work as expected.

      Tip: Open your browser's developer toolkit, open the 'Network' activity tab, and restrict to 'Scripts'.

      Note: You may find that the script you're looking for is included with a number of other scripts - this is because of our combo loading.
      You can turn off comboloading to make it easier to check the relevant script by setting

      $CFG->yuicomboloading = false;

      , but you should check that functionality works with combo loading enabled.

      To test the minified code:

      Required settings:

      $CFG->jsrev = -1;
      $CFG->debug = (E_ALL | E_STRICT);
      

      Notes

      Check that the minified version of this module is loaded.
      It will have -min.js in the filename but please ensure content is also be minified

      and to test the non-minified code:

      Required settings:

      $CFG->jsrev = -1;
      $CFG->debug = 0;
      

      Notes

      Check that the non-minified version of this module is loaded.
      It will have -debug.js in the filename and the file content should not be minified.

      Module-specific test instructions

      • Open a course
      • Turn editing on
        • Confirm that the 'Add an activity or resource' text is a link
      • Open the activity chooser
        • Confirm that the activity chooser opens correctly and without error
        • Confirm that you can move it around the screen (drag/drop)
        • Confirm that hitting escape closes it
        • Confirm that clicking the [x] closes it
        • Confirm that you can select an option and be taken to the relevant mod_edit form
      Show
      Generic Notes These testing instructions should be carried out twice (once with jsrev = -1, once without) to confirm that the correct versions of JS are used and work as expected. Tip : Open your browser's developer toolkit, open the 'Network' activity tab, and restrict to 'Scripts'. Note : You may find that the script you're looking for is included with a number of other scripts - this is because of our combo loading. You can turn off comboloading to make it easier to check the relevant script by setting $CFG->yuicomboloading = false; , but you should check that functionality works with combo loading enabled. To test the minified code: Required settings: $CFG->jsrev = -1; $CFG->debug = (E_ALL | E_STRICT); Notes Check that the minified version of this module is loaded. It will have -min.js in the filename but please ensure content is also be minified and to test the non-minified code: Required settings: $CFG->jsrev = -1; $CFG->debug = 0; Notes Check that the non-minified version of this module is loaded. It will have -debug.js in the filename and the file content should not be minified. Module-specific test instructions Open a course Turn editing on Confirm that the 'Add an activity or resource' text is a link Open the activity chooser Confirm that the activity chooser opens correctly and without error Confirm that you can move it around the screen (drag/drop) Confirm that hitting escape closes it Confirm that clicking the [x] closes it Confirm that you can select an option and be taken to the relevant mod_edit form
    • Affected Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:

      Description

      Migrate moodle-core-chooserdialogue to use Shifter

        Attachments

          Activity

            People

            Assignee:
            dobedobedoh Andrew Nicols
            Reporter:
            dobedobedoh Andrew Nicols
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: