Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37779 unit test fixing META
  3. MDL-38524

hardcoded behat version in composer blocks phpunit upgrades

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Delete composer.lock and vendor/ from $CFG->dirroot if they exist
      2. Run the composer installer (http://docs.moodle.org/dev/Acceptance_testing#Installation)
      3. You SHOULD NOT receive any dependecies conflict error
      4. Open composer.lock and check the installed versions, the "version" attribute is below the "name" attribute we are looking for:
        • Search "name": "phpunit/phpunit", it SHOULD match 3.7.18
        • Search "name": "behat/behat", it SHOULD match 2.4.5
        • Search "name": "symfony/yaml", is SHOULD match 2.2.0
      5. Run the behat test suit (http://docs.moodle.org/dev/Acceptance_testing#Running_tests)
      6. They SHOULD all pass
      7. Run the phpunit suit with vendor/bin/phpunit (http://docs.moodle.org/dev/PHPUnit#Test_execution_via_Composer)
      8. They SHOULD all pass
      Show
      Delete composer.lock and vendor/ from $CFG->dirroot if they exist Run the composer installer ( http://docs.moodle.org/dev/Acceptance_testing#Installation ) You SHOULD NOT receive any dependecies conflict error Open composer.lock and check the installed versions, the "version" attribute is below the "name" attribute we are looking for: Search "name": "phpunit/phpunit" , it SHOULD match 3.7.18 Search "name": "behat/behat" , it SHOULD match 2.4.5 Search "name": "symfony/yaml" , is SHOULD match 2.2.0 Run the behat test suit ( http://docs.moodle.org/dev/Acceptance_testing#Running_tests ) They SHOULD all pass Run the phpunit suit with vendor/bin/phpunit ( http://docs.moodle.org/dev/PHPUnit#Test_execution_via_Composer ) They SHOULD all pass
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-38524_master

      Description

      Do not hardcode any minor versions in composer file in dev versions:

      "moodlehq/behat-extension": "1.0.3"

      if there are problems with minor versions we need to resolve them, hardcoding is possible only in stable branches...

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dmonllao David Monllaó
              Reporter:
              skodak Petr Skoda
              Peer reviewer:
              Petr Skoda
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Ankit Agarwal
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/13