Moodle
  1. Moodle
  2. MDL-38012 META: Simplify moodle forms
  3. MDL-38528

Disable shortforms for calculated question edit dataset form.

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Forms Library, Questions
    • Labels:
      None

      Description

      This form looks way to confusing with shortforms enabled.

      question/type/calculated/datasetitems_form.php

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Tim Hunt added a comment -

            Thanks for finding this. Fix submitted for integration.

            Show
            Tim Hunt added a comment - Thanks for finding this. Fix submitted for integration.
            Hide
            Damyon Wiese added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            Thanks!

            Show
            Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
            Hide
            Pierre Pichet added a comment -

            Many thanks to fix this,I just discover it yesterday and my next message was to ask Tim how to remove it.

            Show
            Pierre Pichet added a comment - Many thanks to fix this,I just discover it yesterday and my next message was to ask Tim how to remove it.
            Hide
            Damyon Wiese added a comment -

            Thanks Tim,

            The change looks good - integrated to master now.

            Show
            Damyon Wiese added a comment - Thanks Tim, The change looks good - integrated to master now.
            Hide
            Ankit Agarwal added a comment - - edited

            A few things I noticed:-

            1. Shouldn't the Answers section not collapsed by default on first page? since it is kind of required to add atleast one answer.
            2. Also the button "add 1 more answer" looks bit strange, and orphan.
            3. Adding one more answer, should add the new answer section uncollapsed imo.
            4. Testing instructions passed as described.

            Thanks

            Show
            Ankit Agarwal added a comment - - edited A few things I noticed:- Shouldn't the Answers section not collapsed by default on first page? since it is kind of required to add atleast one answer. Also the button "add 1 more answer" looks bit strange, and orphan. Adding one more answer, should add the new answer section uncollapsed imo. Testing instructions passed as described. Thanks
            Hide
            Damyon Wiese added a comment -

            Thanks Ankit,

            Agree with 1.
            2 wouldn't look so bad if the sections were expanded
            3 Agree - not sure how easy it is though

            Please raise new issues for these as they look like useful further improvements.

            Show
            Damyon Wiese added a comment - Thanks Ankit, Agree with 1. 2 wouldn't look so bad if the sections were expanded 3 Agree - not sure how easy it is though Please raise new issues for these as they look like useful further improvements.
            Hide
            Ankit Agarwal added a comment -

            Created and linked issue.
            Passing the test
            Thanks

            Show
            Ankit Agarwal added a comment - Created and linked issue. Passing the test Thanks
            Hide
            Damyon Wiese added a comment -

            Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

            Show
            Damyon Wiese added a comment - Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: