Moodle
  1. Moodle
  2. MDL-38532

Fix composer dependencies versions when master branch becomes STABLE

    Details

    • Rank:
      48542

      Description

      As commented in MDL-38524 working with non-fixed behat dependencies can be complicated for maintenance reasons as there are different upstream project requiring different versions of different dependencies and changes can affect tests results. We can use wildcards (the latest version in composer nomenclature, 1.2.* for example) during DEV.

      This change will be tied to changes in moodlehq/behatextension, we can begin with 1.26.* for 2.6 and switch the wildcards to fixed versions in 1.25.lastone for 2.5

        Issue Links

          Activity

          Hide
          Damyon Wiese added a comment -

          Is now a good time to freeze this David?

          Show
          Damyon Wiese added a comment - Is now a good time to freeze this David?
          Hide
          Damyon Wiese added a comment -

          Also we need to decide if we want to remove the change in MDL-38878 for stable branches when we do this (checking for composer updates can be so slow).

          Show
          Damyon Wiese added a comment - Also we need to decide if we want to remove the change in MDL-38878 for stable branches when we do this (checking for composer updates can be so slow).
          Hide
          David Monllaó added a comment -

          It makes sense, thanks I didn't thought of it, I changed the fix version to 2.5 and I will work on it just after 2.5 is released.

          Show
          David Monllaó added a comment - It makes sense, thanks I didn't thought of it, I changed the fix version to 2.5 and I will work on it just after 2.5 is released.
          Hide
          David Monllaó added a comment -

          As commented in https://tracker.moodle.org/browse/MDL-38041#comment-220094 we can use 1.25.x for Moodle 2.5, 1.26.x for Moodle 2.6...

          Show
          David Monllaó added a comment - As commented in https://tracker.moodle.org/browse/MDL-38041#comment-220094 we can use 1.25.x for Moodle 2.5, 1.26.x for Moodle 2.6...
          Hide
          David Monllaó added a comment -

          Adding pull branches, but waiting to send it to review as it should be integrated after the release of 2.5.

          Step added to http://docs.moodle.org/dev/Major_release_process#Post_release

          Show
          David Monllaó added a comment - Adding pull branches, but waiting to send it to review as it should be integrated after the release of 2.5. Step added to http://docs.moodle.org/dev/Major_release_process#Post_release
          Hide
          David Monllaó added a comment -

          I have doubts about removing the testing_update_composer_dependencies() when updating the test site, any feedback about it?

          Show
          David Monllaó added a comment - I have doubts about removing the testing_update_composer_dependencies() when updating the test site, any feedback about it?
          Hide
          David Monllaó added a comment -

          Submitting for integration as talked with Eloy

          Show
          David Monllaó added a comment - Submitting for integration as talked with Eloy
          Hide
          David Monllaó added a comment -

          I'm removing the removal of the composer update, we can also have updates of the 1.25.x branch if new bugs are detected and the easy-to-do installation should manage this changes, also the checking of the dependencies versions is very short comparing to the required time to install the site. The alternative is to add a --skipcomposer option

          Show
          David Monllaó added a comment - I'm removing the removal of the composer update, we can also have updates of the 1.25.x branch if new bugs are detected and the easy-to-do installation should manage this changes, also the checking of the dependencies versions is very short comparing to the required time to install the site. The alternative is to add a --skipcomposer option
          Hide
          Eloy Lafuente (stronk7) added a comment -

          (added an extra commit bumping version)

          Show
          Eloy Lafuente (stronk7) added a comment - (added an extra commit bumping version)
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Passing, components were installed/upgraded ok.

          Side note: After discussing it with David, it seems that the "unique-branch" strategy in the behat repo is not going to be enough and we need branching there too (ideally, like we branch moodle). That way each branch can have its own evolution if needed.

          Show
          Eloy Lafuente (stronk7) added a comment - Passing, components were installed/upgraded ok. Side note: After discussing it with David, it seems that the "unique-branch" strategy in the behat repo is not going to be enough and we need branching there too (ideally, like we branch moodle). That way each branch can have its own evolution if needed.
          Hide
          David Monllaó added a comment -

          Confirmed that composer also gets tags from other branches than master so there will be no problem with this approach

          Show
          David Monllaó added a comment - Confirmed that composer also gets tags from other branches than master so there will be no problem with this approach
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Did you think this day was not going to arrive ever?

          Your patience has been rewarded, yay, sent upstream, thanks!

          Closing...ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Did you think this day was not going to arrive ever? Your patience has been rewarded, yay, sent upstream, thanks! Closing...ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: