Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38543

Links for selecting all/none checkboxes lost from backup/import pages

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Backup, Forms Library
    • Labels:
    • Testing Instructions:
      Hide

      This test requires a site with at least two courses, one with activities/resources.

      1. Log in as admin/teacher
      2. Navigate to one of the courses
      3. Click Import
      4. Select another course with activities/resources
      5. Click continue
      6. Click next on the initial settings page
      7. Verify that the all/none links appear above the course sections
      Show
      This test requires a site with at least two courses, one with activities/resources. Log in as admin/teacher Navigate to one of the courses Click Import Select another course with activities/resources Click continue Click next on the initial settings page Verify that the all/none links appear above the course sections
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-mdl-38543

      Description

      Recent form simplifications have introduced changes to fieldset identifiers which has broken (possibly among other things) the all/none links on backup/import pages. The fieldset identifiers are now modified with a preceeding 'id_' being added to fieldset ids (why?). The JavaScript that attempts to identify of the all/none links should be added relies on the fieldset identifier.

      Replication steps:
      This requires a site with at least two courses, one with activities resources

      1. Log in as admin/teacher
      2. Navigate to one of the courses
      3. Click Import
      4. Select another course with activities/resources
      5. Click continue
      6. Click next on the initial settings page
      7. Check above the course sections

      Expected outcome: You should see all/none links

      Actual outcome: The all/none links are missing

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                salvetore Michael de Raadt
                Reporter:
                salvetore Michael de Raadt
                Peer reviewer:
                Tim Hunt
                Integrator:
                Eloy Lafuente (stronk7)
                Tester:
                Eloy Lafuente (stronk7)
                Participants:
                Component watchers:
                Adrian Greeve, Mihail Geshoski, Peter Dias, Jake Dallimore, Jun Pataleta, Ryan Wyllie
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13