Moodle
  1. Moodle
  2. MDL-38481 META: Add behat tests for course-related actions
  3. MDL-38547

Automate MDLQAs - Group mode icons are set to the correct state when group mode is forced

    Details

    • Rank:
      48562

      Description

      As described in:

      The group mode can be forced at course level and should be extended to all activities.

        Issue Links

          Activity

          Hide
          David Monllaó added a comment -

          Using xpath to get the image as there is no named selector for images when they are not wrapped in a tags

          Show
          David Monllaó added a comment - Using xpath to get the image as there is no named selector for images when they are not wrapped in a tags
          Hide
          Damyon Wiese added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          Thanks!

          Show
          Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks!

          Note I've added 1 extra commit fixing various coding style issues (mainly because this is blocking others). Plz, pay some attention to that, TIA!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks! Note I've added 1 extra commit fixing various coding style issues (mainly because this is blocking others). Plz, pay some attention to that, TIA!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Passed coz all the _cross_browser tests passing here (only against FF, but CI will tell us for others, I hope).

          Show
          Eloy Lafuente (stronk7) added a comment - Passed coz all the _cross_browser tests passing here (only against FF, but CI will tell us for others, I hope).
          Hide
          David Monllaó added a comment -

          Thanks Eloy; about the extra commit, the definition method's phpdoc short description is used by behat to show it to tests writers and it stops at line break so with this last commit the second part of the explanation will never be seen by a test writer.

          We can restore this two short description lines or extend behat framework to include the short description and the first long description paragraph (not all because otherwise we would also show dev. info) I would go with the second option as a long term solution but it would require a bit more time.

          Show
          David Monllaó added a comment - Thanks Eloy; about the extra commit, the definition method's phpdoc short description is used by behat to show it to tests writers and it stops at line break so with this last commit the second part of the explanation will never be seen by a test writer. We can restore this two short description lines or extend behat framework to include the short description and the first long description paragraph (not all because otherwise we would also show dev. info) I would go with the second option as a long term solution but it would require a bit more time.
          Hide
          Dan Poltawski added a comment -

          Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

          line 1289 of \lib\changes.php: call to debugging()
          line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
          line 202 of \lib\now.php: call to moodleform->_is_poor_form()
          line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

          Show
          Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()
          Hide
          Eloy Lafuente (stronk7) added a comment -

          FYI: related MDLQA-1597, MDLQA-1598, MDLQA-1599, MDLQA-1600, MDLQA-1601 have been moved from MDLQA-1 to MDLQA-5249 (bag of behat-converted tests). Thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - FYI: related MDLQA-1597 , MDLQA-1598 , MDLQA-1599 , MDLQA-1600 , MDLQA-1601 have been moved from MDLQA-1 to MDLQA-5249 (bag of behat-converted tests). Thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: