[MDL-38557] Access to the quiz manual grading 'report' should be controlled by mod/quiz:grade, not mod/quiz:viewreports - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
Fixed Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE
Pull from Repository:
git://github.com/timhunt/moodle.git
Pull Main Branch:
~~MDL-38557~~
Pull Main Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-38557
Testing Instructions:
Hide

Ideally, this needs to be tested in both an upgrade an a newly installed site on each branch.

1. You need to create users with 4 possible combinations of with/without mod/quiz:viewreports and mod/quiz:grade. (Perhaps easiest using permission overrides?)

2. Check that mod/quiz:viewreports controls access to the Grades and Responses quiz report

In the navigation.

Which report the 'Attempts: 123' message links to.

Whether you can acutally use the report, once you have gone there in the navigation.
Show
Ideally, this needs to be tested in both an upgrade an a newly installed site on each branch. 1. You need to create users with 4 possible combinations of with/without mod/quiz:viewreports and mod/quiz:grade. (Perhaps easiest using permission overrides?) 2. Check that mod/quiz:viewreports controls access to the Grades and Responses quiz report In the navigation. Which report the 'Attempts: 123' message links to. Whether you can acutally use the report, once you have gone there in the navigation.

I actually thought it worked like that, but it seems I was wrong.

I think it makes more sense to use the mod/quiz:grade capability to control access to this bit of UI, rather than mod/quiz:viewreports.

All we need to do is to change the value in the quiz_reports.capability column.

is a regression caused by

MDL-31983 Include Reports Under Settings block -> Course administration

Participants:: Damyon Wiese, Dan Poltawski, Eloy Lafuente (stronk7), Mary Cooch, Rajesh Taneja, Tim Hunt