Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38565

When a cache store is set to MODE_SESSION it should include the userid in the keys.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.4.3, 2.5
    • Fix Version/s: 2.4.4, 2.5
    • Component/s: Caching
    • Labels:
    • Testing Instructions:
      Hide
      1. Run unit tests.
      2. Run them again - there are lots!
      3. Upgrade a site
      4. Perform a fresh install
      5. Log in as an admin and set up the front page to display all options for all users.
      6. Test the front page as a guest, student, and admin.
      7. Test switching users.
      8. Run performance tests if you can.
      Show
      Run unit tests. Run them again - there are lots! Upgrade a site Perform a fresh install Log in as an admin and set up the front page to display all options for all users. Test the front page as a guest, student, and admin. Test switching users. Run performance tests if you can.
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-38565-m25
    • Pull Master Diff URL:

      Description

      Otherwise a site configured with a shared mem storage for the session cache will have a shared keyspace for all users which is not expected.

      Comments from Sam:
      It should be in the loader
      (10:30:09) samhemelryk@moodle.org: cache_session::parse_key should be doing it, but the code is not there ...

      ... write unit tests to test the stores explicitly for collision across all modes is perhaps the best way

        Attachments

          Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-44006 MongoDB and memcached stores report MODE_SESSION but can't be used

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-38303 MUC: Session cache is not changed when user logs in or out

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

            Activity

              People

              Assignee:
              samhemelryk Sam Hemelryk
              Reporter:
              damyon Damyon Wiese
              Peer reviewer:
              Damyon Wiese
              Integrator:
              Dan Poltawski
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Matteo Scaramuccia, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/May/13