Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38565

When a cache store is set to MODE_SESSION it should include the userid in the keys.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.4.3, 2.5
    • Fix Version/s: 2.4.4, 2.5
    • Component/s: Caching
    • Labels:
    • Testing Instructions:
      Hide
      1. Run unit tests.
      2. Run them again - there are lots!
      3. Upgrade a site
      4. Perform a fresh install
      5. Log in as an admin and set up the front page to display all options for all users.
      6. Test the front page as a guest, student, and admin.
      7. Test switching users.
      8. Run performance tests if you can.
      Show
      Run unit tests. Run them again - there are lots! Upgrade a site Perform a fresh install Log in as an admin and set up the front page to display all options for all users. Test the front page as a guest, student, and admin. Test switching users. Run performance tests if you can.
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull Master Branch:
      wip-MDL-38565-m25

      Description

      Otherwise a site configured with a shared mem storage for the session cache will have a shared keyspace for all users which is not expected.

      Comments from Sam:
      It should be in the loader
      (10:30:09) samhemelryk@moodle.org: cache_session::parse_key should be doing it, but the code is not there ...

      ... write unit tests to test the stores explicitly for collision across all modes is perhaps the best way

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  6 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    13/May/13