Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38012 META: Simplify moodle forms
  3. MDL-38569

Common module settings section should not contain hidden elements

    Details

      Description

      Now that the section Common module settings is collapsed by default, there should not be only one visible element in there.

      My proposition is to remove the setAdvanced to the 3 hidden fields. So that the 4 fields are visible when expanding the section.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            tsala Helen Foster added a comment -

            It seems that the common module settings for several activities have just one see more setting (Groupings). I agree with getting rid of see more/less.

            Show
            tsala Helen Foster added a comment - It seems that the common module settings for several activities have just one see more setting (Groupings). I agree with getting rid of see more/less.
            Hide
            fred Frédéric Massart added a comment -

            Total there are only 5 possible settings, so I removed the advanced ones. Also, I thought that visible and id number looked better at the top of the section. Here is a visual of the suggestion:

            Show
            fred Frédéric Massart added a comment - Total there are only 5 possible settings, so I removed the advanced ones. Also, I thought that visible and id number looked better at the top of the section. Here is a visual of the suggestion:
            Hide
            poltawski Dan Poltawski added a comment -

            +1, submitting for integration. Only thing is that your diff url is weird.

            Show
            poltawski Dan Poltawski added a comment - +1, submitting for integration. Only thing is that your diff url is weird.
            Hide
            damyon Damyon Wiese added a comment -

            Thanks Fred,

            This looks better to me. Integrated to master.

            (Is Dan dissing the mdk diff URL ?)

            Show
            damyon Damyon Wiese added a comment - Thanks Fred, This looks better to me. Integrated to master. (Is Dan dissing the mdk diff URL ?)
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Thanks for fixing this Fred,

            No advance setting is visible in "Common modules settings"

            Show
            rajeshtaneja Rajesh Taneja added a comment - Thanks for fixing this Fred, No advance setting is visible in "Common modules settings"
            Hide
            damyon Damyon Wiese added a comment -

            Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

            Show
            damyon Damyon Wiese added a comment - Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13