[MDL-38569] Common module settings section should not contain hidden elements - Moodle Tracker

XML

Word

Printable

Details

Type: Sub-task
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.5
Fix Version/s: 2.5
Component/s: Forms Library, Usability
Labels:
- triaged
- ui_change

Testing Instructions:
1. Enable enablegroupmembersonly
2. Go to a course and add a forum
3. Expand Common module settings, *Confirm that there is no advanced settings
Affected Branches:
MOODLE_25_STABLE
Fixed Branches:
MOODLE_25_STABLE
Pull from Repository:
git://github.com/FMCorz/moodle.git
Pull Master Branch:
~~MDL-38569~~-master
Pull Master Diff URL:
https://github.com/FMCorz/moodle/compare/373a8e052c6a6d02e1f781312d16c82d8f12ee0e...MDL-38569-master

Description

Now that the section Common module settings is collapsed by default, there should not be only one visible element in there.

My proposition is to remove the setAdvanced to the 3 hidden fields. So that the 4 fields are visible when expanding the section.

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

bonfire-screenshot-20130320-141246-095.png
16 kB
20/Mar/13 2:13 PM
bonfire-screenshot-20130322-113626-532.png
18 kB
22/Mar/13 11:36 AM
common module settings.png
16 kB
20/Mar/13 10:11 PM

Activity

People

Assignee:

Frédéric Massart

Reporter:

Frédéric Massart

Peer reviewer:

Dan Poltawski

Integrator:

Damyon Wiese

Tester:

Rajesh Taneja

Participants:

Damyon Wiese, Dan Poltawski, Frédéric Massart, Helen Foster, Rajesh Taneja

Component watchers:

Jake Dallimore, Jun Pataleta, Barbara Ramiro, Bas Brands

Votes:

1 Vote for this issue

Watchers:

5 Start watching this issue

Dates

Created:

20/Mar/13 2:12 PM

Updated:

30/Sep/13 9:29 PM

Resolved:

28/Mar/13 4:40 PM

Fix Release Date:

14/May/13