Details

    • Testing Instructions:
      Hide
      1. Create a new database module
      2. Confirm that the form is consistent and usable
      3. Save the form and make sure all the fields are correctly saved
      4. Enable/disable the RSS options (enablerssfeeds, data_enablerssfeeds) and make sure it causes the RSS section to appear/disappear
      Show
      Create a new database module Confirm that the form is consistent and usable Save the form and make sure all the fields are correctly saved Enable/disable the RSS options (enablerssfeeds, data_enablerssfeeds) and make sure it causes the RSS section to appear/disappear
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-38590-master-int
    • Rank:
      48617

      Description

      Reformat Database module settings form

        Activity

        Hide
        Frédéric Massart added a comment -

        Here is a quick suggestion on how to reformat this module form. I didn't really know where to put "Comment" and "RSS", that's why I thought of a "Content options", but Adrian and I also thought of "Submissions" and "Requirements" without being convinced by any of those.

        User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:18.0) Gecko/20100101 Firefox/18.0

        Show
        Frédéric Massart added a comment - Here is a quick suggestion on how to reformat this module form. I didn't really know where to put "Comment" and "RSS", that's why I thought of a "Content options", but Adrian and I also thought of "Submissions" and "Requirements" without being convinced by any of those. User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:18.0) Gecko/20100101 Firefox/18.0
        Hide
        Helen Foster added a comment -

        Just noting that we've started a spreadsheet showing how settings are organised across all activities, resources and elsewhere in Moodle:

        https://docs.google.com/spreadsheet/ccc?key=0AmamVlPpCnn4dGx6SlEyMXQ3RzdJYjZCWnFya1ZtN1E&usp=sharing

        Show
        Helen Foster added a comment - Just noting that we've started a spreadsheet showing how settings are organised across all activities, resources and elsewhere in Moodle: https://docs.google.com/spreadsheet/ccc?key=0AmamVlPpCnn4dGx6SlEyMXQ3RzdJYjZCWnFya1ZtN1E&usp=sharing
        Hide
        Frédéric Massart added a comment -

        Here is a proposition for the Database module. I realised that most of the labels were failing to properly describe the fields, which lead to a lot of confusion.

        So I've added a new section "Entries" in which all the entries-related options are. And another section "Availability".

        I am not entirely convinced with the section header "Entries", as when the section is closed you don't really guess the content, but in the other hand, all those are entries related and difficult to organise in different sections.

        Show
        Frédéric Massart added a comment - Here is a proposition for the Database module. I realised that most of the labels were failing to properly describe the fields, which lead to a lot of confusion. So I've added a new section "Entries" in which all the entries-related options are. And another section "Availability". I am not entirely convinced with the section header "Entries", as when the section is closed you don't really guess the content, but in the other hand, all those are entries related and difficult to organise in different sections.
        Hide
        Frédéric Massart added a comment -

        Pushing for peer review. Adrian, that'd be awesome if you could have a look at the proposed changes.

        Show
        Frédéric Massart added a comment - Pushing for peer review. Adrian, that'd be awesome if you could have a look at the proposed changes.
        Hide
        Adrian Greeve added a comment -

        [Y] Syntax
        [Y] Output
        [Y] Whitespace
        [Y] Language
        [-] Databases
        [N] Testing
        [-] Security
        [-] Documentation
        [Y] Git
        [Y] Sanity check

        Hi Fred,

        I have had a closer look at the changes that you have made. I agree that a better heading could be found for 'Entries', but I can not think of a better title myself. I think that the changes to the language strings are good and more descriptive than before.

        I think all you have to do is add some testing instructions and you are good for integration.

        Thanks,

        Show
        Adrian Greeve added a comment - [Y] Syntax [Y] Output [Y] Whitespace [Y] Language [-] Databases [N] Testing [-] Security [-] Documentation [Y] Git [Y] Sanity check Hi Fred, I have had a closer look at the changes that you have made. I agree that a better heading could be found for 'Entries', but I can not think of a better title myself. I think that the changes to the language strings are good and more descriptive than before. I think all you have to do is add some testing instructions and you are good for integration. Thanks,
        Hide
        Frédéric Massart added a comment -

        Thanks Adrian, I'll wait for Helen's feedback as well before pushing it further. Cheers!

        Show
        Frédéric Massart added a comment - Thanks Adrian, I'll wait for Helen's feedback as well before pushing it further. Cheers!
        Hide
        Helen Foster added a comment -

        Looking good Fred. I posted one of your screenshots in the database forum to ask for people's ideas and suggestions on your proposed solution: https://moodle.org/mod/forum/discuss.php?d=225474 I'll just go and add my suggestions there too...

        Show
        Helen Foster added a comment - Looking good Fred. I posted one of your screenshots in the database forum to ask for people's ideas and suggestions on your proposed solution: https://moodle.org/mod/forum/discuss.php?d=225474 I'll just go and add my suggestions there too...
        Hide
        Frédéric Massart added a comment -

        I've added the RSS section as suggested by Stuart on Moodle.org. I think it's a good idea to have a section with only one field it's secondary and very well defined.

        I also rearranged the fields in Entries as suggested by Helen on the forum.

        Pushing for peer review.

        Show
        Frédéric Massart added a comment - I've added the RSS section as suggested by Stuart on Moodle.org. I think it's a good idea to have a section with only one field it's secondary and very well defined. I also rearranged the fields in Entries as suggested by Helen on the forum. Pushing for peer review.
        Hide
        Adrian Greeve added a comment -

        Hi Fred,

        I'm happy with this. Feel free to send it to integration.

        Show
        Adrian Greeve added a comment - Hi Fred, I'm happy with this. Feel free to send it to integration.
        Hide
        Frédéric Massart added a comment -

        Thanks Adrian, pushing forward.

        Show
        Frédéric Massart added a comment - Thanks Adrian, pushing forward.
        Hide
        Damyon Wiese added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        Thanks!

        Show
        Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
        Hide
        David Monllaó added a comment -

        This changes are breaking behat tests, adding a commit on top of integration to solve the problem.

        git pull git://github.com/dmonllao/moodle.git MDL-38590_master-fix-behat

        Show
        David Monllaó added a comment - This changes are breaking behat tests, adding a commit on top of integration to solve the problem. git pull git://github.com/dmonllao/moodle.git MDL-38590 _master-fix-behat
        Hide
        Dan Poltawski added a comment -

        I've pulled that in, thanks David.

        Show
        Dan Poltawski added a comment - I've pulled that in, thanks David.
        Hide
        Michael de Raadt added a comment -

        Test result: Success!

        Show
        Michael de Raadt added a comment - Test result: Success!
        Hide
        Dan Poltawski added a comment -

        Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

        line 1289 of \lib\changes.php: call to debugging()
        line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
        line 202 of \lib\now.php: call to moodleform->_is_poor_form()
        line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

        Show
        Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()
        Hide
        Mary Cooch added a comment -

        Removing docs_required label as these new display settings are now documented in http://docs.moodle.org/25/en/Database_activity_settings

        Show
        Mary Cooch added a comment - Removing docs_required label as these new display settings are now documented in http://docs.moodle.org/25/en/Database_activity_settings

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: