Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Forms Library
    • Labels:
      None
    • Testing Instructions:
      Hide
      1. Go to My home ► Any course ► Grade administration ► My report preferences ► Grader report
      2. Observe the form, and confirm that the advanced options are hidden by default, and not hidden once the page is loaded.
      3. Turn JS off and confirm the advanced settings are displayed.

      (Known issue: the Show more/less link will create a slight flickering)

      Show
      Go to My home ► Any course ► Grade administration ► My report preferences ► Grader report Observe the form, and confirm that the advanced options are hidden by default, and not hidden once the page is loaded. Turn JS off and confirm the advanced settings are displayed. (Known issue: the Show more/less link will create a slight flickering)
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-38598-master-int
    • Rank:
      48625

      Description

      When you load up a page, the advanced settings are displayed, and then hidden via Javascript. This could be fixed by CSS.

        Activity

        Hide
        Dan Poltawski added a comment -

        Looks good to me! Submitting for integration. Thanks Fred.

        Show
        Dan Poltawski added a comment - Looks good to me! Submitting for integration. Thanks Fred.
        Hide
        Damyon Wiese added a comment -

        Thanks Fred,

        The change looks good to me. I added a version bump for the javascript.

        Integrated to master.

        Show
        Damyon Wiese added a comment - Thanks Fred, The change looks good to me. I added a version bump for the javascript. Integrated to master.
        Hide
        David Monllaó added a comment -

        It passes, I haven't noticed the slight flickering using Linux+Chrome

        Show
        David Monllaó added a comment - It passes, I haven't noticed the slight flickering using Linux+Chrome
        Hide
        Damyon Wiese added a comment -

        Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

        Show
        Damyon Wiese added a comment - Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: