Details

      Description

      Reformat Glossary module settings form

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Frédéric Massart added a comment -

            Here are two screenshots of a proposed solution. I am not sure about the use of Show more/less.

            User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:18.0) Gecko/20100101 Firefox/18.0

            Show
            Frédéric Massart added a comment - Here are two screenshots of a proposed solution. I am not sure about the use of Show more/less. User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:18.0) Gecko/20100101 Firefox/18.0
            Hide
            Frédéric Massart added a comment -

            Here is another look for Glossary. I spent quite some time exchanging with Barbara about usability.

            So I created 2 new sections, Entries and Appearance.

            "Entries shown per page" is no longer a required field so that its section is not expanded. Also, there is a default admin settings for that one, which was not used. I have changed so that if you empty the field, the default setting is used, which makes sense to me.

            Show
            Frédéric Massart added a comment - Here is another look for Glossary. I spent quite some time exchanging with Barbara about usability. So I created 2 new sections, Entries and Appearance. "Entries shown per page" is no longer a required field so that its section is not expanded. Also, there is a default admin settings for that one, which was not used. I have changed so that if you empty the field, the default setting is used, which makes sense to me.
            Hide
            Frédéric Massart added a comment -

            Sending for peer review.

            Show
            Frédéric Massart added a comment - Sending for peer review.
            Hide
            Helen Foster added a comment -

            Hi Fred, good plan to make 'entries shown per page' not a required field.

            It looks really good to me, having sections for entries and appearance.

            I just have one tiny suggested improvement: Have 'Display format' to the top of the appearance section (since I think it's the most important appearance setting) and move 'Entries shown per page' to below 'Approval display format' i.e.

            Display format
            Approval display format
            Entries shown per page
            Show alphabet links
            .
            .
            .

            Show
            Helen Foster added a comment - Hi Fred, good plan to make 'entries shown per page' not a required field. It looks really good to me, having sections for entries and appearance. I just have one tiny suggested improvement: Have 'Display format' to the top of the appearance section (since I think it's the most important appearance setting) and move 'Entries shown per page' to below 'Approval display format' i.e. Display format Approval display format Entries shown per page Show alphabet links . . .
            Hide
            Frédéric Massart added a comment -

            Done, thanks!

            Show
            Frédéric Massart added a comment - Done, thanks!
            Hide
            Helen Foster added a comment -

            Thanks Fred.

            Just noting that I've posted in the glossary forum asking what people think of your proposed solution:
            https://moodle.org/mod/forum/discuss.php?d=225468

            Show
            Helen Foster added a comment - Thanks Fred. Just noting that I've posted in the glossary forum asking what people think of your proposed solution: https://moodle.org/mod/forum/discuss.php?d=225468
            Hide
            Eloy Lafuente (stronk7) added a comment -

            (seems it was mature enough and ppl at forum agreed so sent straight to integration)

            Show
            Eloy Lafuente (stronk7) added a comment - (seems it was mature enough and ppl at forum agreed so sent straight to integration)
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Integrated (had to solve some recent conflict with just added missing setType() line), thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - Integrated (had to solve some recent conflict with just added missing setType() line), thanks!
            Hide
            Adrian Greeve added a comment -

            Tested on the master integration branch.
            No problems found.
            Test passed.

            Show
            Adrian Greeve added a comment - Tested on the master integration branch. No problems found. Test passed.
            Hide
            Dan Poltawski added a comment -

            Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

            line 1289 of \lib\changes.php: call to debugging()
            line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
            line 202 of \lib\now.php: call to moodleform->_is_poor_form()
            line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

            Show
            Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()
            Hide
            Mary Cooch added a comment -

            Removing docs_required label as these new display settings are now documented in http://docs.moodle.org/25/en/Glossary_settings

            Show
            Mary Cooch added a comment - Removing docs_required label as these new display settings are now documented in http://docs.moodle.org/25/en/Glossary_settings

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: