Details

      Description

      Reformat Workshop module settings form

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            fred Frédéric Massart added a comment -

            My suggestion is to remove all the advanced settings to get rid of all the Show more/less which don't add much more readability now that the sections are collapsed.

            Show
            fred Frédéric Massart added a comment - My suggestion is to remove all the advanced settings to get rid of all the Show more/less which don't add much more readability now that the sections are collapsed.
            Hide
            fred Frédéric Massart added a comment -

            Also Miscellaneous could be renamed Conclusion if the Conclusion text area can't fit somewhere else.

            Show
            fred Frédéric Massart added a comment - Also Miscellaneous could be renamed Conclusion if the Conclusion text area can't fit somewhere else.
            Hide
            tsala Helen Foster added a comment -

            David, I've added you as workshop component lead for your expert opinion here. Perhaps one of us can post in the workshop forum asking for ideas.

            Also noting that we've started a spreadsheet showing how settings are organised across all activities, resources and elsewhere in Moodle:

            https://docs.google.com/spreadsheet/ccc?key=0AmamVlPpCnn4dGx6SlEyMXQ3RzdJYjZCWnFya1ZtN1E&usp=sharing

            Show
            tsala Helen Foster added a comment - David, I've added you as workshop component lead for your expert opinion here. Perhaps one of us can post in the workshop forum asking for ideas. Also noting that we've started a spreadsheet showing how settings are organised across all activities, resources and elsewhere in Moodle: https://docs.google.com/spreadsheet/ccc?key=0AmamVlPpCnn4dGx6SlEyMXQ3RzdJYjZCWnFya1ZtN1E&usp=sharing
            Hide
            tsala Helen Foster added a comment -

            Just noting that more workshop settings are due to be added as part of MDL-37602, also that I've posted in the workshop forum asking for ideas:
            https://moodle.org/mod/forum/discuss.php?d=225381

            Show
            tsala Helen Foster added a comment - Just noting that more workshop settings are due to be added as part of MDL-37602 , also that I've posted in the workshop forum asking for ideas: https://moodle.org/mod/forum/discuss.php?d=225381
            Hide
            mudrd8mz David Mudrák added a comment -

            OK. I was thinking about Fred's comments at https://moodle.org/mod/forum/discuss.php?d=225381#p984309, was playing with the Workshop settings form and looked at how other modules do things. Finally, I agree with Fred.

            Mixing collapsible sections with advanced fields does not work well. Especially now when we do not even mark those fields as explicitly "advanced" (we just display "Show more" which is not the same). So I decided to stop using them at all.

            I reorganised the form a bit so that only the Grading settings section is expanded by default (as it contains the most essential setting for the activity). All other sections have reasonable defaults so the teacher can look at them only when needed.

            I improved the section headings a bit so it should be more intuitive now what they contain (very good point Fred).

            I prepared a patchset consisting of couple of sequential patches that should illustrate my reasoning behind the change.

            Frédéric Massart, can you please peer-review my branch and confirm it's coherent with what was done in other modules. If you like it, I would submit it for integration. TIA.

            Show
            mudrd8mz David Mudrák added a comment - OK. I was thinking about Fred's comments at https://moodle.org/mod/forum/discuss.php?d=225381#p984309 , was playing with the Workshop settings form and looked at how other modules do things. Finally, I agree with Fred. Mixing collapsible sections with advanced fields does not work well. Especially now when we do not even mark those fields as explicitly "advanced" (we just display "Show more" which is not the same). So I decided to stop using them at all. I reorganised the form a bit so that only the Grading settings section is expanded by default (as it contains the most essential setting for the activity). All other sections have reasonable defaults so the teacher can look at them only when needed. I improved the section headings a bit so it should be more intuitive now what they contain (very good point Fred). I prepared a patchset consisting of couple of sequential patches that should illustrate my reasoning behind the change. Frédéric Massart , can you please peer-review my branch and confirm it's coherent with what was done in other modules. If you like it, I would submit it for integration. TIA.
            Hide
            mudrd8mz David Mudrák added a comment -

            Attaching a screenshot of the default Workshop settings form.

            Show
            mudrd8mz David Mudrák added a comment - Attaching a screenshot of the default Workshop settings form.
            Hide
            fred Frédéric Massart added a comment -

            Hi David,

            Thanks for working on this, I like your proposed solution, it looks really good to me. Here are a few minor comments.

            Submission settings

            1. When I saw Maximum file size I first thought it was in the wrong section, do you think it's worth indicating in the label that this is related to the submission attachments?

            Feedback

            1. I guess you could make use of AMOS CPY for the new string Feedback.
            2. Conclusion does not speak to me without reading the help info, could that be renamed to something more descriptive?
            3. When I saw Maximum file size I first thought it was in the wrong section, do you think it's worth indicating in the label that this is related to the feedback attachments?

            Access control

            Other plugins use "Availability", but as this is related to the content of the activity, and not the availability of the activity itself, I think it's the one to go for.

            My home ► Site administration ► Plugins ► Activity modules ► Workshop

            1. Would this page need to be reorganised as well?

            Commit message

            1. You could use the component here

            Feel free to push that for integration.

            Show
            fred Frédéric Massart added a comment - Hi David, Thanks for working on this, I like your proposed solution, it looks really good to me. Here are a few minor comments. Submission settings When I saw Maximum file size I first thought it was in the wrong section, do you think it's worth indicating in the label that this is related to the submission attachments? Feedback I guess you could make use of AMOS CPY for the new string Feedback . Conclusion does not speak to me without reading the help info, could that be renamed to something more descriptive? When I saw Maximum file size I first thought it was in the wrong section, do you think it's worth indicating in the label that this is related to the feedback attachments? Access control Other plugins use "Availability", but as this is related to the content of the activity, and not the availability of the activity itself, I think it's the one to go for. My home ► Site administration ► Plugins ► Activity modules ► Workshop Would this page need to be reorganised as well? Commit message You could use the component here Feel free to push that for integration.
            Hide
            tsala Helen Foster added a comment -

            David, your proposed solution looks really good to me too.

            I just have a few further suggestions following on from Fred's comments:

            • Re. 'Maximum file size' perhaps we could do the same as in forum settings, where it's called 'Maximum attachment size'? Thus, if they're not too long, could we have 'Maximum submission attachment size' and 'Maximum overall feedback attachment size'?
            • Re. 'Access control', I think 'Availability' would be better, for consistency with other activities, also we already have 'Restrict access' section when conditional activities are enabled. Having 'Access control' and 'Restrict access' in one settings page seems a bit much to me.
            • Re. 'Conclusion', I think the name is fine, but it would make more sense to have it listed last in the Feedback section i.e.

            Feedback
            Overall feedback mode
            Maximum number of overall feedback attachments
            Maximum overall feedback attachment size
            Conclusion

            Show
            tsala Helen Foster added a comment - David, your proposed solution looks really good to me too. I just have a few further suggestions following on from Fred's comments: Re. 'Maximum file size' perhaps we could do the same as in forum settings, where it's called 'Maximum attachment size'? Thus, if they're not too long, could we have 'Maximum submission attachment size' and 'Maximum overall feedback attachment size'? Re. 'Access control', I think 'Availability' would be better, for consistency with other activities, also we already have 'Restrict access' section when conditional activities are enabled. Having 'Access control' and 'Restrict access' in one settings page seems a bit much to me. Re. 'Conclusion', I think the name is fine, but it would make more sense to have it listed last in the Feedback section i.e. Feedback Overall feedback mode Maximum number of overall feedback attachments Maximum overall feedback attachment size Conclusion
            Hide
            mudrd8mz David Mudrák added a comment -

            Thanks a lot Frédéric Massart and Helen Foster. I have incorporated all your suggestions and am vectoring this for the final approach.

            Show
            mudrd8mz David Mudrák added a comment - Thanks a lot Frédéric Massart and Helen Foster . I have incorporated all your suggestions and am vectoring this for the final approach.
            Hide
            poltawski Dan Poltawski added a comment -

            Integrated to master.

            Thanks David/Fred/Helen, pleasure to read the discussion on this issue

            Show
            poltawski Dan Poltawski added a comment - Integrated to master. Thanks David/Fred/Helen, pleasure to read the discussion on this issue
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            No errors noticed.
            Passing
            Thanks.

            Show
            ankit_frenz Ankit Agarwal added a comment - No errors noticed. Passing Thanks.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            I feel myself really alone tonight! So was time to push your fixes upstream!

            "Lest we forget. We will remember them."

            Thanks and ciao!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - I feel myself really alone tonight! So was time to push your fixes upstream! "Lest we forget. We will remember them." Thanks and ciao!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13