Details

    • Rank:
      48637

      Description

      I think the only thing to do here is to add the Label description into its own section.

        Activity

        Hide
        Ankit Agarwal added a comment -

        Hi Fred,
        Patch looks good to me. All other elements seems to be in appropriate places in the form. Pushing for integration.
        Thanks

        Show
        Ankit Agarwal added a comment - Hi Fred, Patch looks good to me. All other elements seems to be in appropriate places in the form. Pushing for integration. Thanks
        Hide
        Damyon Wiese added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        Thanks!

        Show
        Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
        Hide
        Damyon Wiese added a comment -

        This change looks good Fred.

        Thanks - integrated to master only.

        Show
        Damyon Wiese added a comment - This change looks good Fred. Thanks - integrated to master only.
        Hide
        Rajesh Taneja added a comment -

        Thanks Fred,

        Label settings has a General section.

        Show
        Rajesh Taneja added a comment - Thanks Fred, Label settings has a General section.
        Hide
        Dan Poltawski added a comment -

        Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

        line 1289 of \lib\changes.php: call to debugging()
        line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
        line 202 of \lib\now.php: call to moodleform->_is_poor_form()
        line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

        Show
        Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()
        Hide
        Mary Cooch added a comment -

        Removing docs_required label as these new display settings have been documented here http://docs.moodle.org/25/en/Label_module_settings

        Show
        Mary Cooch added a comment - Removing docs_required label as these new display settings have been documented here http://docs.moodle.org/25/en/Label_module_settings

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: