Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Forms Library, Usability
    • Labels:
    • Testing Instructions:
      Hide
      1. Add a new URL resource
      2. Make sure
        • The URL field is in a section called Content
        • The content section is expanded by default
        • The file picker opens normally when you click "Choose a link..."
        • The Parameters section does not contain advanced settings

      (The description field is collapsed in the screenshots, but that is part of another issue, please ignore it)

      Show
      Add a new URL resource Make sure The URL field is in a section called Content The content section is expanded by default The file picker opens normally when you click "Choose a link..." The Parameters section does not contain advanced settings (The description field is collapsed in the screenshots, but that is part of another issue, please ignore it)
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-38612-master-int
    • Rank:
      48639

      Description

      Reformat URL resource settings form

        Activity

        Hide
        Frédéric Massart added a comment -

        Screenshots of the suggested solution.

        Show
        Frédéric Massart added a comment - Screenshots of the suggested solution.
        Hide
        Helen Foster added a comment - - edited

        Good work making parameters not advanced settings.

        Just noting that we have to keep other advanced settings such as pop-up width and height, since they are set by an admin for the site.

        Also noting that perhaps it's better to keep the URL setting in a section called 'Content' for consistency with other resources https://docs.google.com/spreadsheet/ccc?key=0AmamVlPpCnn4dGx6SlEyMXQ3RzdJYjZCWnFya1ZtN1E#gid=1 Apologies for changing my mind...

        Show
        Helen Foster added a comment - - edited Good work making parameters not advanced settings. Just noting that we have to keep other advanced settings such as pop-up width and height, since they are set by an admin for the site. Also noting that perhaps it's better to keep the URL setting in a section called 'Content' for consistency with other resources https://docs.google.com/spreadsheet/ccc?key=0AmamVlPpCnn4dGx6SlEyMXQ3RzdJYjZCWnFya1ZtN1E#gid=1 Apologies for changing my mind...
        Hide
        Frédéric Massart added a comment -

        Thanks Helen. That's fixed.

        Show
        Frédéric Massart added a comment - Thanks Helen. That's fixed.
        Hide
        Michael de Raadt added a comment -

        A nice simple fix.

        [Y] Syntax
        [Y] Output
        [Y] Whitespace
        [-] Language
        [-] Databases
        [Y] Testing
        [-] Security
        [-] Documentation
        [Y] Git
        [Y] Sanity check

        I ammended the testing instructions slightly. I hope that is OK.

        Show
        Michael de Raadt added a comment - A nice simple fix. [Y] Syntax [Y] Output [Y] Whitespace [-] Language [-] Databases [Y] Testing [-] Security [-] Documentation [Y] Git [Y] Sanity check I ammended the testing instructions slightly. I hope that is OK.
        Hide
        Damyon Wiese added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        Thanks!

        Show
        Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
        Hide
        Michael de Raadt added a comment -

        Test result: Success!

        Show
        Michael de Raadt added a comment - Test result: Success!
        Hide
        Dan Poltawski added a comment -

        Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

        line 1289 of \lib\changes.php: call to debugging()
        line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
        line 202 of \lib\now.php: call to moodleform->_is_poor_form()
        line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

        Show
        Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: