Moodle
  1. Moodle
  2. MDL-38632

Observe show_expanded setting when displaying folder inline

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Resource
    • Labels:
      None
    • Testing Instructions:
      Hide

      Create one folder resource with various subfolders and files (up to 3 levels is ok).

      A) Try the four combinations of these 2 settings and verify that in all them the folder is displayed accordingly:

      • Display folder contents (course page / separate page).
      • Show sub-folders expanded (yes / no).

      B) With display in course page selected, try the four combinations of these 2 settings and verify that in all them the folder is displayed accordingly:

      • Display description on course page (yes / no).
      • Show sub-folders expanded (yes / no).

      That's all!

      Show
      Create one folder resource with various subfolders and files (up to 3 levels is ok). A) Try the four combinations of these 2 settings and verify that in all them the folder is displayed accordingly: Display folder contents (course page / separate page). Show sub-folders expanded (yes / no). B) With display in course page selected, try the four combinations of these 2 settings and verify that in all them the folder is displayed accordingly: Display description on course page (yes / no). Show sub-folders expanded (yes / no). That's all!
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      48665

      Description

      This is a followup of MDL-30790 where a new setting (show_expanded) was added to decide if the folders were going to be shown totally expanded (show_expanded = 1, default) or only 1st level (show_expanded = 0).

      And it's working perfectly but because of the tiny detail of the new setting being completely ignored when the folder is displayed inline in the course page.

      So this is about to make show_expanded to be observed when the folder is shown inline.

        Issue Links

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          Sending straight to integration, the change was trivial.

          Show
          Eloy Lafuente (stronk7) added a comment - Sending straight to integration, the change was trivial.
          Hide
          Damyon Wiese added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          Thanks!

          Show
          Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
          Hide
          Aparup Banerjee added a comment -

          thanks, integrated into master only.

          Show
          Aparup Banerjee added a comment - thanks, integrated into master only.
          Hide
          Rajesh Taneja added a comment -

          This works as expected, if folder is created in proper course section.

          If folder is created in "Orphaned activities" section and "Show sub-folders expanded" has no effect when displayed inline on a course page.

          Seems to be another issue to handle, let me know and I will pass this.

          Show
          Rajesh Taneja added a comment - This works as expected, if folder is created in proper course section. If folder is created in "Orphaned activities" section and "Show sub-folders expanded" has no effect when displayed inline on a course page. Seems to be another issue to handle, let me know and I will pass this.
          Hide
          Rajesh Taneja added a comment -

          Passing this as problem only happens for topic format with custom section label and orphan sections (in editing mode)

          Works perfectly otherwise.

          Show
          Rajesh Taneja added a comment - Passing this as problem only happens for topic format with custom section label and orphan sections (in editing mode) Works perfectly otherwise.
          Hide
          Damyon Wiese added a comment -

          Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

          Show
          Damyon Wiese added a comment - Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: