Moodle
  1. Moodle
  2. MDL-38633

Add support for show_expanded in backup & restore

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Resource
    • Labels:
    • Testing Instructions:
      Hide

      A) Restoring old backups.

      1) In admin->Plugins->activities->folder untick show_expanded (disabled).
      2) Restore a <2.5 backup having a folder.
      3) The restored folder works and has its "Show sub-folders expanded" setting DISABLED.

      4) In admin->Plugins->activities->folder tick show_expanded (enabled).
      5) Restore a <2.5 backup having a folder.
      6) The restored folder works and has its "Show sub-folders expanded" setting ENABLED.

      B) Restoring current backups.

      7) Duplicate the activity restored in 3)
      8) The duplicate folder works and has its "Show sub-folders expanded" setting DISABLED. (same than the original)

      9) Duplicate the activity restored in 6)
      10) The duplicate folder works and has its "Show sub-folders expanded" setting ENABLED. (same than the original)

      That's all!

      Show
      A) Restoring old backups. 1) In admin->Plugins->activities->folder untick show_expanded (disabled). 2) Restore a <2.5 backup having a folder. 3) The restored folder works and has its "Show sub-folders expanded" setting DISABLED. 4) In admin->Plugins->activities->folder tick show_expanded (enabled). 5) Restore a <2.5 backup having a folder. 6) The restored folder works and has its "Show sub-folders expanded" setting ENABLED. B) Restoring current backups. 7) Duplicate the activity restored in 3) 8) The duplicate folder works and has its "Show sub-folders expanded" setting DISABLED. (same than the original) 9) Duplicate the activity restored in 6) 10) The duplicate folder works and has its "Show sub-folders expanded" setting ENABLED. (same than the original) That's all!
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      48666

      Description

      This is a followup of MDL-30790 discovered while playing with MDL-38632.

      A new setting was added to mod_folder and it's missing in backup & restore.

      This is about to:

      1) add support to it.
      2) default to global setting value on restore operations missing it.

      Ciao

        Issue Links

          Activity

          Hide
          Damyon Wiese added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          Thanks!

          Show
          Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday.

          This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody.

          This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P

          Apologies for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday. This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody. This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P Apologies for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao
          Hide
          Damyon Wiese added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          Thanks!

          Show
          Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
          Hide
          Damyon Wiese added a comment -

          Thanks Eloy - I tested this as I integrated it and it all works as expected.

          Integrated to master now.

          Show
          Damyon Wiese added a comment - Thanks Eloy - I tested this as I integrated it and it all works as expected. Integrated to master now.
          Hide
          Damyon Wiese added a comment -

          Passing this as I tested it in integration.

          Show
          Damyon Wiese added a comment - Passing this as I tested it in integration.
          Hide
          Dan Poltawski added a comment -

          Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

          line 1289 of \lib\changes.php: call to debugging()
          line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
          line 202 of \lib\now.php: call to moodleform->_is_poor_form()
          line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

          Show
          Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: