Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38636

Hidden module names are difficult to read on breadcrumb in Serenity theme

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.1, 2.5.5, 2.6.2, 2.7
    • Fix Version/s: 2.5.6, 2.6.3
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      Set the theme to Serenity
      Add an activity such as a quiz, page, or forum
      Set the activity to hidden
      Enter the activity as a teacher or admin
      Is the activity name visible clearly in the breadcumb

      Show
      Set the theme to Serenity Add an activity such as a quiz, page, or forum Set the activity to hidden Enter the activity as a teacher or admin Is the activity name visible clearly in the breadcumb
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-38636-master

      Description

      Mild grey of hidden course-module instances is very close to the breadcrumb color of Serenity theme and it's hard to read it. It's particulary bad if a breadcrumb is you most obvious link from details of module pages back to the title page.

      1. Get a site with Serenity theme
      2. Create a quiz there, making it hidden (unavailable to the students)
      3. Go to quiz editing screen (where you add questions) and look at the quiz name on the breadcrumb.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            roelmann Richard Oelmann added a comment -

            Add
            .navbar a.dimmed_text {
            color:#f2f2f2;
            }
            at about line 77 (the Navbar section) of the core.css file of Serenity

            I don't have it set up at the moment to create a branch and a pull request for the fix, but will do so as soon as I get chance (unless Mary or Gareth get there first

            Show
            roelmann Richard Oelmann added a comment - Add .navbar a.dimmed_text { color:#f2f2f2; } at about line 77 (the Navbar section) of the core.css file of Serenity I don't have it set up at the moment to create a branch and a pull request for the fix, but will do so as soon as I get chance (unless Mary or Gareth get there first
            Hide
            roelmann Richard Oelmann added a comment -

            Just for completeness - its not just the quiz, its when you go into any hidden activity, the item in the breadcrumb picks up the a.dimmed_text from base theme.

            Show
            roelmann Richard Oelmann added a comment - Just for completeness - its not just the quiz, its when you go into any hidden activity, the item in the breadcrumb picks up the a.dimmed_text from base theme.
            Hide
            lazydaisy Mary Evans added a comment -

            Hi Richard, I was going to ask you to fix this if you can?

            It was automatically assigned to me last year, but must have slipped through the net. Unfortunately we cannot fix 2.4 as that is only fixed for security issues, but it can be back-ported to 2.5 and 2.6. So if you do this you will need to have three branches. One based on master, one on MOODLE_26_STABLE and one on MOODLE_25_STABLE.

            I'll see if I can get you signed in as a developer so you can help us fix stuff.

            Show
            lazydaisy Mary Evans added a comment - Hi Richard, I was going to ask you to fix this if you can? It was automatically assigned to me last year, but must have slipped through the net. Unfortunately we cannot fix 2.4 as that is only fixed for security issues, but it can be back-ported to 2.5 and 2.6. So if you do this you will need to have three branches. One based on master, one on MOODLE_26_STABLE and one on MOODLE_25_STABLE. I'll see if I can get you signed in as a developer so you can help us fix stuff.
            Hide
            roelmann Richard Oelmann added a comment -

            NP Mary, I'll get the branches set up on my computer over the weekend and get it sorted - I'm not at home to get at my development PC until Saturday evening (well not for long enough to get this set up) but, I'll get it sorted over the weekend

            Show
            roelmann Richard Oelmann added a comment - NP Mary, I'll get the branches set up on my computer over the weekend and get it sorted - I'm not at home to get at my development PC until Saturday evening (well not for long enough to get this set up) but, I'll get it sorted over the weekend
            Hide
            roelmann Richard Oelmann added a comment -

            No fix done for 2.4 as that is security fixes only. However, anyone that needs this, the change will work on previous versions as well.

            Show
            roelmann Richard Oelmann added a comment - No fix done for 2.4 as that is security fixes only. However, anyone that needs this, the change will work on previous versions as well.
            Hide
            lazydaisy Mary Evans added a comment -

            Hi Richard...thanks for doing this at such short notice.

            I've corrected the branches as written in the fields above. This is how it needs to be written whenever you submit branches, including the git://github.com/username/moodle.git part for the repo address.
            This is all standard practice not just me being picky. LOL.

            I'm just testing this now so when finished the review will give the all clear and push it to be integrated.

            Show
            lazydaisy Mary Evans added a comment - Hi Richard...thanks for doing this at such short notice. I've corrected the branches as written in the fields above. This is how it needs to be written whenever you submit branches, including the git://github.com/username/moodle.git part for the repo address. This is all standard practice not just me being picky. LOL. I'm just testing this now so when finished the review will give the all clear and push it to be integrated.
            Hide
            lazydaisy Mary Evans added a comment -

            Looks to be OK Richard so pushing for Integration Review.

            Thanks again
            Mary

            Show
            lazydaisy Mary Evans added a comment - Looks to be OK Richard so pushing for Integration Review. Thanks again Mary
            Hide
            roelmann Richard Oelmann added a comment -

            No problem Mary - and thanks for correcting the branches to the proper format above

            Show
            roelmann Richard Oelmann added a comment - No problem Mary - and thanks for correcting the branches to the proper format above
            Hide
            cibot CiBoT added a comment -

            Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

            Show
            cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
            Hide
            marina Marina Glancy added a comment -

            Thanks Richard and Mary, integrated in 2.5, 2.6 and master

            Show
            marina Marina Glancy added a comment - Thanks Richard and Mary, integrated in 2.5, 2.6 and master
            Hide
            lazydaisy Mary Evans added a comment -

            Hi Marina, I have just assigned this to Richard Oelmann now that he has been given Jira-Developer status.

            Show
            lazydaisy Mary Evans added a comment - Hi Marina, I have just assigned this to Richard Oelmann now that he has been given Jira-Developer status.
            Hide
            salvetore Michael de Raadt added a comment -

            Test result: Success!

            Tested in 2.5, 2.6 and master branches.

            Thanks for your efforts!

            Show
            salvetore Michael de Raadt added a comment - Test result: Success! Tested in 2.5, 2.6 and master branches. Thanks for your efforts!
            Hide
            marina Marina Glancy added a comment -

            Thanks for your awesome code, it is now part of Moodle. Don't forget to submit another issue next week (and peer review two).

            Show
            marina Marina Glancy added a comment - Thanks for your awesome code, it is now part of Moodle. Don't forget to submit another issue next week (and peer review two).
            Hide
            fred Frédéric Massart added a comment -

            Just noting the commit hash (2498dce0e944ac2654e0b07b529d1349fadfdac3) for further reference because the commit message does not include the MDL.

            Show
            fred Frédéric Massart added a comment - Just noting the commit hash (2498dce0e944ac2654e0b07b529d1349fadfdac3) for further reference because the commit message does not include the MDL.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/May/14