Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Forms Library, Usability
    • Labels:
    • Testing Instructions:
      Hide

      Test pre-requisites

      • Enable enableavailability
      • Enable enablecompletion

      Test steps

      1. Add a new event
        • Make sure there is a margin between the radio button and the label in the Duration section
      2. Edit a forum. Make sure there is a margin
        • Between the checkbox and the label next to Require view, in the Activity completion section
        • Between the checkbox and the label next to Expected completed on, in the Activity completion section
        • Between the checkbox and the label next to Allow access from, in the Restrict access section
      3. Edit a quiz. Make sure there is a margin
        • Between the checkbox and the label next to Time limit, in the Timing section
        • Between the checkboxes and the labels next to Immediately after the attempt, in the Review options section
      4. Repeat the test in RTL mode
      Show
      Test pre-requisites Enable enableavailability Enable enablecompletion Test steps Add a new event Make sure there is a margin between the radio button and the label in the Duration section Edit a forum. Make sure there is a margin Between the checkbox and the label next to Require view , in the Activity completion section Between the checkbox and the label next to Expected completed on , in the Activity completion section Between the checkbox and the label next to Allow access from , in the Restrict access section Edit a quiz. Make sure there is a margin Between the checkbox and the label next to Time limit , in the Timing section Between the checkboxes and the labels next to Immediately after the attempt , in the Review options section Repeat the test in RTL mode
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-38645-master
    • Rank:
      48684

      Description

      Some checkboxes and radio buttons are glued to their label.

        Activity

        Hide
        Michael de Raadt added a comment -

        It was good to see the addition of the RTL rules. I would have missed that.

        [Y] Syntax
        [Y] Output
        [Y] Whitespace
        [-] Language
        [-] Databases
        [Y] Testing
        [-] Security
        [-] Documentation
        [Y] Git
        [-] Sanity check
        

        Is the "vertical-align: text-bottom" CSS rule really needed? It is consistent with a other icon presentations. If it is needed, perhaps it should appear in the RTL CSS also.

        Show
        Michael de Raadt added a comment - It was good to see the addition of the RTL rules. I would have missed that. [Y] Syntax [Y] Output [Y] Whitespace [-] Language [-] Databases [Y] Testing [-] Security [-] Documentation [Y] Git [-] Sanity check Is the "vertical-align: text-bottom" CSS rule really needed? It is consistent with a other icon presentations. If it is needed, perhaps it should appear in the RTL CSS also.
        Hide
        Frédéric Massart added a comment -

        We've used a lot text-bottom, especially with the icons. I feel that the text is better aligned with that rule. There is no need to add it to the RTL rules as they inherit the LTR.
        Thanks Michael, pushing for integration now.

        Show
        Frédéric Massart added a comment - We've used a lot text-bottom, especially with the icons. I feel that the text is better aligned with that rule. There is no need to add it to the RTL rules as they inherit the LTR. Thanks Michael, pushing for integration now.
        Hide
        Damyon Wiese added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        Thanks!

        Show
        Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Blindly integrated, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Blindly integrated, thanks!
        Hide
        Rajesh Taneja added a comment -

        Thanks Fred,

        Looks great.

        Show
        Rajesh Taneja added a comment - Thanks Fred, Looks great.
        Hide
        Dan Poltawski added a comment -

        Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

        line 1289 of \lib\changes.php: call to debugging()
        line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
        line 202 of \lib\now.php: call to moodleform->_is_poor_form()
        line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

        Show
        Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: