Details

    • Testing Instructions:
      Hide

      For mobile device owners:
      1/ configure mymobile theme for phones
      2/ test mymobile on phone
      3/ verify it looks/works the same before and after this patch

      Show
      For mobile device owners: 1/ configure mymobile theme for phones 2/ test mymobile on phone 3/ verify it looks/works the same before and after this patch
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-38650_master

      Gliffy Diagrams

        Issue Links

          Activity

          Hide
          Gareth J Barnard added a comment -

          I can do this fully as soon as MDL-15727 is integrated. Initial versions of JavaScript frameworks will depend on what is integrated. May in the initial instance use 'overrides'. Is this required before the 29th March deadline?

          Show
          Gareth J Barnard added a comment - I can do this fully as soon as MDL-15727 is integrated. Initial versions of JavaScript frameworks will depend on what is integrated. May in the initial instance use 'overrides'. Is this required before the 29th March deadline?
          Hide
          Petr Skoda added a comment -

          Thanks, if MDL-15727 gets integrated then I suppose this might be also called a bugfix which should be acceptable after the deadline. I do not expect there will be any new version of jQuery or jQuery UI before our freeze. I hope there will not be any changes or problems during MDL-15727 integration, if you have this finished before Tuesday please submit it for integration. The worst case scenario would be to revert everything to current state which would be easy.

          Show
          Petr Skoda added a comment - Thanks, if MDL-15727 gets integrated then I suppose this might be also called a bugfix which should be acceptable after the deadline. I do not expect there will be any new version of jQuery or jQuery UI before our freeze. I hope there will not be any changes or problems during MDL-15727 integration, if you have this finished before Tuesday please submit it for integration. The worst case scenario would be to revert everything to current state which would be easy.
          Hide
          Gareth J Barnard added a comment -

          Dear Petr Skoda,

          Thanks - I intend to do a straight like for like as far as possible and leave JQM update etc. for MDL-38318.

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Dear Petr Skoda , Thanks - I intend to do a straight like for like as far as possible and leave JQM update etc. for MDL-38318 . Cheers, Gareth
          Hide
          Petr Skoda added a comment -

          Thanks, please ping me if you need any help or peer review.

          Show
          Petr Skoda added a comment - Thanks, please ping me if you need any help or peer review.
          Hide
          Gareth J Barnard added a comment -

          Thanks and cheers Petr Skoda, peer review would be helpful. I intend to create a master pull branch which can be tested as soon as MDL-15727 as in. Is there a way of having a branch for this with MDL-15727's changes but not have the 15727's changes affect the push?

          Show
          Gareth J Barnard added a comment - Thanks and cheers Petr Skoda , peer review would be helpful. I intend to create a master pull branch which can be tested as soon as MDL-15727 as in. Is there a way of having a branch for this with MDL-15727 's changes but not have the 15727's changes affect the push?
          Hide
          Gareth J Barnard added a comment -

          Note: css cannot be moved to jquery folder as requires css pre-processing for '[[pix|theme:' replacements.

          Show
          Gareth J Barnard added a comment - Note: css cannot be moved to jquery folder as requires css pre-processing for '[[pix|theme:' replacements.
          Hide
          Gareth J Barnard added a comment -
          Show
          Gareth J Barnard added a comment - Note: Test branch until MDL-15727 integrated https://github.com/gjb2048/moodle/tree/wip-MDL-38650_master_with_MDL-15727
          Hide
          Petr Skoda added a comment -

          Submitting for integration, thanks!

          Show
          Petr Skoda added a comment - Submitting for integration, thanks!
          Hide
          Gareth J Barnard added a comment -

          Added Mary Evans as a watcher as to do with themes.

          Show
          Gareth J Barnard added a comment - Added Mary Evans as a watcher as to do with themes.
          Hide
          Mary Evans added a comment -

          Just noting that this should have come through to me first, as Component Lead for themes, as it is to do with making changes to a theme. The fact it is also related to AJAX/JS is secondary, because of the changes themselves. Anyway, thanks Gareth for adding me as a watcher here, otherwise it would have slipped off the theme changes radar.

          Show
          Mary Evans added a comment - Just noting that this should have come through to me first, as Component Lead for themes, as it is to do with making changes to a theme. The fact it is also related to AJAX/JS is secondary, because of the changes themselves. Anyway, thanks Gareth for adding me as a watcher here, otherwise it would have slipped off the theme changes radar.
          Hide
          Mary Evans added a comment -

          @Gareth: What do you mean about CSS cannot be moved to jquery folder? It can as there have been some changes that allow css to be placed in other css directories other than the theme style directory. Or were you referring to a jquery folder in Moodle core?

          Show
          Mary Evans added a comment - @Gareth: What do you mean about CSS cannot be moved to jquery folder? It can as there have been some changes that allow css to be placed in other css directories other than the theme style directory. Or were you referring to a jquery folder in Moodle core?
          Hide
          Gareth J Barnard added a comment -

          Dear Mary Evans

          I do mean the theme's jquery folder and am aware of the other css changes . When I moved it ('jmobile11.css') there and made the appropriate additions to the new jQuery configuration and removed it from the style sheets area of the 'config.php' file, then the file is not pre-processed and the '[[pix|theme:...]]' annotations are not processed, therefore the images are not displayed.

          On another note, I was also concerned about the separation in this case of the styles and therefore the order of import causing possible issues that would take ages to spot.

          But I am aware that the pre-processing could be changed to include the jquery folder, but why add more logic for the sake of a location that makes (in this case) a split and harder for a newbie to understand.

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Dear Mary Evans I do mean the theme's jquery folder and am aware of the other css changes . When I moved it ('jmobile11.css') there and made the appropriate additions to the new jQuery configuration and removed it from the style sheets area of the 'config.php' file, then the file is not pre-processed and the '[ [pix|theme:...] ]' annotations are not processed, therefore the images are not displayed. On another note, I was also concerned about the separation in this case of the styles and therefore the order of import causing possible issues that would take ages to spot. But I am aware that the pre-processing could be changed to include the jquery folder, but why add more logic for the sake of a location that makes (in this case) a split and harder for a newbie to understand. Cheers, Gareth
          Hide
          Petr Skoda added a comment -

          I agree with Gareth, I attempted to use unmodified jquery mobile CSS which is less flexible because the CSS and images are served 'as is' without any image hackery or CSS postprocessing (this would require more additions in the theme CSS), but that is only one of the possibilities. The jQUery mobile CSS and images can be moved to Moodle CSS with image placeholders which may be easier to modify in the future.

          Show
          Petr Skoda added a comment - I agree with Gareth, I attempted to use unmodified jquery mobile CSS which is less flexible because the CSS and images are served 'as is' without any image hackery or CSS postprocessing (this would require more additions in the theme CSS), but that is only one of the possibilities. The jQUery mobile CSS and images can be moved to Moodle CSS with image placeholders which may be easier to modify in the future.
          Hide
          Mary Evans added a comment -

          Ah! I see what you mean.

          Show
          Mary Evans added a comment - Ah! I see what you mean.
          Hide
          Mary Evans added a comment -

          Added links to MDL-38318 and MDL-33934

          Show
          Mary Evans added a comment - Added links to MDL-38318 and MDL-33934
          Hide
          Damyon Wiese added a comment -

          Hi Gareth,

          Shouldn't we be removing "theme/mymobile/javascript/jquery-1.7.1.min.js" in this patch as well?

          Show
          Damyon Wiese added a comment - Hi Gareth, Shouldn't we be removing "theme/mymobile/javascript/jquery-1.7.1.min.js" in this patch as well?
          Hide
          Gareth J Barnard added a comment -

          Dear Damyon Wiese,

          Yes we should! Missed that one, my mistake. I've updated the patch to remove it.

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Dear Damyon Wiese , Yes we should! Missed that one, my mistake. I've updated the patch to remove it. Cheers, Gareth
          Hide
          Damyon Wiese added a comment -

          Thanks Gareth,

          I've integrated this to master now.

          (Yay! Lots of code removed from core!)

          Show
          Damyon Wiese added a comment - Thanks Gareth, I've integrated this to master now. (Yay! Lots of code removed from core!)
          Hide
          Rossiani Wijaya added a comment -

          This is working as expected.

          Test passed.

          Show
          Rossiani Wijaya added a comment - This is working as expected. Test passed.
          Hide
          Mary Evans added a comment -

          Thanks Rosi!

          Big thanks to Gareth and everyone involved in this...brilliant work!

          Cheers
          Mary

          Show
          Mary Evans added a comment - Thanks Rosi! Big thanks to Gareth and everyone involved in this...brilliant work! Cheers Mary
          Hide
          Damyon Wiese added a comment -

          Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

          Show
          Damyon Wiese added a comment - Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: