Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38659

Multiple mistakes in feedback element in environment.xml files

    Details

    • Testing Instructions:
      Hide

      master:

      1) Go to admin->server->environment and verify all checks are shown ok.

      2) Edit admin/environment.xml and change any level = "required" test to have an <ON_CHECK> feedback instead of the correct <ON_ERROR>. The environment page must show "Error reading environment data (16)" for that setting.

      3) Edit admin/environment.xml and change any level = "optional" test to have an <ON_ERROR> feedback instead of the correct <ON_CHECK>. The environment page must show "Error reading environment data (17)" for that setting.

      stable branches:

      1) Go to admin->server->environment and verify all checks are shown ok (for current and future versions).

      Show
      master: 1) Go to admin->server->environment and verify all checks are shown ok. 2) Edit admin/environment.xml and change any level = "required" test to have an <ON_CHECK> feedback instead of the correct <ON_ERROR>. The environment page must show "Error reading environment data (16)" for that setting. 3) Edit admin/environment.xml and change any level = "optional" test to have an <ON_ERROR> feedback instead of the correct <ON_CHECK>. The environment page must show "Error reading environment data (17)" for that setting. stable branches: 1) Go to admin->server->environment and verify all checks are shown ok (for current and future versions).
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      While implementing MDL-37033 I've detected that a lot of <FEEDBACK> elements in the environment.xml are wrong.

      This is not critical, because the test is performed ok and the status is correct, but some interesting messages aren't ever shown.

      Basically, this must be observed always:

      • For "required" level tests, only ON_ERROR and ON_OK messages are allowed (for fails and passes respectively).
      • For "optional" level tests, only ON_CHECK and ON_OK messages are allowed (for fails and passes respectively).

      And there are a bunch of tests not observing those rules.

      So I'm going to create a dtd to be able to, easily verify the xml file for correctness (master only, obviously, although changes to the xml will land to all supported versions).

      Ciao

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    13/May/13