Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5, Future Dev
    • Fix Version/s: 2.5
    • Component/s: AJAX and JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      Generic Notes

      These testing instructions should be carried out twice (once with jsrev = -1, once without) to confirm that the correct versions of JS are used and work as expected.

      Tip: Open your browser's developer toolkit, open the 'Network' activity tab, and restrict to 'Scripts'.

      Note: You may find that the script you're looking for is included with a number of other scripts - this is because of our combo loading.
      You can turn off comboloading to make it easier to check the relevant script by setting

      $CFG->yuicomboloading = false;

      , but you should check that functionality works with combo loading enabled.

      To test the minified code:

      Required settings:

      $CFG->jsrev = -1;
      $CFG->debug = (E_ALL | E_STRICT);
      

      Notes

      Check that the minified version of this module is loaded.
      It will have -min.js in the filename but please ensure content is also be minified

      and to test the non-minified code:

      Required settings:

      $CFG->jsrev = -1;
      $CFG->debug = 0;
      

      Notes

      Check that the non-minified version of this module is loaded.
      It will have -debug.js in the filename and the file content should not be minified.

      Module-specific test instructions

      • Open a course
      • Add a Calendar block
      • Navigate to the Calendar view
      • Create a couple of calendar events
      • Go back to the course page
      • Mouse over the calendar entires you just added
        • Confirm that the calendar entry is shown in an Overlay with the correct data
      Show
      Generic Notes These testing instructions should be carried out twice (once with jsrev = -1, once without) to confirm that the correct versions of JS are used and work as expected. Tip : Open your browser's developer toolkit, open the 'Network' activity tab, and restrict to 'Scripts'. Note : You may find that the script you're looking for is included with a number of other scripts - this is because of our combo loading. You can turn off comboloading to make it easier to check the relevant script by setting $CFG->yuicomboloading = false ; , but you should check that functionality works with combo loading enabled. To test the minified code: Required settings: $CFG->jsrev = -1; $CFG->debug = (E_ALL | E_STRICT); Notes Check that the minified version of this module is loaded. It will have -min.js in the filename but please ensure content is also be minified and to test the non-minified code: Required settings: $CFG->jsrev = -1; $CFG->debug = 0; Notes Check that the non-minified version of this module is loaded. It will have -debug.js in the filename and the file content should not be minified. Module-specific test instructions Open a course Add a Calendar block Navigate to the Calendar view Create a couple of calendar events Go back to the course page Mouse over the calendar entires you just added Confirm that the calendar entry is shown in an Overlay with the correct data
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
    • Rank:
      48715

      Description

      Migrate moodle-calendar-eventmanager to use Shifter

        Issue Links

          Activity

          Hide
          Andrew Nicols added a comment -

          MDl-38667 must be integrated first for the correct styling to be shown in the calendar overlays.

          Show
          Andrew Nicols added a comment - MDl-38667 must be integrated first for the correct styling to be shown in the calendar overlays.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday.

          This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody.

          This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P

          Apologies for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday. This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody. This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P Apologies for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao
          Hide
          Damyon Wiese added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          Thanks!

          Show
          Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, both shifter and jshint say thumbs up. Let's see testing.

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, both shifter and jshint say thumbs up. Let's see testing.
          Hide
          Andrew Davis added a comment - - edited

          The testing instructions are a little cryptic but I think this is working. The only issue I noticed is a problem with transparency. Not sure if that wants fixing in this issue or if its pre-existing.

          https://tracker.moodle.org/secure/attachment/32100/calendar.png
          To be clear, on Friday the 5th I have an event called "Friday Friday gonna get down on Friday." The screenshot shows what happens when you mouse over it.

          Otherwise I think it can be passed.

          Show
          Andrew Davis added a comment - - edited The testing instructions are a little cryptic but I think this is working. The only issue I noticed is a problem with transparency. Not sure if that wants fixing in this issue or if its pre-existing. https://tracker.moodle.org/secure/attachment/32100/calendar.png To be clear, on Friday the 5th I have an event called "Friday Friday gonna get down on Friday." The screenshot shows what happens when you mouse over it. Otherwise I think it can be passed.
          Hide
          Andrew Nicols added a comment -

          Thanks Andrew,

          It looks like this is a bug in MDL-38667, or arguably the moodleConfigFn whereby it is trying to use a css -min file when none is present.
          Fixing this for MDL-38667 makes the calendar style download and this looks correct so safe to pass this test.

          Andrew

          Show
          Andrew Nicols added a comment - Thanks Andrew, It looks like this is a bug in MDL-38667 , or arguably the moodleConfigFn whereby it is trying to use a css -min file when none is present. Fixing this for MDL-38667 makes the calendar style download and this looks correct so safe to pass this test. Andrew
          Hide
          Andrew Davis added a comment -

          Passing.

          Show
          Andrew Davis added a comment - Passing.
          Hide
          Andrew Davis added a comment -

          I somehow accidentally assigned this to myself yesterday. Assigning it back to Andrew Nicols.

          Show
          Andrew Davis added a comment - I somehow accidentally assigned this to myself yesterday. Assigning it back to Andrew Nicols.
          Hide
          Dan Poltawski added a comment -

          Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

          line 1289 of \lib\changes.php: call to debugging()
          line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
          line 202 of \lib\now.php: call to moodleform->_is_poor_form()
          line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

          Show
          Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: