Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      Generic Notes

      These testing instructions should be carried out twice (once with jsrev = -1, once without) to confirm that the correct versions of JS are used and work as expected.

      Tip: Open your browser's developer toolkit, open the 'Network' activity tab, and restrict to 'Scripts'.

      Note: You may find that the script you're looking for is included with a number of other scripts - this is because of our combo loading.
      You can turn off comboloading to make it easier to check the relevant script by setting

      $CFG->yuicomboloading = false;

      , but you should check that functionality works with combo loading enabled.

      To test the minified code:

      Required settings:

      unset($CFG->jsrev);
      $CFG->debug = 0;
      

      Notes

      Check that the minified version of this module is loaded.
      It will have -min.js in the filename but please ensure content is also be minified

      and to test the non-minified code:

      Required settings:

      $CFG->jsrev = -1;
      $CFG->debug = (E_ALL | E_STRICT);
      

      Notes

      Check that the non-minified version of this module is loaded.
      It will have -debug.js in the filename and the file content should not be minified.

      Module-specific test instructions

      • Enable the glossary auto linking filter for the site
      • Create a new glossary capable of auto-linking
      • Create some terms in that glossary and make them auto-linkable
      • Modify the section text for a section of the course to include some of the new terms
      • View the page
        • Confirm that the words were highlighted correctly
        • Confirm that mousing over them shows alt text
        • Confirm that clicking on them opens up the glossary definition popup
      Show
      Generic Notes These testing instructions should be carried out twice (once with jsrev = -1, once without) to confirm that the correct versions of JS are used and work as expected. Tip : Open your browser's developer toolkit, open the 'Network' activity tab, and restrict to 'Scripts'. Note : You may find that the script you're looking for is included with a number of other scripts - this is because of our combo loading. You can turn off comboloading to make it easier to check the relevant script by setting $CFG->yuicomboloading = false; , but you should check that functionality works with combo loading enabled. To test the minified code: Required settings: unset($CFG->jsrev); $CFG->debug = 0; Notes Check that the minified version of this module is loaded. It will have -min.js in the filename but please ensure content is also be minified and to test the non-minified code: Required settings: $CFG->jsrev = -1; $CFG->debug = (E_ALL | E_STRICT); Notes Check that the non-minified version of this module is loaded. It will have -debug.js in the filename and the file content should not be minified. Module-specific test instructions Enable the glossary auto linking filter for the site Create a new glossary capable of auto-linking Create some terms in that glossary and make them auto-linkable Modify the section text for a section of the course to include some of the new terms View the page Confirm that the words were highlighted correctly Confirm that mousing over them shows alt text Confirm that clicking on them opens up the glossary definition popup
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:

      Description

      Migrate moodle-filter_glossary-autolink to use Shifter

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            damyon Damyon Wiese added a comment -

            Thanks Andrew this has been integrated to master.

            As an aside - I wonder if there is away to get jshint to ignore the minified js automatically (haven't looked).

            Show
            damyon Damyon Wiese added a comment - Thanks Andrew this has been integrated to master. As an aside - I wonder if there is away to get jshint to ignore the minified js automatically (haven't looked).
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Failing this as am getting min.js when debug.js is expected and vise-versa. Incase this was just a typo in the testing instructions, this issue can be passed as everything else works as described.
            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - Failing this as am getting min.js when debug.js is expected and vise-versa. Incase this was just a typo in the testing instructions, this issue can be passed as everything else works as described. Thanks
            Hide
            dobedobedoh Andrew Nicols added a comment -

            Okay - yes. I have screwed up the testing instructions.

            I'll correct in the parent bug (there are 9 identical).

            Show
            dobedobedoh Andrew Nicols added a comment - Okay - yes. I have screwed up the testing instructions. I'll correct in the parent bug (there are 9 identical).
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            sent back to testing, instructions look ok now...

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - sent back to testing, instructions look ok now...
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Passing as now the instructions have been updated.
            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - Passing as now the instructions have been updated. Thanks
            Hide
            damyon Damyon Wiese added a comment -

            Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

            Show
            damyon Damyon Wiese added a comment - Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13