Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38682

Warning when configuring Navigation block from non-course and non-frontpage page

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Navigation
    • Labels:
    • Testing Instructions:
      Hide
      1. Add block to pages /course/index.php (both top-level and category-level), /course/search.php, /course/manage.php
      2. Make sure you can configure those blocks without errors
      3. Try to change "Where this block appears", make sure it works
      Show
      Add block to pages /course/index.php (both top-level and category-level), /course/search.php, /course/manage.php Make sure you can configure those blocks without errors Try to change "Where this block appears", make sure it works
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      wip-MDL-38682-master

      Description

      To replicate:

      1. Open /course/index.php or course category view page
      2. Siwtch editing mode on
      3. Click 'Configure Navigation block'

      The warning appears:

      Notice: Trying to get property of non-object in /home/marina/repositories/courserenderers/moodle/course/lib.php on line 3691
       
      Call Stack:
          0.0005     679112   1. {main}() /home/marina/repositories/courserenderers/moodle/course/index.php:0
          0.1253   41756344   2. core_renderer->header() /home/marina/repositories/courserenderers/moodle/course/index.php:56
          0.1253   41756424   3. moodle_page->set_state() /home/marina/repositories/courserenderers/moodle/lib/outputrenderers.php:760
          0.1253   41756424   4. moodle_page->starting_output() /home/marina/repositories/courserenderers/moodle/lib/pagelib.php:829
          0.1262   41771912   5. block_manager->process_url_actions() /home/marina/repositories/courserenderers/moodle/lib/pagelib.php:1380
          0.1263   41771992   6. block_manager->process_url_edit() /home/marina/repositories/courserenderers/moodle/lib/blocklib.php:1102
          0.1314   42645960   7. block_edit_form->__construct() /home/marina/repositories/courserenderers/moodle/lib/blocklib.php:1306
          0.1314   42645960   8. moodleform->moodleform() /home/marina/repositories/courserenderers/moodle/blocks/edit_form.php:59
          0.1326   42673496   9. block_edit_form->definition() /home/marina/repositories/courserenderers/moodle/lib/formslib.php:191
          0.1443   43525352  10. generate_page_type_patterns() /home/marina/repositories/courserenderers/moodle/blocks/edit_form.php:151
          0.1446   43550704  11. course_page_type_list() /home/marina/repositories/courserenderers/moodle/lib/blocklib.php:1718
      

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13