Moodle
  1. Moodle
  2. MDL-38012 META: Simplify moodle forms
  3. MDL-38691

Move the "Show more..." link more to the right so it's not interrupting the flow of form elements.

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Forms Library
    • Labels:

      Gliffy Diagrams

        Activity

        Hide
        Martin Dougiamas added a comment -

        Adding a screenshot as it is now.

        That link should at least be under the elements, not the labels.

        Show
        Martin Dougiamas added a comment - Adding a screenshot as it is now. That link should at least be under the elements, not the labels.
        Hide
        Tim Hunt added a comment -

        I like Show more where it is. At least, there are many more important things to tidy up about forms before 2.5.

        Show
        Tim Hunt added a comment - I like Show more where it is. At least, there are many more important things to tidy up about forms before 2.5.
        Hide
        Michael de Raadt added a comment -

        Fred raised a good point that the current position of the "Show more..." link implies advanced elements will appear at the bottom of the fieldset (which they do not). I still prefer the current text to "Show advanced...", but perhaps we need to reconsider putting it in the line of form elements and stick it back in the top-right of the fieldset.

        The other consideration is whether we need advanced settings at all, now that we are hiding content in collapsed sections... but that's a separate debate.

        Show
        Michael de Raadt added a comment - Fred raised a good point that the current position of the "Show more..." link implies advanced elements will appear at the bottom of the fieldset (which they do not). I still prefer the current text to "Show advanced...", but perhaps we need to reconsider putting it in the line of form elements and stick it back in the top-right of the fieldset. The other consideration is whether we need advanced settings at all, now that we are hiding content in collapsed sections... but that's a separate debate.
        Hide
        Martin Dougiamas added a comment -

        Given that it's new, and moving the link is pretty easy, I think it's worth doing now before it gets out. To me, it really looks jammed in where it is.

        The top corner would be OK but is perhaps less obvious on wide screens. Just under the elements seems to be a good compromise.

        Show
        Martin Dougiamas added a comment - Given that it's new, and moving the link is pretty easy, I think it's worth doing now before it gets out. To me, it really looks jammed in where it is. The top corner would be OK but is perhaps less obvious on wide screens. Just under the elements seems to be a good compromise.
        Hide
        Frédéric Massart added a comment -

        Here is a proposed solution.

        User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:18.0) Gecko/20100101 Firefox/18.0

        Show
        Frédéric Massart added a comment - Here is a proposed solution. User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:18.0) Gecko/20100101 Firefox/18.0
        Hide
        Frédéric Massart added a comment -

        I personally think that we're not using it right, and that it's not very user friendly that some settings appear randomely in the section. Also, I think that the advanced fields should be added after the link itself. Perhaps part of another issue, another day.

        Show
        Frédéric Massart added a comment - I personally think that we're not using it right, and that it's not very user friendly that some settings appear randomely in the section. Also, I think that the advanced fields should be added after the link itself. Perhaps part of another issue, another day.
        Hide
        Martin Dougiamas added a comment -

        That looks fine to me. +1

        Show
        Martin Dougiamas added a comment - That looks fine to me. +1
        Hide
        Damyon Wiese added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        Thanks!

        Show
        Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
        Hide
        Dan Poltawski added a comment -

        Integrated to master, thanks.

        [Note that this seems to not be working with the bootstrap theme, I didn't investigate why this is]

        Show
        Dan Poltawski added a comment - Integrated to master, thanks. [Note that this seems to not be working with the bootstrap theme, I didn't investigate why this is]
        Hide
        David Monllaó added a comment -

        This style change is breaking the behat tests, it could be good to run the behat suite when doing this kind of base changes, adding commit on top of integration with the required changes:

        git pull git://github.com/dmonllao/moodle.git MDL-38691_master-fix-behat

        Show
        David Monllaó added a comment - This style change is breaking the behat tests, it could be good to run the behat suite when doing this kind of base changes, adding commit on top of integration with the required changes: git pull git://github.com/dmonllao/moodle.git MDL-38691 _master-fix-behat
        Hide
        Dan Poltawski added a comment -

        Integrated the fix, thanks David.

        Show
        Dan Poltawski added a comment - Integrated the fix, thanks David.
        Hide
        Andrew Davis added a comment -

        Works as described. Passing.

        Show
        Andrew Davis added a comment - Works as described. Passing.
        Hide
        Dan Poltawski added a comment -

        Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

        line 1289 of \lib\changes.php: call to debugging()
        line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
        line 202 of \lib\now.php: call to moodleform->_is_poor_form()
        line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

        Show
        Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: