Moodle
  1. Moodle
  2. MDL-38702

CSS Optimizer does not work with mymobile theme.

    Details

    • Testing Instructions:
      Hide
      1. Log in as an administrator
      2. Enable the CSS optimiser (Devlopment > Experimental > Experimental settings)
      3. Enable URL theme change (Appearance > Themes > Theme settings)
      4. Browse to a course front page using anything but the mymobile theme.
      5. Use Firebug or similar to get the URL for any core CSS file and open it in a new tab.
      6. Check that it has been optimised (likely on minimal lines)
      7. Change your theme to the MyMobile theme on URL &theme=mymobile
      8. Use Firebug again to get the same URL (it will have changed now I in most cases) and open it in a new tab.
      9. Check that the CSS is not optimised (several+ lines)
      Show
      Log in as an administrator Enable the CSS optimiser (Devlopment > Experimental > Experimental settings) Enable URL theme change (Appearance > Themes > Theme settings) Browse to a course front page using anything but the mymobile theme. Use Firebug or similar to get the URL for any core CSS file and open it in a new tab. Check that it has been optimised (likely on minimal lines) Change your theme to the MyMobile theme on URL &theme=mymobile Use Firebug again to get the same URL (it will have changed now I in most cases) and open it in a new tab. Check that the CSS is not optimised (several+ lines)
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull 2.4 Branch:
      MDL-38702_M24
    • Pull Master Branch:
      MDL-38702_master
    • Rank:
      48751

      Description

      Issue: When the CSS optimizer is turned on the mymobile theme login page has no images on buttons and login button does not work

      Steps:
      -Go to http://SITE/admin/settings.php?section=experimentalsettings
      -Turn on (check) CSS optimizer option
      -Save
      -Go to the Theme Selector and select the MyMobile theme for mobile devices
      -Save
      -Go to site on a mobile device
      -Click the login button
      -Try to login
      -Login button does not do anything when pressed
      -Icons are also missing images as displayed by the empty circles

      Expected behavior: login page should work fine

        Issue Links

          Activity

          Hide
          Chris Follin added a comment -

          Appears related to MDL-33596, which is already closed. Our staff ran through the testing instructions of 33596 and found that those steps still check out okay. However, users can't log in when the CSS Optimizer is on and the theme is MyMobile.

          Show
          Chris Follin added a comment - Appears related to MDL-33596 , which is already closed. Our staff ran through the testing instructions of 33596 and found that those steps still check out okay. However, users can't log in when the CSS Optimizer is on and the theme is MyMobile.
          Hide
          Mary Evans added a comment -

          Hi Chris,

          It states quite clearly in MDL-33596 that the MyMobile theme breaks when the CSS Optimiser is enabled, that is why that theme has a setting in theme/mymobile/config.php which disables the Optimiser.

          Here is the setting which was added in the commit to fix the bug in MDL-33596.

          https://github.com/moodle/moodle/commit/b305d623a58f99a83da625a895b1fff96466f11e#L1L771

          Show
          Mary Evans added a comment - Hi Chris, It states quite clearly in MDL-33596 that the MyMobile theme breaks when the CSS Optimiser is enabled, that is why that theme has a setting in theme/mymobile/config.php which disables the Optimiser. Here is the setting which was added in the commit to fix the bug in MDL-33596 . https://github.com/moodle/moodle/commit/b305d623a58f99a83da625a895b1fff96466f11e#L1L771
          Hide
          Mary Evans added a comment -

          Hi Chris,

          Further to my last comment.

          Just searching through the archives for the MyMobile theme, and found that the setting in MyMobile to disable the CSS Optimiser had been deleted in another bug fixing commit, and so this is a serious regression.

          Thanks for reporting this issue, as it would never have come to light otherwise!

          Cheers
          Mary

          Show
          Mary Evans added a comment - Hi Chris, Further to my last comment. Just searching through the archives for the MyMobile theme, and found that the setting in MyMobile to disable the CSS Optimiser had been deleted in another bug fixing commit, and so this is a serious regression. Thanks for reporting this issue, as it would never have come to light otherwise! Cheers Mary
          Hide
          Mary Evans added a comment -
          Show
          Mary Evans added a comment - Beginning work to rectify a regression caused by MDL-33357 at line 171 https://github.com/moodle/moodle/commit/256c51fab0eb3a28f01672add3422c1c3fb89fea#L0L171
          Hide
          Chris Follin added a comment -

          Hi Mary,

          Thanks for jumping on this so quickly. We and our clients appreciate it.

          Show
          Chris Follin added a comment - Hi Mary, Thanks for jumping on this so quickly. We and our clients appreciate it.
          Hide
          Mary Evans added a comment -

          Hi Chris, with luck it should be fixed this coming weekend.

          Show
          Mary Evans added a comment - Hi Chris, with luck it should be fixed this coming weekend.
          Hide
          Damyon Wiese added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          Thanks!

          Show
          Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
          Hide
          Mary Evans added a comment -

          REBASED ALL BRANCHES

          Show
          Mary Evans added a comment - REBASED ALL BRANCHES
          Hide
          Dan Poltawski added a comment -

          Integrated to master, 24 and 23 thanks!

          Show
          Dan Poltawski added a comment - Integrated to master, 24 and 23 thanks!
          Hide
          Ankit Agarwal added a comment -

          Works as described, css was not optimised for mymobile theme and was optimised for standard.
          Passing thanks

          Show
          Ankit Agarwal added a comment - Works as described, css was not optimised for mymobile theme and was optimised for standard. Passing thanks
          Hide
          Dan Poltawski added a comment -

          Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

          line 1289 of \lib\changes.php: call to debugging()
          line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
          line 202 of \lib\now.php: call to moodleform->_is_poor_form()
          line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

          Show
          Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()
          Hide
          Mary Evans added a comment -

          Thanks everyone!

          Show
          Mary Evans added a comment - Thanks everyone!

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: