Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38705

Blackboard QTI-format question import should treat each assessment file as a separate category

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Questions
    • Labels:
    • Testing Instructions:
      Hide
      1. Import the bb-test2.zip sample as Blackboard format into a course ensuring the "Get category from file" option is selected and the "Import category" is "Default for Course Name Here".
      2. Go to Course administration > Question bank > Categories.
      3. Observe that two categories have been created under "Default for Course Name Here": "res00006 title" and "res00007 title".
      4. Go to Course administration > Question bank > Questions.
      5. Select the "res00006 title" category and observe that two new questions named "res00006 q1" and "res00006 q2" have been imported.
      6. Select the "res00007 title" category and observe that two new questions named "res00007 q1" and "res00007 q2" have been imported.
      Show
      Import the bb-test2.zip sample as Blackboard format into a course ensuring the "Get category from file" option is selected and the "Import category" is "Default for Course Name Here ". Go to Course administration > Question bank > Categories. Observe that two categories have been created under "Default for Course Name Here ": "res00006 title" and "res00007 title". Go to Course administration > Question bank > Questions. Select the "res00006 title" category and observe that two new questions named "res00006 q1" and "res00006 q2" have been imported. Select the "res00007 title" category and observe that two new questions named "res00007 q1" and "res00007 q2" have been imported.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Like with MDL-38390, for Blackboard 6+ ZIP files having multiple QTI assessments within, currently all questions get imported into the one category. This patch interprets each assessment's title as a category name for importing. The existing behaviour of importing into the one category can still be achieved by disabling the "Get category from file" import option.
      Attached example ZIP has two pools each with two questions to demonstrate.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            timhunt Tim Hunt added a comment -

            I guess this is ready for peer review now? Jean-Michel, would you do the honours? Thanks.

            Show
            timhunt Tim Hunt added a comment - I guess this is ready for peer review now? Jean-Michel, would you do the honours? Thanks.
            Hide
            jmvedrine Jean-Michel Vedrine added a comment -

            Hello Jonathon,
            Starting peer review. As this is quite similar to your work on pool files, should be easy to review;

            Show
            jmvedrine Jean-Michel Vedrine added a comment - Hello Jonathon, Starting peer review. As this is quite similar to your work on pool files, should be easy to review;
            Hide
            jmvedrine Jean-Michel Vedrine added a comment - - edited

            Hi Jonathon and Tim,
            Only problem is some whitespaces on line 885 of question/format/blackboard_six/formatqti.php
            Code looks good, works exactly as expected and phpunit tests passed.
            [Y] Syntax
            [-] Output
            [N] Whitespace
            [Y] Language
            [-] Databases
            [Y] Testing
            [-] Security
            [Y] Documentation
            [Y] Git
            [Y] Sanity check
            Once the whitespace problem is fixed, my +1 to send to integration.

            Show
            jmvedrine Jean-Michel Vedrine added a comment - - edited Hi Jonathon and Tim, Only problem is some whitespaces on line 885 of question/format/blackboard_six/formatqti.php Code looks good, works exactly as expected and phpunit tests passed. [Y] Syntax [-] Output [N] Whitespace [Y] Language [-] Databases [Y] Testing [-] Security [Y] Documentation [Y] Git [Y] Sanity check Once the whitespace problem is fixed, my +1 to send to integration.
            Hide
            timhunt Tim Hunt added a comment -

            Thanks Jean-Michel. Jonathan, Moodle 2.5 code-freeze is Monday (or possibly Tuesday given the public holiday). If you can clean up the white-space in time, we can get this submitted. Thanks.

            Show
            timhunt Tim Hunt added a comment - Thanks Jean-Michel. Jonathan, Moodle 2.5 code-freeze is Monday (or possibly Tuesday given the public holiday). If you can clean up the white-space in time, we can get this submitted. Thanks.
            Hide
            jonof Jonathon Fowler added a comment -

            Whitespace is now fixed. Thanks guys.

            Show
            jonof Jonathon Fowler added a comment - Whitespace is now fixed. Thanks guys.
            Hide
            jmvedrine Jean-Michel Vedrine added a comment -

            Hello Tim,
            I think this is now ready for integration, just in time I hope. Can you submit it, please ?

            Show
            jmvedrine Jean-Michel Vedrine added a comment - Hello Tim, I think this is now ready for integration, just in time I hope. Can you submit it, please ?
            Hide
            timhunt Tim Hunt added a comment -

            Thanks, submitting for integration.

            Show
            timhunt Tim Hunt added a comment - Thanks, submitting for integration.
            Hide
            damyon Damyon Wiese added a comment -

            Thanks again - this change also looks good and has more lovely tests.

            Integrated to master only.

            Show
            damyon Damyon Wiese added a comment - Thanks again - this change also looks good and has more lovely tests. Integrated to master only.
            Hide
            phalacee Jason Fowler added a comment -

            Worked perfectly Jonathon. Thanks

            Show
            phalacee Jason Fowler added a comment - Worked perfectly Jonathon. Thanks
            Hide
            poltawski Dan Poltawski added a comment -

            Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

            line 1289 of \lib\changes.php: call to debugging()
            line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
            line 202 of \lib\now.php: call to moodleform->_is_poor_form()
            line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

            Show
            poltawski Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13