Moodle
  1. Moodle
  2. MDL-34311 Improve debugging when using default cleaning
  3. MDL-38711

Multianswer question form not calling setType on hidden input "confirm"

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Questions
    • Labels:
    • Rank:
      48761

      Description

      question/type/multianswer/edit_multianswer_form.php line 253

        Issue Links

          Activity

          Hide
          Dan Poltawski added a comment -

          Put a quick fix for this, requesting review.

          Show
          Dan Poltawski added a comment - Put a quick fix for this, requesting review.
          Hide
          Tim Hunt added a comment -

          +1 Thanks Dan.

          Show
          Tim Hunt added a comment - +1 Thanks Dan.
          Hide
          Dan Poltawski added a comment -

          The question of backporting this (and all the rest of the missing param type changes) is probably something the integrators need to decide tactics on. If we decide to backport these changes immediately - this can be cherry-picked.

          Show
          Dan Poltawski added a comment - The question of backporting this (and all the rest of the missing param type changes) is probably something the integrators need to decide tactics on. If we decide to backport these changes immediately - this can be cherry-picked.
          Hide
          Damyon Wiese added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          Thanks!

          Show
          Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
          Hide
          Damyon Wiese added a comment -

          Thanks Dan, this has been integrated to master.

          Show
          Damyon Wiese added a comment - Thanks Dan, this has been integrated to master.
          Hide
          Andrew Davis added a comment -

          Works as described. Passing.

          Show
          Andrew Davis added a comment - Works as described. Passing.
          Hide
          Dan Poltawski added a comment -

          Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

          line 1289 of \lib\changes.php: call to debugging()
          line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
          line 202 of \lib\now.php: call to moodleform->_is_poor_form()
          line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

          Show
          Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: