Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34311 Improve debugging when using default cleaning
  3. MDL-38711

Multianswer question form not calling setType on hidden input "confirm"

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Questions
    • Labels:

      Description

      question/type/multianswer/edit_multianswer_form.php line 253

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            poltawski Dan Poltawski added a comment -

            Put a quick fix for this, requesting review.

            Show
            poltawski Dan Poltawski added a comment - Put a quick fix for this, requesting review.
            Hide
            timhunt Tim Hunt added a comment -

            +1 Thanks Dan.

            Show
            timhunt Tim Hunt added a comment - +1 Thanks Dan.
            Hide
            poltawski Dan Poltawski added a comment -

            The question of backporting this (and all the rest of the missing param type changes) is probably something the integrators need to decide tactics on. If we decide to backport these changes immediately - this can be cherry-picked.

            Show
            poltawski Dan Poltawski added a comment - The question of backporting this (and all the rest of the missing param type changes) is probably something the integrators need to decide tactics on. If we decide to backport these changes immediately - this can be cherry-picked.
            Hide
            damyon Damyon Wiese added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            Thanks!

            Show
            damyon Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
            Hide
            damyon Damyon Wiese added a comment -

            Thanks Dan, this has been integrated to master.

            Show
            damyon Damyon Wiese added a comment - Thanks Dan, this has been integrated to master.
            Hide
            andyjdavis Andrew Davis added a comment -

            Works as described. Passing.

            Show
            andyjdavis Andrew Davis added a comment - Works as described. Passing.
            Hide
            poltawski Dan Poltawski added a comment -

            Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

            line 1289 of \lib\changes.php: call to debugging()
            line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
            line 202 of \lib\now.php: call to moodleform->_is_poor_form()
            line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

            Show
            poltawski Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13