[MDL-38713] When adding a course module and setting the visibility using the form visibleold is set incorrectly - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

Create a new url, setting its visibility to hidden in the form

Save and return to course.

Move item to a non-hidden section

VERIFY: the course module stays hidden

Create a new url, setting its visibility to hidden in the form

VERIFY: in the database that the course_module record for that resource has the visibleold setting is set to 0
Show
Create a new url, setting its visibility to hidden in the form Save and return to course. Move item to a non-hidden section VERIFY: the course module stays hidden Create a new url, setting its visibility to hidden in the form VERIFY: in the database that the course_module record for that resource has the visibleold setting is set to 0
Affected Branches:
MOODLE_24_STABLE
Fixed Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE
Pull from Repository:
git://github.com/danpoltawski/moodle.git
Pull Master Branch:
~~MDL-38713~~-master
Pull Master Diff URL:
https://github.com/danpoltawski/moodle/compare/373a8e052c6a6d02e1f781312d16c82d8f12ee0e...MDL-38713-master

Expected: visibleold and visible should both be 0

Actual: visibleold is set to 1.

has a non-specific relationship to

MDL-38703 Moving a hidden item to visible section sets the item to visible in 2.3

Testing discovered

MDL-38700 Duplicating a hidden resource can cause both to become unhidden

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)