Moodle
  1. Moodle
  2. MDL-38713

When adding a course module and setting the visibility using the form visibleold is set incorrectly

    Details

    • Testing Instructions:
      Hide
      1. Create a new url, setting its visibility to hidden in the form
      2. Save and return to course.
      3. Move item to a non-hidden section
      4. VERIFY: the course module stays hidden
      5. Create a new url, setting its visibility to hidden in the form
      6. VERIFY: in the database that the course_module record for that resource has the visibleold setting is set to 0
      Show
      Create a new url, setting its visibility to hidden in the form Save and return to course. Move item to a non-hidden section VERIFY: the course module stays hidden Create a new url, setting its visibility to hidden in the form VERIFY: in the database that the course_module record for that resource has the visibleold setting is set to 0
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-38713-master

      Description

      1. Create a new course module, setting its visibility to hidden in the form
      2. Check the visible and visibleold values in the db

      Expected: visibleold and visible should both be 0

      Actual: visibleold is set to 1.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Dan Poltawski added a comment - - edited

            Note to integrator and reviewer, this is also related to the mess uncovered in: MDL-38700 and MDL-38703.

            I removed the set_field() call because its all handled in set_coursemodule_visible().

            Show
            Dan Poltawski added a comment - - edited Note to integrator and reviewer, this is also related to the mess uncovered in: MDL-38700 and MDL-38703 . I removed the set_field() call because its all handled in set_coursemodule_visible().
            Hide
            Damyon Wiese added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            Thanks!

            Show
            Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
            Hide
            Willy Lee added a comment -

            We've run the tests here at Carleton and they pass.

            Show
            Willy Lee added a comment - We've run the tests here at Carleton and they pass.
            Hide
            Damyon Wiese added a comment -

            Thanks Dan I tested/reviewed MDL-38700, MDL-38703 and MDL-38713 together and they have all been integrated now.

            Show
            Damyon Wiese added a comment - Thanks Dan I tested/reviewed MDL-38700 , MDL-38703 and MDL-38713 together and they have all been integrated now.
            Hide
            Rossiani Wijaya added a comment -

            This is working as expected.

            Tested for 2.3, 2.4 and master

            Test passed.

            Show
            Rossiani Wijaya added a comment - This is working as expected. Tested for 2.3, 2.4 and master Test passed.
            Hide
            Dan Poltawski added a comment -

            Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

            line 1289 of \lib\changes.php: call to debugging()
            line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
            line 202 of \lib\now.php: call to moodleform->_is_poor_form()
            line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

            Show
            Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

              People

              • Votes:
                8 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: