Moodle

When adding a course module and setting the visibility using the form visibleold is set incorrectly

Details

Description

  1. Create a new course module, setting its visibility to hidden in the form
  2. Check the visible and visibleold values in the db

Expected: visibleold and visible should both be 0

Actual: visibleold is set to 1.

Issue Links

discovered while testing

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-38700 Duplicating a hidden resource can cause both to become unhidden

  • Major - Major loss of function, incorrect output
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.
has a non-specific relationship to

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-38703 Moving a hidden item to visible section sets the item to visible in 2.3

  • Major - Major loss of function, incorrect output
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dan Poltawski added a comment - - edited

Note to integrator and reviewer, this is also related to the mess uncovered in: MDL-38700 and MDL-38703.

I removed the set_field() call because its all handled in set_coursemodule_visible().

Show
Dan Poltawski added a comment - - edited Note to integrator and reviewer, this is also related to the mess uncovered in: MDL-38700 and MDL-38703 . I removed the set_field() call because its all handled in set_coursemodule_visible().
Hide
Permalink
Damyon Wiese added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

Thanks!

Show
Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
Hide
Permalink
Willy Lee added a comment -

We've run the tests here at Carleton and they pass.

Show
Willy Lee added a comment - We've run the tests here at Carleton and they pass.
Hide
Permalink
Damyon Wiese added a comment -

Thanks Dan I tested/reviewed MDL-38700, MDL-38703 and MDL-38713 together and they have all been integrated now.

Show
Damyon Wiese added a comment - Thanks Dan I tested/reviewed MDL-38700 , MDL-38703 and MDL-38713 together and they have all been integrated now.
Hide
Permalink
Rossiani Wijaya added a comment -

This is working as expected.

Tested for 2.3, 2.4 and master

Test passed.

Show
Rossiani Wijaya added a comment - This is working as expected. Tested for 2.3, 2.4 and master Test passed.
Hide
Permalink
Dan Poltawski added a comment -

Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

line 1289 of \lib\changes.php: call to debugging()
line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
line 202 of \lib\now.php: call to moodleform->_is_poor_form()
line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

Show
Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

People

Vote (8)
Watch (7)

Dates

  • Created:
    Updated:
    Resolved: