Lesson edit page not calling setType for hidden and text inputs

Details

Type: Sub-task
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 2.5
Fix Version/s: 2.5
Component/s: Lesson
Labels:
- triaged

Testing Instructions:
Hide

Set debugger to 'developer'

Create new lesson

Enable 'Allow student review"

Add a matching question

Add a multiple choices question

Edit the existing questions

Attempt the lesson as student

Review the lesson

Make sure there is no warning for setType() through out the above process.
Show
Set debugger to 'developer' Create new lesson Enable 'Allow student review" Add a matching question Add a multiple choices question Edit the existing questions Attempt the lesson as student Review the lesson Make sure there is no warning for setType() through out the above process.
Affected Branches:
MOODLE_25_STABLE
Fixed Branches:
MOODLE_25_STABLE
Pull from Repository:
git://github.com/rwijaya/moodle.git
Pull Master Branch:
~~MDL-38714~~_tmp
Pull Master Diff URL:
https://github.com/rwijaya/moodle/compare/moodle:master...MDL-38714_tmp

Description

This now triggers debugging messages since ~~MDL-34311~~.

Did you remember to call setType() for 'edit'? Defaulting to PARAM_RAW cleaning.
line 1266 of /lib/formslib.php: call to debugging()
line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
line 202 of /lib/formslib.php: call to moodleform->_process_submission()
line 44 of /mod/lesson/editpage_form.php: call to moodleform->moodleform()
line 2734 of /mod/lesson/locallib.php: call to lesson_add_page_form_selection->__construct()
line 69 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form()
Did you remember to call setType() for 'score[0]'? Defaulting to PARAM_RAW cleaning.
line 1266 of /lib/formslib.php: call to debugging()
line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
line 202 of /lib/formslib.php: call to moodleform->_process_submission()
line 2734 of /mod/lesson/locallib.php: call to moodleform->moodleform()
line 76 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form()
Did you remember to call setType() for 'score[1]'? Defaulting to PARAM_RAW cleaning.

Issue Links

blocks

MDLQA-5550 CLONE - File picker can be used to add a Pop-up to file or web page in a lesson.

discovered while testing

MDL-37639 Not selecting a matching answer in the Lesson module causes PHP notice.

is duplicated by

MDL-38986 Error notice Did you remember to call setType() for 'score'?

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Frédéric Massart added a comment - 27/Mar/13 3:44 AM

Also found that when adding some questions some messages are displayed too

Did you remember to call setType() for 'score'? Defaulting to PARAM_RAW cleaning.
line 1275 of /lib/formslib.php: call to debugging()
line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
line 202 of /lib/formslib.php: call to moodleform->_process_submission()
line 2734 of /mod/lesson/locallib.php: call to moodleform->moodleform()
line 76 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form()

Did you remember to call setType() for 'score'? Defaulting to PARAM_RAW cleaning.
line 1275 of /lib/formslib.php: call to debugging()
line 919 of /lib/formslib.php: call to moodleform->detectMissingSetType()
line 129 of /mod/lesson/editpage.php: call to moodleform->display()

Show

Frédéric Massart added a comment - 27/Mar/13 3:44 AM Also found that when adding some questions some messages are displayed too Did you remember to call setType() for 'score'? Defaulting to PARAM_RAW cleaning. line 1275 of /lib/formslib.php: call to debugging() line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType() line 202 of /lib/formslib.php: call to moodleform->_process_submission() line 2734 of /mod/lesson/locallib.php: call to moodleform->moodleform() line 76 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form() Did you remember to call setType() for 'score'? Defaulting to PARAM_RAW cleaning. line 1275 of /lib/formslib.php: call to debugging() line 919 of /lib/formslib.php: call to moodleform->detectMissingSetType() line 129 of /mod/lesson/editpage.php: call to moodleform->display()

Hide

Permalink

Ankit Agarwal added a comment - 03/Apr/13 6:16 AM

Hi Rosie,
As discussed in dev chat

$this->_form->setType('response_editor', PARAM_TEXT);

should be

$this->_form->setType('response_editor['.$count.]', PARAM_TEXT);

similarly it should be done for score as well.
Rest looks good. I didn't find any orphan text,hidden and url elements in lesson
Thanks

Show

Ankit Agarwal added a comment - 03/Apr/13 6:16 AM Hi Rosie, As discussed in dev chat $ this ->_form->setType('response_editor', PARAM_TEXT); should be $ this ->_form->setType('response_editor['.$count.]', PARAM_TEXT); similarly it should be done for score as well. Rest looks good. I didn't find any orphan text,hidden and url elements in lesson Thanks

Hide

Permalink

Dan Poltawski added a comment - 04/Apr/13 4:28 AM

I've opened MDL-38885 for that [] problem.

Show

Dan Poltawski added a comment - 04/Apr/13 4:28 AM I've opened MDL-38885 for that [] problem.

Hide

Permalink

Rossiani Wijaya added a comment - 05/Apr/13 3:25 AM

Waiting on the decision for MDL-38885 in order to fix this properly.

The above patch is based on the current patch available for MDL-38885.

Show

Rossiani Wijaya added a comment - 05/Apr/13 3:25 AM Waiting on the decision for MDL-38885 in order to fix this properly. The above patch is based on the current patch available for MDL-38885.

Hide

Permalink

David Monllaó added a comment - 14/Apr/13 6:49 AM

Adding more debugging messages, they appear when filling a new numerical question, haven't checked other questions:

Did you remember to call setType() for 'edit'? Defaulting to PARAM_RAW cleaning.

    line 1289 of /lib/formslib.php: call to debugging()
    line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
    line 202 of /lib/formslib.php: call to moodleform->_process_submission()
    line 44 of /mod/lesson/editpage_form.php: call to moodleform->moodleform()
    line 2734 of /mod/lesson/locallib.php: call to lesson_add_page_form_selection->__construct()
    line 69 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form()

Did you remember to call setType() for 'score'? Defaulting to PARAM_RAW cleaning.

    line 1289 of /lib/formslib.php: call to debugging()
    line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
    line 202 of /lib/formslib.php: call to moodleform->_process_submission()
    line 2734 of /mod/lesson/locallib.php: call to moodleform->moodleform()
    line 76 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form()

Did you remember to call setType() for 'score'? Defaulting to PARAM_RAW cleaning.

    line 1289 of /lib/formslib.php: call to debugging()
    line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
    line 202 of /lib/formslib.php: call to moodleform->_process_submission()
    line 2734 of /mod/lesson/locallib.php: call to moodleform->moodleform()
    line 76 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form()

Did you remember to call setType() for 'score'? Defaulting to PARAM_RAW cleaning.

    line 1289 of /lib/formslib.php: call to debugging()
    line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
    line 202 of /lib/formslib.php: call to moodleform->_process_submission()
    line 2734 of /mod/lesson/locallib.php: call to moodleform->moodleform()
    line 76 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form()

Did you remember to call setType() for 'score'? Defaulting to PARAM_RAW cleaning.

    line 1289 of /lib/formslib.php: call to debugging()
    line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
    line 202 of /lib/formslib.php: call to moodleform->_process_submission()
    line 2734 of /mod/lesson/locallib.php: call to moodleform->moodleform()
    line 76 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form()

Did you remember to call setType() for 'edit'? Defaulting to PARAM_RAW cleaning.

    line 1289 of /lib/formslib.php: call to debugging()
    line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
    line 202 of /lib/formslib.php: call to moodleform->_process_submission()
    line 2734 of /mod/lesson/locallib.php: call to moodleform->moodleform()
    line 76 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form()

Show

David Monllaó added a comment - 14/Apr/13 6:49 AM Adding more debugging messages, they appear when filling a new numerical question, haven't checked other questions: Did you remember to call setType() for 'edit'? Defaulting to PARAM_RAW cleaning. line 1289 of /lib/formslib.php: call to debugging() line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType() line 202 of /lib/formslib.php: call to moodleform->_process_submission() line 44 of /mod/lesson/editpage_form.php: call to moodleform->moodleform() line 2734 of /mod/lesson/locallib.php: call to lesson_add_page_form_selection->__construct() line 69 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form() Did you remember to call setType() for 'score'? Defaulting to PARAM_RAW cleaning. line 1289 of /lib/formslib.php: call to debugging() line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType() line 202 of /lib/formslib.php: call to moodleform->_process_submission() line 2734 of /mod/lesson/locallib.php: call to moodleform->moodleform() line 76 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form() Did you remember to call setType() for 'score'? Defaulting to PARAM_RAW cleaning. line 1289 of /lib/formslib.php: call to debugging() line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType() line 202 of /lib/formslib.php: call to moodleform->_process_submission() line 2734 of /mod/lesson/locallib.php: call to moodleform->moodleform() line 76 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form() Did you remember to call setType() for 'score'? Defaulting to PARAM_RAW cleaning. line 1289 of /lib/formslib.php: call to debugging() line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType() line 202 of /lib/formslib.php: call to moodleform->_process_submission() line 2734 of /mod/lesson/locallib.php: call to moodleform->moodleform() line 76 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form() Did you remember to call setType() for 'score'? Defaulting to PARAM_RAW cleaning. line 1289 of /lib/formslib.php: call to debugging() line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType() line 202 of /lib/formslib.php: call to moodleform->_process_submission() line 2734 of /mod/lesson/locallib.php: call to moodleform->moodleform() line 76 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form() Did you remember to call setType() for 'edit'? Defaulting to PARAM_RAW cleaning. line 1289 of /lib/formslib.php: call to debugging() line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType() line 202 of /lib/formslib.php: call to moodleform->_process_submission() line 2734 of /mod/lesson/locallib.php: call to moodleform->moodleform() line 76 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form()

Hide

Permalink

Stephen Bourget added a comment - 15/Apr/13 9:11 PM

These appear when adding a new true/false question: (Found while testing ~~MDLQA-5550~~)

Did you remember to call setType() for 'score'? Defaulting to PARAM_RAW cleaning.

line 1289 of /lib/formslib.php: call to debugging()
line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
line 202 of /lib/formslib.php: call to moodleform->_process_submission()
line 2734 of /mod/lesson/locallib.php: call to moodleform->moodleform()
line 76 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form()

Did you remember to call setType() for 'score'? Defaulting to PARAM_RAW cleaning.

Show

Stephen Bourget added a comment - 15/Apr/13 9:11 PM These appear when adding a new true/false question: (Found while testing MDLQA-5550 ) Did you remember to call setType() for 'score'? Defaulting to PARAM_RAW cleaning. line 1289 of /lib/formslib.php: call to debugging() line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType() line 202 of /lib/formslib.php: call to moodleform->_process_submission() line 2734 of /mod/lesson/locallib.php: call to moodleform->moodleform() line 76 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form() Did you remember to call setType() for 'score'? Defaulting to PARAM_RAW cleaning. line 1289 of /lib/formslib.php: call to debugging() line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType() line 202 of /lib/formslib.php: call to moodleform->_process_submission() line 2734 of /mod/lesson/locallib.php: call to moodleform->moodleform() line 76 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form()

Hide

Permalink

David Monllaó added a comment - 16/Apr/13 4:04 AM

Hi,

As talked yesterday in the meeting room, ~~MDL-38947~~ was blocked by this issue and we don't know if it will be included in 2.5, ~~MDL-38947~~ has been integrated with an extra I follow "Continue" step to continue after the blocked redirection provoked by the debugging messages (dev. path, is in integration right now: https://github.com/dmonllao/moodle/compare/MDL-38949_master...MDL-38947_master#L0R58) This issue should remove that step, otherwise the test will fail.

Show

David Monllaó added a comment - 16/Apr/13 4:04 AM Hi, As talked yesterday in the meeting room, MDL-38947 was blocked by this issue and we don't know if it will be included in 2.5, MDL-38947 has been integrated with an extra I follow "Continue" step to continue after the blocked redirection provoked by the debugging messages (dev. path, is in integration right now: https://github.com/dmonllao/moodle/compare/MDL-38949_master...MDL-38947_master#L0R58 ) This issue should remove that step, otherwise the test will fail.

Hide

Permalink

Joseph Rézeau added a comment - 21/Apr/13 4:20 PM

Should not this issue be considered a blocker and be solved before releasing Moodle 2.5 ?

Show

Joseph Rézeau added a comment - 21/Apr/13 4:20 PM Should not this issue be considered a blocker and be solved before releasing Moodle 2.5 ?

Hide

Permalink

Rossiani Wijaya added a comment - 26/Apr/13 5:34 AM

Create temporary fixed until MDL-38885 gets integrated.

Sending for peer-review.

Show

Rossiani Wijaya added a comment - 26/Apr/13 5:34 AM Create temporary fixed until MDL-38885 gets integrated. Sending for peer-review.

Hide

Permalink

Ankit Agarwal added a comment - 26/Apr/13 7:31 AM

Hi Rosie,
changes are good, however can you make sure a new issue is created once this is integrated to handle a more elegant solution?
Also please can you verify the behats are passing with your patch, as they might not (guessing that from David's comments).

Thanks

Show

Ankit Agarwal added a comment - 26/Apr/13 7:31 AM Hi Rosie, changes are good, however can you make sure a new issue is created once this is integrated to handle a more elegant solution? Also please can you verify the behats are passing with your patch, as they might not (guessing that from David's comments). Thanks

Hide

Permalink

Rossiani Wijaya added a comment - 01/May/13 3:48 AM - edited

Hi Ankit,

Thank you for reviewing.

I created ~~MDL-39369~~ to fixed this issue properly.

Pushing this for integration review.

Show

Rossiani Wijaya added a comment - 01/May/13 3:48 AM - edited Hi Ankit, Thank you for reviewing. I created MDL-39369 to fixed this issue properly. Pushing this for integration review.

Hide

Permalink

Dan Poltawski added a comment - 02/May/13 2:29 PM

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show

Dan Poltawski added a comment - 02/May/13 2:29 PM The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao

Hide

Permalink

Damyon Wiese added a comment - 03/May/13 7:47 AM

Thanks Rosie,

This looks great. Thanks for checking behat too.

Integrated to master.

Show

Damyon Wiese added a comment - 03/May/13 7:47 AM Thanks Rosie, This looks great. Thanks for checking behat too. Integrated to master.

Hide

Permalink

David Monllaó added a comment - 03/May/13 7:50 AM

Rossie, you saved a kitty's life

Show

David Monllaó added a comment - 03/May/13 7:50 AM Rossie, you saved a kitty's life

Hide

Permalink

Rossiani Wijaya added a comment - 03/May/13 7:53 AM

David, is it a Hello Kitty?

Show

Rossiani Wijaya added a comment - 03/May/13 7:53 AM David, is it a Hello Kitty?

Hide

Permalink

David Monllaó added a comment - 03/May/13 8:08 AM

I hope not

Show

David Monllaó added a comment - 03/May/13 8:08 AM I hope not

Hide

Permalink

Jérôme Mouneyrac added a comment - 03/May/13 9:36 AM - edited

I tested the test instructions, there are no setType errors. Passed. All little girls and pink manufacturers thank you for saving Hello Kitty.

However there are few unrelated warnings. Linked/commented an existing issue for them (~~MDL-37639~~). Thanks.

Show

Jérôme Mouneyrac added a comment - 03/May/13 9:36 AM - edited I tested the test instructions, there are no setType errors. Passed. All little girls and pink manufacturers thank you for saving Hello Kitty. However there are few unrelated warnings. Linked/commented an existing issue for them ( MDL-37639 ). Thanks.

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 10/May/13 4:37 PM

Did you think this day was not going to arrive ever?

Your patience has been rewarded, yay, sent upstream, thanks!

Closing...ciao

Show

Eloy Lafuente (stronk7) added a comment - 10/May/13 4:37 PM Did you think this day was not going to arrive ever? Your patience has been rewarded, yay, sent upstream, thanks! Closing...ciao

People

Assignee:

Rossiani Wijaya

Reporter:

Damyon Wiese

Peer reviewer:

Ankit Agarwal

Integrator:

Damyon Wiese

Tester:

Jérôme Mouneyrac

Participants:

Ankit Agarwal, Damyon Wiese, Dan Poltawski, David Monllaó, Eloy Lafuente (stronk7), Frédéric Massart, Jérôme Mouneyrac, Joseph Rézeau, Rossiani Wijaya, Stephen Bourget

Vote (0)

Watch (8)

Dates

Created:

26/Mar/13 6:17 AM

Updated:

30/Sep/13 1:28 PM

Resolved:

10/May/13 4:37 PM

Agile

View on Board