Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34311 Improve debugging when using default cleaning
  3. MDL-38714

Lesson edit page not calling setType for hidden and text inputs

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Lesson
    • Labels:
    • Testing Instructions:
      Hide
      1. Set debugger to 'developer'
      2. Create new lesson
      3. Enable 'Allow student review"
      4. Add a matching question
      5. Add a multiple choices question
      6. Edit the existing questions
      7. Attempt the lesson as student
      8. Review the lesson

      Make sure there is no warning for setType() through out the above process.

      Show
      Set debugger to 'developer' Create new lesson Enable 'Allow student review" Add a matching question Add a multiple choices question Edit the existing questions Attempt the lesson as student Review the lesson Make sure there is no warning for setType() through out the above process.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-38714_tmp
    • Pull Master Diff URL:

      Description

      This now triggers debugging messages since MDL-34311.

      Did you remember to call setType() for 'edit'? Defaulting to PARAM_RAW cleaning.
      line 1266 of /lib/formslib.php: call to debugging()
      line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      line 202 of /lib/formslib.php: call to moodleform->_process_submission()
      line 44 of /mod/lesson/editpage_form.php: call to moodleform->moodleform()
      line 2734 of /mod/lesson/locallib.php: call to lesson_add_page_form_selection->__construct()
      line 69 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form()
      Did you remember to call setType() for 'score[0]'? Defaulting to PARAM_RAW cleaning.
      line 1266 of /lib/formslib.php: call to debugging()
      line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      line 202 of /lib/formslib.php: call to moodleform->_process_submission()
      line 2734 of /mod/lesson/locallib.php: call to moodleform->moodleform()
      line 76 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form()
      Did you remember to call setType() for 'score[1]'? Defaulting to PARAM_RAW cleaning.

        Attachments

          Issue Links

          blocks

          Functional Test - A test of a single Moodle feature MDLQA-5550 CLONE - File picker can be used to add a Pop-up to file or web page in a lesson.

          • Passed
          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-38986 Error notice Did you remember to call setType() for 'score'?

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-37639 Not selecting a matching answer in the Lesson module causes PHP notice.

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              rwijaya Rossiani Wijaya
              Reporter:
              damyon Damyon Wiese
              Peer reviewer:
              Ankit Agarwal
              Integrator:
              Damyon Wiese
              Tester:
              Jérôme Mouneyrac
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/13