Also found that when adding some questions some messages are displayed too

Did you remember to call setType() for 'score'? Defaulting to PARAM_RAW cleaning.
line 1275 of /lib/formslib.php: call to debugging()
line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
line 202 of /lib/formslib.php: call to moodleform->_process_submission()
line 2734 of /mod/lesson/locallib.php: call to moodleform->moodleform()
line 76 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form()

Did you remember to call setType() for 'score'? Defaulting to PARAM_RAW cleaning.
line 1275 of /lib/formslib.php: call to debugging()
line 919 of /lib/formslib.php: call to moodleform->detectMissingSetType()
line 129 of /mod/lesson/editpage.php: call to moodleform->display()

Hi Rosie,
As discussed in dev chat

$this->_form->setType('response_editor', PARAM_TEXT); 

should be

$this->_form->setType('response_editor['.$count.]', PARAM_TEXT);

similarly it should be done for score as well.
Rest looks good. I didn't find any orphan text,hidden and url elements in lesson
Thanks

I've opened MDL-38885 for that [] problem.

Waiting on the decision for MDL-38885 in order to fix this properly.

The above patch is based on the current patch available for MDL-38885.

Adding more debugging messages, they appear when filling a new numerical question, haven't checked other questions:

Did you remember to call setType() for 'edit'? Defaulting to PARAM_RAW cleaning.

    line 1289 of /lib/formslib.php: call to debugging()
    line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
    line 202 of /lib/formslib.php: call to moodleform->_process_submission()
    line 44 of /mod/lesson/editpage_form.php: call to moodleform->moodleform()
    line 2734 of /mod/lesson/locallib.php: call to lesson_add_page_form_selection->__construct()
    line 69 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form()

Did you remember to call setType() for 'score'? Defaulting to PARAM_RAW cleaning.

    line 1289 of /lib/formslib.php: call to debugging()
    line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
    line 202 of /lib/formslib.php: call to moodleform->_process_submission()
    line 2734 of /mod/lesson/locallib.php: call to moodleform->moodleform()
    line 76 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form()

Did you remember to call setType() for 'score'? Defaulting to PARAM_RAW cleaning.

    line 1289 of /lib/formslib.php: call to debugging()
    line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
    line 202 of /lib/formslib.php: call to moodleform->_process_submission()
    line 2734 of /mod/lesson/locallib.php: call to moodleform->moodleform()
    line 76 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form()

Did you remember to call setType() for 'score'? Defaulting to PARAM_RAW cleaning.

    line 1289 of /lib/formslib.php: call to debugging()
    line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
    line 202 of /lib/formslib.php: call to moodleform->_process_submission()
    line 2734 of /mod/lesson/locallib.php: call to moodleform->moodleform()
    line 76 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form()

Did you remember to call setType() for 'score'? Defaulting to PARAM_RAW cleaning.

    line 1289 of /lib/formslib.php: call to debugging()
    line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
    line 202 of /lib/formslib.php: call to moodleform->_process_submission()
    line 2734 of /mod/lesson/locallib.php: call to moodleform->moodleform()
    line 76 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form()

Did you remember to call setType() for 'edit'? Defaulting to PARAM_RAW cleaning.

    line 1289 of /lib/formslib.php: call to debugging()
    line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
    line 202 of /lib/formslib.php: call to moodleform->_process_submission()
    line 2734 of /mod/lesson/locallib.php: call to moodleform->moodleform()
    line 76 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form()

These appear when adding a new true/false question: (Found while testing MDLQA-5550)

Did you remember to call setType() for 'score'? Defaulting to PARAM_RAW cleaning.

line 1289 of /lib/formslib.php: call to debugging()
line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
line 202 of /lib/formslib.php: call to moodleform->_process_submission()
line 2734 of /mod/lesson/locallib.php: call to moodleform->moodleform()
line 76 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form()

Did you remember to call setType() for 'score'? Defaulting to PARAM_RAW cleaning.

line 1289 of /lib/formslib.php: call to debugging()
line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
line 202 of /lib/formslib.php: call to moodleform->_process_submission()
line 2734 of /mod/lesson/locallib.php: call to moodleform->moodleform()
line 76 of /mod/lesson/editpage.php: call to lesson_page_type_manager->get_page_form()

Hi,

As talked yesterday in the meeting room, MDL-38947 was blocked by this issue and we don't know if it will be included in 2.5, MDL-38947 has been integrated with an extra I follow "Continue" step to continue after the blocked redirection provoked by the debugging messages (dev. path, is in integration right now: https://github.com/dmonllao/moodle/compare/MDL-38949_master...MDL-38947_master#L0R58) This issue should remove that step, otherwise the test will fail.

Should not this issue be considered a blocker and be solved before releasing Moodle 2.5 ?

Create temporary fixed until MDL-38885 gets integrated.

Sending for peer-review.

Hi Rosie,
changes are good, however can you make sure a new issue is created once this is integrated to handle a more elegant solution?
Also please can you verify the behats are passing with your patch, as they might not (guessing that from David's comments).

Thanks

Hi Ankit,

Thank you for reviewing.

I created MDL-39369 to fixed this issue properly.

Pushing this for integration review.

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Thanks Rosie,

This looks great. Thanks for checking behat too.

Integrated to master.

Rossie, you saved a kitty's life

David, is it a Hello Kitty?

I hope not

I tested the test instructions, there are no setType errors. Passed. All little girls and pink manufacturers thank you for saving Hello Kitty.

However there are few unrelated warnings. Linked/commented an existing issue for them (MDL-37639). Thanks.

Did you think this day was not going to arrive ever?

Your patience has been rewarded, yay, sent upstream, thanks!

Closing...ciao