Details

    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Rank:
      48771

      Description

      This is a followup of MDL-34311, where the new debugging caused phpunit to start failing badly.

      As far as we need tests passing (for better/safer integration), this only will fix the occurrences needed to make phpunit to pass ok.

        Issue Links

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          fixed cache store forms...
          fixed formslib unit tests...

          Show
          Eloy Lafuente (stronk7) added a comment - fixed cache store forms... fixed formslib unit tests...
          Hide
          Eloy Lafuente (stronk7) added a comment - - edited

          Done, I've added 2 commits:

          https://github.com/stronk7/moodle/compare/MDL-38719%5E%5E...MDL-38719

          The 1st is the one adding missing types and the second is an obvious fix to set_repetitions() that was setting the type to the original element(s) not belonging to the form, instead of the real repetitions. Surely that 2nd commit should be backported. For your consideration.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - - edited Done, I've added 2 commits: https://github.com/stronk7/moodle/compare/MDL-38719%5E%5E...MDL-38719 The 1st is the one adding missing types and the second is an obvious fix to set_repetitions() that was setting the type to the original element(s) not belonging to the form, instead of the real repetitions. Surely that 2nd commit should be backported. For your consideration. Ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          That, or I'm wrong and, for repetitions the type is expected to be only once in the "non-exiting" element on purpose. Uhm... going to add some tests. grrr^3

          Show
          Eloy Lafuente (stronk7) added a comment - That, or I'm wrong and, for repetitions the type is expected to be only once in the "non-exiting" element on purpose. Uhm... going to add some tests. grrr^3
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Bah, I'm not going to change the way types are stored for repetitions right now.

          Instead, I'm going to hack detectMissingSetType() so it's able to look for the "general" type for a repeated element and done.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Bah, I'm not going to change the way types are stored for repetitions right now. Instead, I'm going to hack detectMissingSetType() so it's able to look for the "general" type for a repeated element and done. Ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Done, 2 commits again, the first are the fixes to the missing types and the second is a change in detectMissingSetType() to perform the check against the expected type (crazy non-existent element, but it's the way formslib handles types.

          https://github.com/stronk7/moodle/compare/MDL-38719%5E%5E...MDL-38719

          For your consideration, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Done, 2 commits again, the first are the fixes to the missing types and the second is a change in detectMissingSetType() to perform the check against the expected type (crazy non-existent element, but it's the way formslib handles types. https://github.com/stronk7/moodle/compare/MDL-38719%5E%5E...MDL-38719 For your consideration, ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Oki, I'm self-integrating and self-passing this.

          I cannot imagine other (less-intrusive) way to keep the thing performing the verification and passing. My initial idea of assigning the types to each repetition seemed to much risky (although more correct in the long term), but would have leaded to more changes in formslib (processing submissions...).

          If you imagine other better way to make detectMissingSetType() to validate repetition types... feel free.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Oki, I'm self-integrating and self-passing this. I cannot imagine other (less-intrusive) way to keep the thing performing the verification and passing. My initial idea of assigning the types to each repetition seemed to much risky (although more correct in the long term), but would have leaded to more changes in formslib (processing submissions...). If you imagine other better way to make detectMissingSetType() to validate repetition types... feel free. Ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated.

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Passed.

          Show
          Eloy Lafuente (stronk7) added a comment - Passed.
          Hide
          Damyon Wiese added a comment -

          Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

          Show
          Damyon Wiese added a comment - Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

            People

            • Assignee:
              Eloy Lafuente (stronk7)
              Reporter:
              Eloy Lafuente (stronk7)
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Eloy Lafuente (stronk7)
              Participants:
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: