Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38722

function login_info() needs to be using html_writer and have class identifiers on elements

    XMLWordPrintable

Details

    • MOODLE_23_STABLE
    • git@github.com:lamiette/moodle.git
    • Hide
      1. Login/Logout.
      2. Login and switch role
      3. login as another user
      4. Login from remote MNET site.

      Check that links have classes and correct switchrole=, MNET provider and login as details are provided.

      Show
      Login/Logout. Login and switch role login as another user Login from remote MNET site. Check that links have classes and correct switchrole=, MNET provider and login as details are provided.

    Description

      The function login_info() in lib/outputrenderers.php is still hardcoding things and should be moved to use html_writer.

      It also has one or two hardcoded language strings and it would be useful if class identifiers were added to elements so they can be selectable in theme or YUI code.

      Attachments

        Issue Links

          Discovered while testing

          Improvement - An enhancement to an existing Moodle feature. MDL-40273 Remove failed login notification from login_info renderer

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-39909 core_renderer's $OUTPUT->login_info() needs to provide some css selector to theme the links it outputs.

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will help resolve

          Improvement - An enhancement to an existing Moodle feature. MDL-40160 Make the login page into a renderer

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              Unassigned Unassigned
              stacey Stacey Walker
              Marina Glancy Marina Glancy
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Huong Nguyen, Bas Brands, Mathew May
              Votes:
              3 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: