Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.6, 2.4, 2.5
    • Fix Version/s: 2.3.8, 2.4.5, 2.5.1
    • Component/s: Course
    • Labels:
    • Rank:
      48784

      Description

      We found that the title 'Groups' for the section in course administration settings form is been misunderstood very often by German teachers. We want to change the name in German language pack to 'Default settings for group work'. Well, this is no problem generally but we found that the same string is used also at other locations like enrol/users.php?id=x table header.

      Please create a new languagestrig that is used as name for section only.

      This is specially relevant in Moodle 2.5 when sections are closed by default and we need very well understandable section names

        Activity

        Hide
        Dan Poltawski added a comment -

        Thanks Ralf, agreed lang strings shouldn't be shared like this.

        Show
        Dan Poltawski added a comment - Thanks Ralf, agreed lang strings shouldn't be shared like this.
        Hide
        Dan Poltawski added a comment -

        Fred - do you want to take this? (I will do it, just worried about conflicting with your stuff).

        Show
        Dan Poltawski added a comment - Fred - do you want to take this? (I will do it, just worried about conflicting with your stuff).
        Hide
        Frédéric Massart added a comment -

        I'll leave that to you Dan, I know it's only a string change but I don't have much time to wrap things up. (It will conflict yes, but not sure the course settings issue will get integrated soon).

        Show
        Frédéric Massart added a comment - I'll leave that to you Dan, I know it's only a string change but I don't have much time to wrap things up. (It will conflict yes, but not sure the course settings issue will get integrated soon).
        Hide
        Dan Poltawski added a comment -

        Helen,

        Just adding you here to ask if you think there should be a better name for it in english too?

        Show
        Dan Poltawski added a comment - Helen, Just adding you here to ask if you think there should be a better name for it in english too?
        Hide
        Helen Foster added a comment -

        Dan, thanks for adding me as a watcher. I suggest we go for implementing the improvement MDL-38577, rather than changing the section name.

        'Default settings for group work' doesn't exactly cover it, since the groups settings also control whether groups are displayed on the participants page, gradebook etc. Also, all the section names are very short - only one or two words. (The section name 'Formatting options for Weekly format' is due to be removed.) I can't think of a better short description in English for the groups settings than what we currently have.

        Show
        Helen Foster added a comment - Dan, thanks for adding me as a watcher. I suggest we go for implementing the improvement MDL-38577 , rather than changing the section name. 'Default settings for group work' doesn't exactly cover it, since the groups settings also control whether groups are displayed on the participants page, gradebook etc. Also, all the section names are very short - only one or two words. (The section name 'Formatting options for Weekly format' is due to be removed.) I can't think of a better short description in English for the groups settings than what we currently have.
        Hide
        Dan Poltawski added a comment -

        Ok, so i'll just split these into two different strings to help translators, but keep the strings the same. Sound OK?

        Show
        Dan Poltawski added a comment - Ok, so i'll just split these into two different strings to help translators, but keep the strings the same. Sound OK?
        Hide
        Ralf Hilgenstock added a comment -

        Dan, Helen
        That would be helpfull for us.

        @Helen we found that two or three word sction names are understandable much better than one word names. Through the changes in 2.5 with collapsable sections the names of the sections are much more relevant for users orientation than before. We think also about not experienced user and non native users with english interface

        Ralf.

        Show
        Ralf Hilgenstock added a comment - Dan, Helen That would be helpfull for us. @Helen we found that two or three word sction names are understandable much better than one word names. Through the changes in 2.5 with collapsable sections the names of the sections are much more relevant for users orientation than before. We think also about not experienced user and non native users with english interface Ralf.
        Hide
        Dan Poltawski added a comment -

        Putting up for peer review, I spent a while trying to think of a good string identifier and din't really get one.

        Show
        Dan Poltawski added a comment - Putting up for peer review, I spent a while trying to think of a good string identifier and din't really get one.
        Hide
        Frédéric Massart added a comment -

        Looks good to me Dan, I just wonder if AMOS expects the component to start with core_. I also checked that the header was not used in the module settings, and it's not. Feel free to push for integration.

        Show
        Frédéric Massart added a comment - Looks good to me Dan, I just wonder if AMOS expects the component to start with core_. I also checked that the header was not used in the module settings, and it's not. Feel free to push for integration.
        Hide
        Dan Poltawski added a comment -

        Thanks Fred - I've added David here - david, does the AMOS script need core_group?

        Show
        Dan Poltawski added a comment - Thanks Fred - I've added David here - david, does the AMOS script need core_group?
        Hide
        David Mudrak added a comment -

        AMOS handles well with both "group" and "core_group". I prefer DEVs using the full frankenstyle name everywhere (in get_string() as well as in AMOScript) but the legacy non-prefixed form is valid.

        Show
        David Mudrak added a comment - AMOS handles well with both "group" and "core_group". I prefer DEVs using the full frankenstyle name everywhere (in get_string() as well as in AMOScript) but the legacy non-prefixed form is valid.
        Hide
        Dan Poltawski added a comment -

        (oops, dropped the ball on this)

        Sending for integration.

        Show
        Dan Poltawski added a comment - (oops, dropped the ball on this) Sending for integration.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (23, 24, 25 & master), thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (23, 24, 25 & master), thanks!
        Hide
        Mark Nelson added a comment -

        Working as expected, thanks. Passing.

        Show
        Mark Nelson added a comment - Working as expected, thanks. Passing.
        Hide
        Dan Poltawski added a comment -
        Feature: Thanks to our superb contributors
          In order to make Moodle better
          As an integrator
          I need to thank all our contributors
        
          Scenario: Dan thanks you all
            Given I log in as "dan"
            And I see "lots of fixed issues"
            When I follow "Close integrated issues"
            Then I should see "Lots of thanks to all our contributors"
        

        Your changes are upstream

        Show
        Dan Poltawski added a comment - Feature: Thanks to our superb contributors In order to make Moodle better As an integrator I need to thank all our contributors Scenario: Dan thanks you all Given I log in as "dan" And I see "lots of fixed issues" When I follow "Close integrated issues" Then I should see "Lots of thanks to all our contributors" Your changes are upstream

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: