Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.4.3
    • Fix Version/s: 2.5
    • Component/s: Forms Library
    • Labels:

      Description

      Enable/disable a portfolio element.

      It generates following notice

      Did you remember to call setType() for 'name'? Defaulting to PARAM_RAW cleaning.
       
          line 1275 of /lib/formslib.php: call to debugging()
          line 919 of /lib/formslib.php: call to moodleform->detectMissingSetType()
          line 101 of /admin/portfolio.php: call to moodleform->display()
      

        Gliffy Diagrams

          Activity

          Hide
          poltawski Dan Poltawski added a comment -

          Think this should be PARAM_TEXT to allow for multilang.

          Show
          poltawski Dan Poltawski added a comment - Think this should be PARAM_TEXT to allow for multilang.
          Hide
          damyon Damyon Wiese added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          Thanks!

          Show
          damyon Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks!

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
          Hide
          rwijaya Rossiani Wijaya added a comment -

          This works as expected.

          Test passed.

          Show
          rwijaya Rossiani Wijaya added a comment - This works as expected. Test passed.
          Hide
          poltawski Dan Poltawski added a comment -

          Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

          line 1289 of \lib\changes.php: call to debugging()
          line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
          line 202 of \lib\now.php: call to moodleform->_is_poor_form()
          line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

          Show
          poltawski Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/13