Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34311 Improve debugging when using default cleaning
  3. MDL-38744

Course completion form not calling setType for criteria_grade_value and locale aware floats

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Course completion
    • Labels:
    • Testing Instructions:
      Hide
      1. Edit course settings
      2. In course settings > completion progress > set completion progress to enabled
      3. Go to course settings > completion tracking
      4. VERIFY: no debugging message is displayed
      5. In the Course grade section, set to enabled and add a float value in the grade section
      6. Save the settings
      7. VERIFY: the grade is saved by browsing back to the form
      8. Change your language to french
      9. Add a decimal value using a ','
      10. VERIFY the value is saved
      Show
      Edit course settings In course settings > completion progress > set completion progress to enabled Go to course settings > completion tracking VERIFY: no debugging message is displayed In the Course grade section, set to enabled and add a float value in the grade section Save the settings VERIFY: the grade is saved by browsing back to the form Change your language to french Add a decimal value using a ',' VERIFY the value is saved
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      MDL-38744-master

      Description

      This now triggers debugging messages since MDL-34311.

      Did you remember to call setType() for 'criteria_grade_value'? Defaulting to PARAM_RAW cleaning.
      * line 1275 of /lib/formslib.php: call to debugging()
      * line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      * line 202 of /lib/formslib.php: call to moodleform->_process_submission()
      * line 73 of /course/completion.php: call to moodleform->moodleform()
      

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/May/13